Fix pmd problems

Author: AB-xdev

src/main/java/software/xdev/saveactions/processors/java/inspection/CustomAccessCanBeTightenedInspection.java

@@ -86,7 +86,7 @@
  *
  * @see com.intellij.codeInspection.visibility.AccessCanBeTightenedInspection
  */
-@SuppressWarnings({"java:S6201", "java:S3776", "java:S125", "java:S3398", "java:S2637", "java:S120", "java:S6541", "java:S135"})
+@SuppressWarnings({"java:S6201", "java:S3776", "java:S125", "java:S3398", "java:S2637", "java:S120", "java:S6541", "java:S135", "PMD"})
 public class CustomAccessCanBeTightenedInspection extends AbstractBaseJavaLocalInspectionTool {
     private static final Logger LOG = Logger.getInstance(CustomAccessCanBeTightenedInspection.class);
     private final VisibilityInspection myVisibilityInspection;

src/main/java/software/xdev/saveactions/processors/java/inspection/style/CustomUnqualifiedStaticUsageInspection.java

@@ -85,6 +85,7 @@ public void visitReferenceExpression(@NotNull final PsiReferenceExpression expre
 			this.registerError(expression, expression);
 		}
 
+		@SuppressWarnings("PMD.NPathComplexity")
 		private boolean isUnqualifiedStaticAccess(final PsiReferenceExpression expression)
 		{
 			if(CustomUnqualifiedStaticUsageInspection.this.m_ignoreStaticAccessFromStaticContext)

src/main/java/software/xdev/saveactions/ui/BuildPanel.java

@@ -123,7 +123,7 @@ private boolean hasId(final String id)
 
 		private String getId()
 		{
-			return this.quickList.hashCode() + "";
+			return String.valueOf(this.quickList.hashCode());
 		}
 
 		@Override

src/main/java/software/xdev/saveactions/ui/FileMaskPanel.java

@@ -116,7 +116,7 @@ private InputValidator getRegexInputValidator()
 			@Override
 			public boolean checkInput(final String string)
 			{
-				if(string == null || string.trim().isEmpty())
+				if(string == null || string.isBlank())
 				{
 					// do not allow null or blank entries
 					return false;

src/test/java/software/xdev/saveactions/junit/JUnit5Utils.java

@@ -15,15 +15,14 @@ private JUnit5Utils()
 
 	public static void rethrowAsJunit5Error(final AssertionError error)
 	{
-		if(error.getCause() instanceof final InvocationTargetException intellijInternal)
+		if(error.getCause() instanceof final InvocationTargetException intellijInternal
+			&& intellijInternal.getCause() instanceof final FileComparisonFailure fileComparisonFailure)
 		{
-			if(intellijInternal.getCause() instanceof final FileComparisonFailure fileComparisonFailure)
-			{
-				final String expected = fileComparisonFailure.getExpected();
-				final String actual = fileComparisonFailure.getActual();
-				throw new AssertionFailedError("Expected file do not match actual file", expected, actual);
-			}
+			final String expected = fileComparisonFailure.getExpected();
+			final String actual = fileComparisonFailure.getActual();
+			throw new AssertionFailedError("Expected file do not match actual file", expected, actual);
 		}
+		
 		throw error;
 	}