Only compute name for recording when required

Author: AB-xdev

CHANGELOG.md

@@ -3,6 +3,7 @@
   * If not ``null``: Waits the amount of specified time before saving the recording
   * This way no frames that may show the problem are accidentally lost
   * Default value is set to ``70ms`` which is 1 full frame when recording at the default 15 FPS
+* Only compute name for recording when required
 
 # 1.2.3
 * Make some constants externally accessible

testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/BrowserWebDriverContainer.java

@@ -35,6 +35,7 @@
 import java.util.Optional;
 import java.util.concurrent.TimeUnit;
 import java.util.function.Function;
+import java.util.function.Supplier;
 import java.util.stream.Collectors;
 import java.util.stream.IntStream;
 
@@ -450,50 +451,56 @@ public void stop()
 	@Override
 	public void afterTest(final TestDescription description, final Optional<Throwable> throwable)
 	{
-		this.retainRecordingIfNeeded(description.getFilesystemFriendlyName(), throwable.isEmpty());
+		this.retainRecordingIfNeeded(description::getFilesystemFriendlyName, throwable.isEmpty());
 	}
 
-	protected void retainRecordingIfNeeded(final String testName, final boolean succeeded)
+	protected void retainRecordingIfNeeded(final Supplier<String> testNameSupplier, final boolean succeeded)
 	{
+		// Should recording be retained?
 		if(switch(this.recordingMode)
 		{
-			case RECORD_ALL -> true;
-			case RECORD_FAILING -> !succeeded;
-			default -> false;
+			case RECORD_ALL -> false;
+			case RECORD_FAILING -> succeeded;
+			default -> true;
 		})
 		{
-			if(this.beforeRecordingSaveWaitTime != null)
-			{
-				try
-				{
-					Thread.sleep(this.beforeRecordingSaveWaitTime.toMillis());
-				}
-				catch(final InterruptedException e)
-				{
-					Thread.currentThread().interrupt();
-					throw new IllegalStateException("Got interrupted", e);
-				}
-			}
+			return;
+		}
+		
+		if(this.beforeRecordingSaveWaitTime != null)
+		{
 			try
 			{
-				final Path recording = Timeouts.getWithTimeout(
-					(int)this.recordingSaveTimeout.toSeconds(),
-					TimeUnit.SECONDS,
-					() -> this.recordingContainer.saveRecordingToFile(
-						this.recordingDirectory,
-						this.testRecordingFileNameFactory.buildNameWithoutExtension(testName, succeeded))
-				);
-				LOG.info("Screen recordings for test {} will be stored at: {}", testName, recording);
+				Thread.sleep(this.beforeRecordingSaveWaitTime.toMillis());
 			}
-			catch(final org.rnorth.ducttape.TimeoutException te)
+			catch(final InterruptedException e)
 			{
-				LOG.warn("Timed out while saving recording for test {}", testName, te);
-			}
-			catch(final Exception ex)
-			{
-				LOG.warn("Failed to save recording for test {}", testName, ex);
+				Thread.currentThread().interrupt();
+				throw new IllegalStateException("Got interrupted", e);
 			}
 		}
+		
+		// Get testname only when required to improve performance
+		final String testName = testNameSupplier.get();
+		try
+		{
+			final Path recording = Timeouts.getWithTimeout(
+				(int)this.recordingSaveTimeout.toSeconds(),
+				TimeUnit.SECONDS,
+				() -> this.recordingContainer.saveRecordingToFile(
+					this.recordingDirectory,
+					this.testRecordingFileNameFactory.buildNameWithoutExtension(testName, succeeded))
+			);
+			LOG.info("Screen recordings for test {} will be stored at: {}", testName, recording);
+		}
+		catch(final org.rnorth.ducttape.TimeoutException te)
+		{
+			LOG.warn("Timed out while saving recording for test {}", testName, te);
+		}
+		catch(final Exception ex)
+		{
+			LOG.warn("Failed to save recording for test {}", testName, ex);
+		}
 	}
 
 	@Override