Skip to content

Commit 63d829b

Browse files
committed
Fix sonar problems
1 parent 510e38e commit 63d829b

File tree

8 files changed

+10
-12
lines changed

8 files changed

+10
-12
lines changed

vaadin-breadcrumbs-demo/src/main/java/software/xdev/vaadin/ui/HomeView.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import com.vaadin.flow.router.Route;
88

99

10-
@Route(value = "", layout = MainLayout.class)
10+
@Route("")
1111
public class HomeView extends VerticalLayout
1212
{
1313
public HomeView()

vaadin-breadcrumbs-demo/src/main/java/software/xdev/vaadin/ui/MainLayout.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import com.vaadin.flow.component.orderedlayout.VerticalLayout;
1111
import com.vaadin.flow.component.sidenav.SideNav;
1212
import com.vaadin.flow.component.sidenav.SideNavItem;
13+
import com.vaadin.flow.router.Layout;
1314
import com.vaadin.flow.router.PageTitle;
1415

1516
import software.xdev.vaadin.breadcrumbs.Breadcrumbs;
@@ -19,6 +20,7 @@
1920
import software.xdev.vaadin.ui.cars.brand.HybridView;
2021

2122

23+
@Layout
2224
@PageTitle("Breadcrumb Demo")
2325
public class MainLayout extends AppLayout
2426
{

vaadin-breadcrumbs-demo/src/main/java/software/xdev/vaadin/ui/cars/AbstractCarView.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
public abstract class AbstractCarView extends VerticalLayout
1414
{
15-
1615
protected AbstractCarView()
1716
{
1817
final CarGrid carGrid = new CarGrid(this.getCars());

vaadin-breadcrumbs-demo/src/main/java/software/xdev/vaadin/ui/cars/CarsView.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,8 @@
44

55
import com.vaadin.flow.router.Route;
66

7-
import software.xdev.vaadin.ui.MainLayout;
87

9-
10-
@Route(value = "cars", layout = MainLayout.class)
8+
@Route("cars")
119
public class CarsView extends AbstractCarView
1210
{
1311
@Override

vaadin-breadcrumbs-demo/src/main/java/software/xdev/vaadin/ui/cars/brand/ElectricView.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,11 @@
66

77
import com.vaadin.flow.router.Route;
88

9-
import software.xdev.vaadin.ui.MainLayout;
109
import software.xdev.vaadin.ui.cars.AbstractCarView;
1110
import software.xdev.vaadin.ui.cars.Car;
1211

1312

14-
@Route(value = "cars/electric", layout = MainLayout.class)
13+
@Route("cars/electric")
1514
public class ElectricView extends AbstractCarView
1615
{
1716
@Override

vaadin-breadcrumbs-demo/src/main/java/software/xdev/vaadin/ui/cars/brand/GasolineView.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,11 @@
66

77
import com.vaadin.flow.router.Route;
88

9-
import software.xdev.vaadin.ui.MainLayout;
109
import software.xdev.vaadin.ui.cars.AbstractCarView;
1110
import software.xdev.vaadin.ui.cars.Car;
1211

1312

14-
@Route(value = "cars/gasoline", layout = MainLayout.class)
13+
@Route("cars/gasoline")
1514
public class GasolineView extends AbstractCarView
1615
{
1716
@Override

vaadin-breadcrumbs-demo/src/main/java/software/xdev/vaadin/ui/cars/brand/HybridView.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,11 @@
66

77
import com.vaadin.flow.router.Route;
88

9-
import software.xdev.vaadin.ui.MainLayout;
109
import software.xdev.vaadin.ui.cars.AbstractCarView;
1110
import software.xdev.vaadin.ui.cars.Car;
1211

1312

14-
@Route(value = "cars/hybrid", layout = MainLayout.class)
13+
@Route("cars/hybrid")
1514
public class HybridView extends AbstractCarView
1615
{
1716
@Override

vaadin-breadcrumbs/src/main/java/software/xdev/vaadin/breadcrumbs/Breadcrumbs.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
/**
3333
* Represents a horizontal breadcrumb navigation bar
3434
*/
35+
@SuppressWarnings("java:S1948")
3536
@CssImport("./styles/breadcrumb.css")
3637
public class Breadcrumbs extends HorizontalLayout
3738
{
@@ -41,7 +42,8 @@ public class Breadcrumbs extends HorizontalLayout
4142
protected static final String BREADCRUMBS_CONTAINER_CLASS = "breadcrumbs-container";
4243

4344
protected String homeBreadcrumbName = "Home";
44-
protected BiFunction<List<String>, String, String> breadcrumbNameResolver = (parts, part) -> part;
45+
protected BiFunction<List<String>, String, String> breadcrumbNameResolver =
46+
(parts, part) -> part;
4547

4648
public Breadcrumbs(final String path)
4749
{

0 commit comments

Comments
 (0)