Skip to content

Commit 7e43671

Browse files
committed
Removed use case that could never happen
The url is never empty and contains always at least a "/"
1 parent bf27ea5 commit 7e43671

File tree

2 files changed

+3
-15
lines changed

2 files changed

+3
-15
lines changed

vaadin-breadcrumbs/src/main/java/software/xdev/vaadin/breadcrumbs/Breadcrumbs.java

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ public class Breadcrumbs extends HorizontalLayout
4040

4141
protected static final String BREADCRUMB_CLASS = "breadcrumb";
4242
protected static final String BREADCRUMBS_CONTAINER_CLASS = "breadcrumbs-container";
43-
protected static final String BREADCRUMB_DISABLED_CLASS = "breadcrumb-disabled";
4443

4544
public Breadcrumbs(final String path)
4645
{
@@ -64,15 +63,16 @@ public void updatePath(final String path)
6463
final List<Breadcrumb> breadcrumbs = new ArrayList<>();
6564
breadcrumbs.add(new Breadcrumb(this.getTranslation(I18N_PREFIX + "home"), DELIMITER_URL));
6665

67-
final List<String> partsList = new ArrayList<>(Arrays.asList(path.split(DELIMITER_URL)));
66+
final List<String> parts = new ArrayList<>(Arrays.asList(path.split(DELIMITER_URL)));
6867

6968
final StringBuilder hrefBuilder = new StringBuilder();
70-
for(final String part : partsList)
69+
for(final String part : parts)
7170
{
7271
if(!part.isEmpty())
7372
{
7473
// append to full link
7574
hrefBuilder.append(DELIMITER_URL).append(part);
75+
7676
final String title = this.getTranslation(I18N_PREFIX + part.toLowerCase());
7777

7878
breadcrumbs.add(new Breadcrumb(title, hrefBuilder.toString()));
@@ -99,13 +99,6 @@ protected void updateView(final List<Breadcrumb> breadcrumbs)
9999
final Anchor anchor = new Anchor(breadcrumb.url(), breadcrumb.label());
100100
anchor.addClassName(BREADCRUMB_CLASS);
101101

102-
// remove link and set css if url is empty (e.g. for 'edit' pages)
103-
if(breadcrumb.url().isEmpty())
104-
{
105-
anchor.removeHref();
106-
anchor.addClassName(BREADCRUMB_DISABLED_CLASS);
107-
}
108-
109102
layout.add(anchor);
110103
}
111104
this.add(layout);

vaadin-breadcrumbs/src/main/resources/META-INF/resources/frontend/styles/breadcrumb.css

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,3 @@
4545
.breadcrumb:hover {
4646
text-decoration: underline;
4747
}
48-
49-
.breadcrumb-disabled {
50-
color: var(--lumo-text-primary) !important;
51-
cursor: default;
52-
}

0 commit comments

Comments
 (0)