Skip to content

Commit 9cb995a

Browse files
authored
Merge pull request #22 from xdev-software/develop
Release
2 parents 942bc32 + 2137a71 commit 9cb995a

File tree

11 files changed

+69
-158
lines changed

11 files changed

+69
-158
lines changed

.github/dependabot.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,11 @@ updates:
2121
time: "00:00"
2222
open-pull-requests-limit: 10
2323
ignore:
24+
- dependency-name: "org.yaml:snakeyaml"
25+
# Version 2+ requires Spring Boot 3
26+
versions: ">=2.0.0"
2427
- dependency-name: "org.springframework.boot:*"
2528
# Version 3+ requires Vaadin 24
2629
versions: ">=3.0.0"
30+
- dependency-name: "com.vaadin:*"
31+
versions: ">=24.0.0"

.github/workflows/release.yml

Lines changed: 3 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Release
22

33
on:
44
push:
5-
branches: [ main ]
5+
branches: [ master ]
66

77
env:
88
PRIMARY_MAVEN_MODULE: ${{ github.event.repository.name }}
@@ -92,7 +92,7 @@ jobs:
9292
with:
9393
tag_name: v${{ steps.version.outputs.release }}
9494
release_name: v${{ steps.version.outputs.release }}
95-
commitish: main
95+
commitish: master
9696
body: |
9797
## [Changelog](https://github.com/xdev-software/${{ env.PRIMARY_MAVEN_MODULE }}/blob/develop/CHANGELOG.md#${{ steps.version.outputs.releasenumber }})
9898
See [Changelog#v${{ steps.version.outputs.release }}](https://github.com/xdev-software/${{ env.PRIMARY_MAVEN_MODULE }}/blob/develop/CHANGELOG.md#${{ steps.version.outputs.releasenumber }}) for more information.
@@ -137,49 +137,6 @@ jobs:
137137
MAVEN_CENTRAL_TOKEN: ${{ secrets.MAVEN_CENTRAL_TOKEN }}
138138
MAVEN_GPG_PASSPHRASE: ${{ secrets.MAVEN_GPG_PASSPHRASE }}
139139
working-directory: ${{ env.PRIMARY_MAVEN_MODULE }}
140-
141-
build_directory: # Build a ZIP that can be uploaded to Vaadin Directory
142-
runs-on: ubuntu-latest
143-
needs: [prepare_release]
144-
steps:
145-
- uses: actions/checkout@v3
146-
147-
- name: Init Git and pull
148-
run: |
149-
git config --global user.email "[email protected]"
150-
git config --global user.name "GitHub Actions"
151-
git pull
152-
153-
- name: Set up JDK
154-
uses: actions/setup-java@v3
155-
with:
156-
java-version: '11'
157-
distribution: 'temurin'
158-
159-
- name: Build for Vaadin Directory
160-
run: mvn -B install -Pdirectory
161-
working-directory: ${{ env.PRIMARY_MAVEN_MODULE }}
162-
163-
- name: Upload asset
164-
uses: actions/upload-artifact@v3
165-
with:
166-
name: vaadin-directory-files
167-
path: ${{ env.PRIMARY_MAVEN_MODULE }}/target/${{ env.PRIMARY_MAVEN_MODULE }}-*.zip
168-
if-no-files-found: error
169-
170-
- name: Get version
171-
id: version
172-
run: |
173-
echo "release=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)" >> $GITHUB_OUTPUT
174-
working-directory: ${{ env.PRIMARY_MAVEN_MODULE }}
175-
176-
- name: Upload Release Asset
177-
uses: shogo82148/actions-upload-release-asset@v1
178-
with:
179-
upload_url: ${{ needs.prepare_release.outputs.upload_url }}
180-
asset_path: ${{ env.PRIMARY_MAVEN_MODULE }}/target/${{ env.PRIMARY_MAVEN_MODULE }}-${{ steps.version.outputs.release }}.zip
181-
asset_name: ${{ env.PRIMARY_MAVEN_MODULE }}-${{ steps.version.outputs.release }}.zip
182-
asset_content_type: application/zip
183140

184141
publish-pages:
185142
name: Publish dependencies and licenses to github pages
@@ -238,7 +195,7 @@ jobs:
238195

239196
after_release:
240197
runs-on: ubuntu-latest
241-
needs: [publish_central, build_directory]
198+
needs: [publish_central]
242199
steps:
243200
- uses: actions/checkout@v3
244201

.idea/checkstyle-idea.xml

Lines changed: 16 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

CHANGELOG.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
1-
# 1.0.0
2-
Initial release
1+
## 1.0.1
2+
* Updated dependencies
3+
4+
## 1.0.0
5+
Initial release

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,4 +57,4 @@ If the ``develop`` is ready for release, create a pull request to the ``master``
5757

5858
When the release is finished do the following:
5959
* Merge the auto-generated PR (with the incremented version number) back into the ``develop``
60-
* Upload the generated release asset zip into the [Vaadin Directory](https://vaadin.com/directory) and update the component there
60+
* Ensure that [Vaadin Directory](https://vaadin.com/directory) syncs the update and maybe update the component / version there

README.md

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
[![Published on Vaadin Directory](https://img.shields.io/badge/Vaadin%20Directory-published-00b4f0.svg)](https://vaadin.com/directory/component/vaadin-editable-label)
1+
[![Published on Vaadin Directory](https://img.shields.io/badge/Vaadin%20Directory-published-00b4f0.svg)](https://vaadin.com/directory/component/editable-labels-for-vaadin)
22
[![Latest version](https://img.shields.io/maven-central/v/com.xdev-software/vaadin-editable-label)](https://mvnrepository.com/artifact/com.xdev-software/vaadin-editable-label)
33
[![Build](https://img.shields.io/github/actions/workflow/status/xdev-software/vaadin-editable-label/checkBuild.yml?branch=develop)](https://github.com/xdev-software/vaadin-editable-label/actions/workflows/checkBuild.yml?query=branch%3Adevelop)
44
[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=xdev-software_vaadin-editable-label&metric=alert_status)](https://sonarcloud.io/dashboard?id=xdev-software_vaadin-editable-label)
@@ -10,11 +10,29 @@ A Vaadin Flow implementation for editable labels
1010

1111
![demo](assets/demo.png)
1212

13+
This component provides a couple of elements that are displayed as simple read-only components, but can be edited with a
14+
simple click.
15+
Following components are available:
16+
17+
* [EditableLabelTextField](./vaadin-editable-label/src/main/java/software/xdev/vaadin/editable_label/predefined/EditableLabelTextField.java)
18+
* [EditableLabelTextArea](./vaadin-editable-label/src/main/java/software/xdev/vaadin/editable_label/predefined/EditableLabelTextArea.java)
19+
* [EditableLabelComboBox](./vaadin-editable-label/src/main/java/software/xdev/vaadin/editable_label/predefined/EditableLabelComboBox.java)
20+
* [EditableLabelDatePicker](./vaadin-editable-label/src/main/java/software/xdev/vaadin/editable_label/predefined/EditableLabelDatePicker.java)
21+
* [EditableLabelNumberField](./vaadin-editable-label/src/main/java/software/xdev/vaadin/editable_label/predefined/EditableLabelNumberField.java)
22+
* [EditableLabelBigDecimalField](./vaadin-editable-label/src/main/java/software/xdev/vaadin/editable_label/predefined/EditableLabelBigDecimalField.java)
23+
24+
It's also possible to create a custom element:
25+
26+
```java
27+
final EditableLabel<EmailField, String> emailLabel = new EditableLabel<>(new EmailField()).withValue(defaultValue);
28+
```
29+
1330
## Installation
1431

1532
[Installation guide for the latest release](https://github.com/xdev-software/vaadin-editable-label/releases/latest#Installation)
1633

1734
## Run the Demo
35+
1836
* Checkout the repo
1937
* Run ``mvn install && mvn -f vaadin-editable-label-demo spring-boot:run``
2038
* Open http://localhost:8080

vaadin-editable-label-demo/pom.xml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@
3535
<mainClass>software.xdev.vaadin.Application</mainClass>
3636

3737
<!-- Dependency-Versions -->
38-
<vaadin.version>23.3.6</vaadin.version>
38+
<vaadin.version>23.3.7</vaadin.version>
3939

40-
<org.springframework.boot.version>2.7.8</org.springframework.boot.version>
40+
<org.springframework.boot.version>2.7.9</org.springframework.boot.version>
4141
</properties>
4242

4343
<dependencyManagement>
@@ -80,7 +80,12 @@
8080
<groupId>com.vaadin</groupId>
8181
<artifactId>vaadin-spring-boot-starter</artifactId>
8282
</dependency>
83-
83+
<!-- Temporarily excluded by Vaadin due to "security vulnerability" -->
84+
<dependency>
85+
<groupId>org.yaml</groupId>
86+
<artifactId>snakeyaml</artifactId>
87+
<version>1.33</version>
88+
</dependency>
8489
<dependency>
8590
<groupId>org.springframework.boot</groupId>
8691
<artifactId>spring-boot-devtools</artifactId>
@@ -117,7 +122,7 @@
117122
<plugin>
118123
<groupId>org.apache.maven.plugins</groupId>
119124
<artifactId>maven-compiler-plugin</artifactId>
120-
<version>3.10.1</version>
125+
<version>3.11.0</version>
121126
<configuration>
122127
<release>${maven.compiler.release}</release>
123128
<compilerArgs>
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
vaadin:
2+
whitelisted-packages: software/xdev,com/vaadin/flow
3+
4+
spring:
5+
devtools:
6+
restart:
7+
poll-interval: 2s
8+
quiet-period: 1s

vaadin-editable-label/assembly/MANIFEST.MF

Lines changed: 0 additions & 6 deletions
This file was deleted.

vaadin-editable-label/assembly/assembly.xml

Lines changed: 0 additions & 42 deletions
This file was deleted.

0 commit comments

Comments
 (0)