Skip to content

Commit 6f15362

Browse files
committed
Fix some PMD warnings
1 parent 53a7f21 commit 6f15362

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

vaadin-grid-filter/src/main/java/software/xdev/vaadin/FilterComponent.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -432,15 +432,15 @@ private void deactivateDeleteButtonFromChipComponents(
432432
/**
433433
* Format chip badge input text for LocalDate and LocalDateTime.
434434
*/
435-
// TODO: Catching the parse errors is fixed in Branch FLX-353
436435
private void formatLocalDateChipBadgeText(final ChipBadge<FilterCondition<T, ?>> chipBadge)
437436
{
438437
if(this.dateRangePickerQuery.isVisible()
439438
&& chipBadge.getItem().getSelectedCondition().getDescription().equals(IS_BETWEEN_COMPARATOR_DESCRIPTION))
440439
{
441440
chipBadge.setItemLabelGenerator((ItemLabelGenerator<FilterCondition<T, ?>>)tFilterCondition ->
442441
{
443-
LocalDate startDate, endDate;
442+
LocalDate startDate;
443+
LocalDate endDate;
444444

445445
try
446446
{
@@ -606,12 +606,10 @@ private void setQueryValue(final String searchQuery)
606606
}
607607
else if(this.dateSearchQuery.isVisible())
608608
{
609-
// FIXME: Catch parse errors
610609
this.dateSearchQuery.setValue(LocalDate.parse(searchQuery));
611610
}
612611
else if(this.dateTimeSearchQuery.isVisible())
613612
{
614-
// FIXME: Catch parse errors
615613
this.dateTimeSearchQuery.setValue(LocalDateTime.parse(searchQuery));
616614
}
617615
else if(this.selSearchQuery.isVisible())

0 commit comments

Comments
 (0)