Skip to content

Commit ec519f2

Browse files
committed
Updated docs
1 parent daa8e0d commit ec519f2

File tree

7 files changed

+19
-8
lines changed

7 files changed

+19
-8
lines changed

CHANGELOG.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
⚠️<i>This release contains breaking changes</i>
33

44
* The complete API got reworked and now has the [same structure as Leaflet](https://leafletjs.com/reference.html).
5-
* Implemented a lot of new Leaflet APIs - Currently around 90% of the Leaflet API are implemented. These include the most useful bits:
5+
* Added lots of new Leaflet APIs - currently around 90% of the Leaflet API are implemented. These include the most useful bits:
66
* GeoLocation
77
* A lot of new methods for Map
88
* Tooltips & Popups
@@ -11,9 +11,9 @@
1111
* Controls for Scale, Layers, ...
1212
* and much more
1313
* Abstracted the elements similar to how this is done inside Leaflet itself so that they can easily be extended
14-
* The API only supports sending instructions to the client. Retrieving client side data is not supported as it can't be data integrity guaranteed (data on client can be modified).
14+
* The API only supports sending instructions to the client. Retrieving client side data is not supported as data integrity can't be guaranteed (client-side data can be modified by users).
1515
* Event listeners can still be registered but this needs to be done manually. A example is available in the demo.
16-
* All Leaflet elements are now tracked on the client and on the server and can therefore be modified/reused.
16+
* All Leaflet elements are now tracked on the client and on the server and can therefore be modified/reused (using ``LComponentManagementRegistry``).
1717
* Before it was only possible to create an element and then send it to the client
1818
* However keep in mind when creating a lot of elements that you may have to free up memory on the client (manually)
1919
* Integrated default Leaflet resources

vaadin-maps-leaflet-flow-demo/src/main/java/software/xdev/vaadin/maps/leaflet/flow/demo/LeafletView.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -368,6 +368,9 @@ private void addComplexPolygonDemo()
368368
));
369369
}
370370

371+
/**
372+
* Used for testing if memory on the client side is freed up correctly when handling a lot of components
373+
*/
371374
// S5413 - Yes it's used correctly
372375
// S2245 - This is a reproducible demo
373376
// S1215 - This is a memory test and we don't rely on random GC collects
@@ -377,8 +380,8 @@ private void addMemoryTestDemo()
377380
final AtomicBoolean abort = new AtomicBoolean(false);
378381

379382
this.hlButtons.add(this.createToggleButton(
380-
"Start memory test",
381-
"Stop memory test",
383+
"Start browser memory test",
384+
"Stop browser memory test",
382385
() -> {
383386
this.map.setView(new LLatLng(this.reg, 0, 0), 12);
384387

vaadin-maps-leaflet-flow/src/main/java/software/xdev/vaadin/maps/leaflet/basictypes/LDivIcon.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020

2121
/**
22-
* <a href="https://leafletjs.com/reference.html#divicon">Documentation</a>
22+
* @see <a href="https://leafletjs.com/reference.html#divicon">Leaflet docs</a>
2323
*/
2424
public class LDivIcon extends LIcon
2525
{

vaadin-maps-leaflet-flow/src/main/java/software/xdev/vaadin/maps/leaflet/basictypes/LDivIconOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
package software.xdev.vaadin.maps.leaflet.basictypes;
1717

1818
/**
19-
* <a href="https://leafletjs.com/reference.html#divicon">Documentation</a>
19+
* @see <a href="https://leafletjs.com/reference.html#divicon">Leaflet docs</a>
2020
*/
2121
public class LDivIconOptions extends LAbstractIconOptions<LDivIconOptions>
2222
{

vaadin-maps-leaflet-flow/src/main/java/software/xdev/vaadin/maps/leaflet/basictypes/LIcon.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919
import software.xdev.vaadin.maps.leaflet.registry.LComponentManagementRegistry;
2020

2121

22+
/**
23+
* @see <a href="https://leafletjs.com/reference.html#icon">Leaflet docs</a>
24+
*/
2225
public class LIcon extends LBaseComponent<LIcon>
2326
{
2427
protected LIcon(

vaadin-maps-leaflet-flow/src/main/java/software/xdev/vaadin/maps/leaflet/basictypes/LIconOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
package software.xdev.vaadin.maps.leaflet.basictypes;
1717

1818
/**
19-
* <a href="https://leafletjs.com/reference.html#icon">Documentation</a>
19+
* @see <a href="https://leafletjs.com/reference.html#icon">Leaflet docs</a>
2020
*/
2121
public class LIconOptions extends LAbstractIconOptions<LIconOptions>
2222
{

vaadin-maps-leaflet-flow/src/main/java/software/xdev/vaadin/maps/leaflet/registry/LComponentManagementRegistry.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@
2323
import software.xdev.vaadin.maps.leaflet.base.LComponentOptions;
2424

2525

26+
/**
27+
* Used for tracking components (on the client).
28+
* <p/>
29+
* Links components from server (Java) and client (JS) so that they can be reused and/or manipulated after creation.
30+
*/
2631
public interface LComponentManagementRegistry
2732
{
2833
// region Write Options

0 commit comments

Comments
 (0)