From 105d452ff8d65ced9a981a00dfb6ad8332dfcfd2 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Fri, 13 Dec 2024 02:41:05 +0000 Subject: [PATCH 01/58] Update dependency com.puppycrawl.tools:checkstyle to v10.21.0 --- pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index eede261..eac619a 100644 --- a/pom.xml +++ b/pom.xml @@ -45,7 +45,7 @@ com.puppycrawl.tools checkstyle - 10.20.2 + 10.21.0 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index abbbb53..75f0b85 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -247,7 +247,7 @@ com.puppycrawl.tools checkstyle - 10.20.2 + 10.21.0 From 73b158a40c742e4ff95de2770f2c5f298c96324c Mon Sep 17 00:00:00 2001 From: AB Date: Mon, 16 Dec 2024 09:06:51 +0100 Subject: [PATCH 02/58] Update to latest checkstyle version --- .idea/checkstyle-idea.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.idea/checkstyle-idea.xml b/.idea/checkstyle-idea.xml index 5f35e01..b52c3e2 100644 --- a/.idea/checkstyle-idea.xml +++ b/.idea/checkstyle-idea.xml @@ -1,7 +1,7 @@ - 10.20.1 + 10.21.0 JavaOnlyWithTests true true From 4a380b2069ab25bb8e80cf35643f48b5786b701d Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Sat, 28 Dec 2024 02:30:20 +0000 Subject: [PATCH 03/58] Update net.sourceforge.pmd to v7.9.0 --- pom.xml | 4 ++-- template-placeholder/pom.xml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pom.xml b/pom.xml index eac619a..68b0adb 100644 --- a/pom.xml +++ b/pom.xml @@ -82,12 +82,12 @@ net.sourceforge.pmd pmd-core - 7.8.0 + 7.9.0 net.sourceforge.pmd pmd-java - 7.8.0 + 7.9.0 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 75f0b85..bf53675 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -284,12 +284,12 @@ net.sourceforge.pmd pmd-core - 7.8.0 + 7.9.0 net.sourceforge.pmd pmd-java - 7.8.0 + 7.9.0 From 5c0db241e0a8f72ea39ccbb3fc72bb588b6363e6 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Sun, 29 Dec 2024 02:39:21 +0000 Subject: [PATCH 04/58] Update dependency com.puppycrawl.tools:checkstyle to v10.21.1 --- pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index eac619a..bff5bed 100644 --- a/pom.xml +++ b/pom.xml @@ -45,7 +45,7 @@ com.puppycrawl.tools checkstyle - 10.21.0 + 10.21.1 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 75f0b85..850be81 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -247,7 +247,7 @@ com.puppycrawl.tools checkstyle - 10.21.0 + 10.21.1 From 9201f18d41b208e2feb6249d3d2a5fae8ca9c705 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Wed, 15 Jan 2025 02:30:08 +0000 Subject: [PATCH 05/58] Update vaadin.version to v24.6.2 --- template-placeholder-demo/pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/template-placeholder-demo/pom.xml b/template-placeholder-demo/pom.xml index dc0f4fa..a037780 100644 --- a/template-placeholder-demo/pom.xml +++ b/template-placeholder-demo/pom.xml @@ -29,7 +29,7 @@ software.xdev.vaadin.Application - 24.5.8 + 24.6.2 3.4.0 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index f88b8ff..2d90d7c 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -49,7 +49,7 @@ UTF-8 - 24.5.8 + 24.6.2 From c1635beae63b545bce9781ac37052c9605c2d8b0 Mon Sep 17 00:00:00 2001 From: AB Date: Tue, 21 Jan 2025 16:46:28 +0100 Subject: [PATCH 06/58] Support new GitHub issue types --- .github/ISSUE_TEMPLATE/bug_report.yml | 1 + .github/ISSUE_TEMPLATE/enhancement.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 68299d5..a61d834 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -1,6 +1,7 @@ name: 🐞 Bug description: Create a bug report for something that is broken labels: [bug] +type: bug body: - type: markdown attributes: diff --git a/.github/ISSUE_TEMPLATE/enhancement.yml b/.github/ISSUE_TEMPLATE/enhancement.yml index 7523129..764cae1 100644 --- a/.github/ISSUE_TEMPLATE/enhancement.yml +++ b/.github/ISSUE_TEMPLATE/enhancement.yml @@ -1,6 +1,7 @@ name: ✨ Feature/Enhancement description: Suggest a new feature or enhancement labels: [enhancement] +type: feature body: - type: markdown attributes: From 90d8e94bd7770da46707ffba981d11639b4e2358 Mon Sep 17 00:00:00 2001 From: AB Date: Tue, 21 Jan 2025 17:01:28 +0100 Subject: [PATCH 07/58] Overwrite gh-pages by default --- .github/workflows/release.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 236c0f5..43767e8 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -169,6 +169,7 @@ jobs: with: github_token: ${{ secrets.GITHUB_TOKEN }} publish_dir: ./${{ env.PRIMARY_MAVEN_MODULE }}/target/site + force_orphan: true after-release: runs-on: ubuntu-latest From ba7860246731ab0e2905c47081e5078befd2804d Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Fri, 24 Jan 2025 02:30:33 +0000 Subject: [PATCH 08/58] Update org.springframework.boot.version to v3.4.2 --- template-placeholder-demo/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template-placeholder-demo/pom.xml b/template-placeholder-demo/pom.xml index dc0f4fa..b392294 100644 --- a/template-placeholder-demo/pom.xml +++ b/template-placeholder-demo/pom.xml @@ -31,7 +31,7 @@ 24.5.8 - 3.4.0 + 3.4.2 From 50bc78e863a9f5a0d95293381d6683b92014a2d0 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Mon, 27 Jan 2025 02:32:12 +0000 Subject: [PATCH 09/58] Update dependency com.puppycrawl.tools:checkstyle to v10.21.2 --- pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 26d6779..54d907b 100644 --- a/pom.xml +++ b/pom.xml @@ -45,7 +45,7 @@ com.puppycrawl.tools checkstyle - 10.21.1 + 10.21.2 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index df945cf..72b9e32 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -247,7 +247,7 @@ com.puppycrawl.tools checkstyle - 10.21.1 + 10.21.2 From d109ab3c4f3340d813ab5eb82411d458c790a339 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Sat, 1 Feb 2025 04:13:58 +0000 Subject: [PATCH 10/58] Update dependency net.sourceforge.pmd:pmd-core to v7.10.0 [SECURITY] --- pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 54d907b..9d7a55b 100644 --- a/pom.xml +++ b/pom.xml @@ -82,7 +82,7 @@ net.sourceforge.pmd pmd-core - 7.9.0 + 7.10.0 net.sourceforge.pmd diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 72b9e32..030c1c0 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -284,7 +284,7 @@ net.sourceforge.pmd pmd-core - 7.9.0 + 7.10.0 net.sourceforge.pmd From 459817dc44daa51a3ae4ae2d49de0158addc485c Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Sat, 1 Feb 2025 04:14:00 +0000 Subject: [PATCH 11/58] Update dependency net.sourceforge.pmd:pmd-java to v7.10.0 --- pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 54d907b..049a943 100644 --- a/pom.xml +++ b/pom.xml @@ -87,7 +87,7 @@ net.sourceforge.pmd pmd-java - 7.9.0 + 7.10.0 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 72b9e32..eab8211 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -289,7 +289,7 @@ net.sourceforge.pmd pmd-java - 7.9.0 + 7.10.0 From 97714503bc1160bdbf8a0e3ce7cdfcdb9c53ab35 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Tue, 4 Feb 2025 04:11:50 +0000 Subject: [PATCH 12/58] Update vaadin.version to v24.6.4 --- template-placeholder-demo/pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/template-placeholder-demo/pom.xml b/template-placeholder-demo/pom.xml index c9e7762..780ab96 100644 --- a/template-placeholder-demo/pom.xml +++ b/template-placeholder-demo/pom.xml @@ -29,7 +29,7 @@ software.xdev.vaadin.Application - 24.6.2 + 24.6.4 3.4.2 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index ff6e482..6710f17 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -49,7 +49,7 @@ UTF-8 - 24.6.2 + 24.6.4 From 2748dfb95bc6ec02e8571a6b700d9fd2bf889adb Mon Sep 17 00:00:00 2001 From: AB Date: Wed, 12 Feb 2025 08:28:05 +0100 Subject: [PATCH 13/58] Add installation guide to Readme --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index a8a96c6..f9924bc 100644 --- a/README.md +++ b/README.md @@ -13,6 +13,9 @@ A Vaadin Template Repo ## Installation [Installation guide for the latest release](https://github.com/xdev-software/template-placeholder/releases/latest#Installation) +### Additional notes +* [Spring-Boot] You may have to include ``software/xdev`` inside [``vaadin.allowed-packages``](https://vaadin.com/docs/latest/integrations/spring/configuration#configure-the-scanning-of-packages) + ## Run the Demo * Checkout the repo * Run ``mvn install && mvn -f template-placeholder-demo spring-boot:run`` From 9572608a8d522cb78268b49893e7cdc9d6e88588 Mon Sep 17 00:00:00 2001 From: AB Date: Wed, 12 Feb 2025 08:29:27 +0100 Subject: [PATCH 14/58] Reword --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index f9924bc..f030b89 100644 --- a/README.md +++ b/README.md @@ -13,8 +13,8 @@ A Vaadin Template Repo ## Installation [Installation guide for the latest release](https://github.com/xdev-software/template-placeholder/releases/latest#Installation) -### Additional notes -* [Spring-Boot] You may have to include ``software/xdev`` inside [``vaadin.allowed-packages``](https://vaadin.com/docs/latest/integrations/spring/configuration#configure-the-scanning-of-packages) +### Spring-Boot +* You may have to include ``software/xdev`` inside [``vaadin.allowed-packages``](https://vaadin.com/docs/latest/integrations/spring/configuration#configure-the-scanning-of-packages) ## Run the Demo * Checkout the repo From 90e7a82798dd94460d54932afb534d9692ab4d3c Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Thu, 13 Feb 2025 04:11:41 +0000 Subject: [PATCH 15/58] Update vaadin.version to v24.6.5 --- template-placeholder-demo/pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/template-placeholder-demo/pom.xml b/template-placeholder-demo/pom.xml index 780ab96..2697d07 100644 --- a/template-placeholder-demo/pom.xml +++ b/template-placeholder-demo/pom.xml @@ -29,7 +29,7 @@ software.xdev.vaadin.Application - 24.6.4 + 24.6.5 3.4.2 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 6710f17..1f9b888 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -49,7 +49,7 @@ UTF-8 - 24.6.4 + 24.6.5 From 9ded134a2551e663234a870ff42321c9d367a59e Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Fri, 21 Feb 2025 04:12:57 +0000 Subject: [PATCH 16/58] Update org.springframework.boot.version to v3.4.3 --- template-placeholder-demo/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template-placeholder-demo/pom.xml b/template-placeholder-demo/pom.xml index 2697d07..a3bb3cf 100644 --- a/template-placeholder-demo/pom.xml +++ b/template-placeholder-demo/pom.xml @@ -31,7 +31,7 @@ 24.6.5 - 3.4.2 + 3.4.3 From ab7a50a8b518e7708b7a5875629b52bec295b136 Mon Sep 17 00:00:00 2001 From: AB Date: Fri, 21 Feb 2025 11:51:42 +0100 Subject: [PATCH 17/58] Prevent possible GDPR violation --- template-placeholder-demo/src/main/resources/application.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/template-placeholder-demo/src/main/resources/application.yml b/template-placeholder-demo/src/main/resources/application.yml index b336051..9ef9e9d 100644 --- a/template-placeholder-demo/src/main/resources/application.yml +++ b/template-placeholder-demo/src/main/resources/application.yml @@ -1,5 +1,8 @@ vaadin: allowed-packages: software/xdev,com/vaadin/flow + devmode: + usageStatistics: + enabled: false spring: devtools: From febb98273d1ba9454ba3c79ab87668b4740ac51c Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Sat, 22 Feb 2025 04:12:31 +0000 Subject: [PATCH 18/58] Update dependency org.apache.maven.plugins:maven-compiler-plugin to v3.14.0 --- template-placeholder-demo/pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/template-placeholder-demo/pom.xml b/template-placeholder-demo/pom.xml index 1af633c..3702222 100644 --- a/template-placeholder-demo/pom.xml +++ b/template-placeholder-demo/pom.xml @@ -44,7 +44,7 @@ org.apache.maven.plugins maven-compiler-plugin - 3.13.0 + 3.14.0 ${maven.compiler.release} diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 52d4073..0250042 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -132,7 +132,7 @@ org.apache.maven.plugins maven-compiler-plugin - 3.13.0 + 3.14.0 ${maven.compiler.release} From 0d53a9b152f4dc3d812f5c44e15ec26df45e98cc Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Mon, 24 Feb 2025 04:12:36 +0000 Subject: [PATCH 19/58] Update dependency com.puppycrawl.tools:checkstyle to v10.21.3 --- pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index c39fff2..353d78d 100644 --- a/pom.xml +++ b/pom.xml @@ -45,7 +45,7 @@ com.puppycrawl.tools checkstyle - 10.21.2 + 10.21.3 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 52d4073..db2a2bf 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -247,7 +247,7 @@ com.puppycrawl.tools checkstyle - 10.21.2 + 10.21.3 From 15a053a764be7a91a2ab1d026bff2ca640401215 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Wed, 26 Feb 2025 04:14:11 +0000 Subject: [PATCH 20/58] Update dependency org.codehaus.mojo:flatten-maven-plugin to v1.7.0 --- template-placeholder/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 52d4073..c6592b3 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -182,7 +182,7 @@ org.codehaus.mojo flatten-maven-plugin - 1.6.0 + 1.7.0 ossrh From eacac5add95c89cc33a8d571bae0bcbd5186c3a7 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Thu, 27 Feb 2025 04:13:15 +0000 Subject: [PATCH 21/58] Update dependency org.apache.maven.plugins:maven-project-info-reports-plugin to v3.9.0 --- template-placeholder/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 52d4073..0784d8d 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -95,7 +95,7 @@ org.apache.maven.plugins maven-project-info-reports-plugin - 3.8.0 + 3.9.0 From a3c85c196e6f18d0f4d71a026136a6336df753fb Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Sat, 1 Mar 2025 04:13:31 +0000 Subject: [PATCH 22/58] Update net.sourceforge.pmd to v7.11.0 --- pom.xml | 4 ++-- template-placeholder/pom.xml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pom.xml b/pom.xml index c39fff2..aa2ba15 100644 --- a/pom.xml +++ b/pom.xml @@ -82,12 +82,12 @@ net.sourceforge.pmd pmd-core - 7.10.0 + 7.11.0 net.sourceforge.pmd pmd-java - 7.10.0 + 7.11.0 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 52d4073..44733c5 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -284,12 +284,12 @@ net.sourceforge.pmd pmd-core - 7.10.0 + 7.11.0 net.sourceforge.pmd pmd-java - 7.10.0 + 7.11.0 From 6ca61bb480271068b8c83073fcd862a79049ac47 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Tue, 4 Mar 2025 04:12:44 +0000 Subject: [PATCH 23/58] Update vaadin.version to v24.6.6 --- template-placeholder-demo/pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/template-placeholder-demo/pom.xml b/template-placeholder-demo/pom.xml index 5087faf..9c172e8 100644 --- a/template-placeholder-demo/pom.xml +++ b/template-placeholder-demo/pom.xml @@ -29,7 +29,7 @@ software.xdev.vaadin.Application - 24.6.5 + 24.6.6 3.4.3 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 02b4f2d..7ab2cf1 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -49,7 +49,7 @@ UTF-8 - 24.6.5 + 24.6.6 From 378beb5450ba1f6ab873b002e6c046e99cd22783 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Wed, 5 Mar 2025 04:13:28 +0000 Subject: [PATCH 24/58] Update dependency com.puppycrawl.tools:checkstyle to v10.21.4 --- pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index e8d4bbd..cc8c281 100644 --- a/pom.xml +++ b/pom.xml @@ -45,7 +45,7 @@ com.puppycrawl.tools checkstyle - 10.21.3 + 10.21.4 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 11d38bd..8bac89b 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -247,7 +247,7 @@ com.puppycrawl.tools checkstyle - 10.21.3 + 10.21.4 From 0a57f91cbf92f2d695cc404000efe92f779372d6 Mon Sep 17 00:00:00 2001 From: AB Date: Thu, 13 Mar 2025 08:34:52 +0100 Subject: [PATCH 25/58] Use correct directory for PMD --- .github/workflows/check-build.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/check-build.yml b/.github/workflows/check-build.yml index 0818116..3186173 100644 --- a/.github/workflows/check-build.yml +++ b/.github/workflows/check-build.yml @@ -127,7 +127,4 @@ jobs: name: pmd-report if-no-files-found: ignore path: | - target/site/*.html - target/site/css/** - target/site/images/logos/maven-feather.png - target/site/images/external.png + target/reports/*.html From 188e420e46e5cdcdc418d3650617b36db663af91 Mon Sep 17 00:00:00 2001 From: AB Date: Thu, 13 Mar 2025 08:35:09 +0100 Subject: [PATCH 26/58] Use correct directory for PMD --- .github/workflows/check-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check-build.yml b/.github/workflows/check-build.yml index 3186173..01edc3a 100644 --- a/.github/workflows/check-build.yml +++ b/.github/workflows/check-build.yml @@ -127,4 +127,4 @@ jobs: name: pmd-report if-no-files-found: ignore path: | - target/reports/*.html + target/reports/** From 7d973058addb9bfd1c22f00b2b4a34e2405f267c Mon Sep 17 00:00:00 2001 From: AB Date: Fri, 14 Mar 2025 14:21:14 +0100 Subject: [PATCH 27/58] Naming --- .github/workflows/release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 43767e8..d8754d6 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -121,7 +121,7 @@ jobs: git config --global user.name "GitHub Actions" git pull - - name: Set up JDK Apache Maven Central + - name: Set up JDK OSSRH uses: actions/setup-java@v4 with: # running setup-java again overwrites the settings.xml java-version: '17' @@ -132,7 +132,7 @@ jobs: gpg-passphrase: MAVEN_GPG_PASSPHRASE gpg-private-key: ${{ secrets.MAVEN_GPG_PRIVATE_KEY }} - - name: Publish to Apache Maven Central + - name: Publish to OSSRH run: ../mvnw -B deploy -Possrh -DskipTests env: MAVEN_CENTRAL_USERNAME: ${{ secrets.S01_OSS_SONATYPE_MAVEN_USERNAME }} From 53829e02afaea2f1598094351417054c2a52bb91 Mon Sep 17 00:00:00 2001 From: AB Date: Fri, 14 Mar 2025 14:23:36 +0100 Subject: [PATCH 28/58] Simplify module extraction --- .github/workflows/release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d8754d6..d014f7b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -64,7 +64,7 @@ jobs: run: | mvnwPath=$(readlink -f ./mvnw) modules=("") # root - modules+=($(grep -ozP '(?<=module>)[^<]+' 'pom.xml' | tr -d '\0')) + modules+=($(grep -oP '(?<=)[^<]+' 'pom.xml')) for i in "${modules[@]}" do echo "Processing $i/pom.xml" @@ -188,7 +188,7 @@ jobs: run: | mvnwPath=$(readlink -f ./mvnw) modules=("") # root - modules+=($(grep -ozP '(?<=module>)[^<]+' 'pom.xml' | tr -d '\0')) + modules+=($(grep -oP '(?<=)[^<]+' 'pom.xml')) for i in "${modules[@]}" do echo "Processing $i/pom.xml" From cf59a66878363d93c2e34dd6a46d4228f1e2eaeb Mon Sep 17 00:00:00 2001 From: AB Date: Fri, 14 Mar 2025 14:29:58 +0100 Subject: [PATCH 29/58] Speed up check code --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d014f7b..655f788 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -26,7 +26,7 @@ jobs: cache: 'maven' - name: Build with Maven - run: ./mvnw -B clean package + run: ./mvnw -B clean package -T2C - name: Check for uncommited changes run: | From bb022ad0cbbcbba74383f5c09550f21f1f547f8a Mon Sep 17 00:00:00 2001 From: AB Date: Mon, 17 Mar 2025 10:14:58 +0100 Subject: [PATCH 30/58] Use SPDX identifier for license name https://maven.apache.org/pom.html#Licenses > Using an SPDX identifier as the license name is recommended Meanwhile https://maven.apache.org/xsd/maven-4.0.0.xsd > The full legal name of the license Can you maybe make up your mind? --- pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index cc8c281..f41e09d 100644 --- a/pom.xml +++ b/pom.xml @@ -26,7 +26,7 @@ - Apache License, Version 2.0 + Apache-2.0 https://www.apache.org/licenses/LICENSE-2.0.txt repo diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 8bac89b..5544d7d 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -35,7 +35,7 @@ - Apache License, Version 2.0 + Apache-2.0 https://www.apache.org/licenses/LICENSE-2.0.txt repo From da9442e969b44f01462120fd1557b37b25baa271 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Thu, 20 Mar 2025 16:03:11 +0000 Subject: [PATCH 31/58] Update dependency com.mycila:license-maven-plugin to v5 --- template-placeholder/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 5544d7d..db20004 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -103,7 +103,7 @@ com.mycila license-maven-plugin - 4.6 + 5.0.0 ${project.organization.url} From 2e7b1b6655563f8f81bdf02ce2c602c3a9be3946 Mon Sep 17 00:00:00 2001 From: AB Date: Fri, 21 Mar 2025 12:17:08 +0100 Subject: [PATCH 32/58] sonarcloud was renamed to sonarqubecloud --- .github/workflows/update-from-template.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/update-from-template.yml b/.github/workflows/update-from-template.yml index 3ad8e88..d9dbba5 100644 --- a/.github/workflows/update-from-template.yml +++ b/.github/workflows/update-from-template.yml @@ -200,7 +200,7 @@ jobs: GH_TOKEN: ${{ secrets.UPDATE_FROM_TEMPLATE_PAT }} run: | not_failed_conclusion="skipped|neutral|success" - not_relevant_app_slug="dependabot|github-pages|sonarcloud" + not_relevant_app_slug="dependabot|github-pages|sonarqubecloud" echo "Waiting for checks to start..." sleep 40s From 888b4ce0a3b28dcb11fdfec03d8912520d641c03 Mon Sep 17 00:00:00 2001 From: AB Date: Fri, 21 Mar 2025 12:39:41 +0100 Subject: [PATCH 33/58] Fix branch deletion being not detected --- .github/workflows/update-from-template.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/update-from-template.yml b/.github/workflows/update-from-template.yml index d9dbba5..24af3f3 100644 --- a/.github/workflows/update-from-template.yml +++ b/.github/workflows/update-from-template.yml @@ -210,7 +210,7 @@ jobs: echo "Checking if update-branch-merged exists" git fetch - if [[ $(git rev-parse origin/${{ env.UPDATE_BRANCH_MERGED }}) ]]; then + if [[ $(git ls-remote --heads origin refs/heads/${{ env.UPDATE_BRANCH_MERGED }}) ]]; then echo "Branch still exists; Continuing..." else echo "Branch origin/${{ env.UPDATE_BRANCH_MERGED }} is missing" From 85b810ddab1dff0023d64a83a5bcf2644c058d74 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Sat, 22 Mar 2025 04:13:20 +0000 Subject: [PATCH 34/58] Update org.springframework.boot.version to v3.4.4 --- template-placeholder-demo/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template-placeholder-demo/pom.xml b/template-placeholder-demo/pom.xml index 9c172e8..943f2e0 100644 --- a/template-placeholder-demo/pom.xml +++ b/template-placeholder-demo/pom.xml @@ -31,7 +31,7 @@ 24.6.6 - 3.4.3 + 3.4.4 From 9d1317c909f2ba55f86e79a30106aa3763151db2 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Sat, 22 Mar 2025 04:13:22 +0000 Subject: [PATCH 35/58] Update vaadin.version to v24.7.0 --- template-placeholder-demo/pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/template-placeholder-demo/pom.xml b/template-placeholder-demo/pom.xml index 9c172e8..87f400d 100644 --- a/template-placeholder-demo/pom.xml +++ b/template-placeholder-demo/pom.xml @@ -29,7 +29,7 @@ software.xdev.vaadin.Application - 24.6.6 + 24.7.0 3.4.3 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 6ac7209..c136635 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -49,7 +49,7 @@ UTF-8 - 24.6.6 + 24.7.0 From c021044d61db78e1988715ecd6abde9b88f70c67 Mon Sep 17 00:00:00 2001 From: AB Date: Wed, 26 Mar 2025 15:49:45 +0100 Subject: [PATCH 36/58] Pin unofficial actions versions https://github.com/xdev-software/base-template/issues/1 --- .github/workflows/broken-links.yml | 4 ++-- .github/workflows/sync-labels.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/broken-links.yml b/.github/workflows/broken-links.yml index 48265e8..2b1188e 100644 --- a/.github/workflows/broken-links.yml +++ b/.github/workflows/broken-links.yml @@ -18,7 +18,7 @@ jobs: - name: Link Checker id: lychee - uses: lycheeverse/lychee-action@v2 + uses: lycheeverse/lychee-action@f613c4a64e50d792e0b31ec34bbcbba12263c6a6 # v2 with: fail: false # Don't fail on broken links, create an issue instead @@ -37,7 +37,7 @@ jobs: - name: Create Issue From File if: env.lychee_exit_code != 0 - uses: peter-evans/create-issue-from-file@v5 + uses: peter-evans/create-issue-from-file@e8ef132d6df98ed982188e460ebb3b5d4ef3a9cd # v5 with: issue-number: ${{ steps.find-issue.outputs.number }} title: Link Checker Report diff --git a/.github/workflows/sync-labels.yml b/.github/workflows/sync-labels.yml index ff880f0..0e2beb5 100644 --- a/.github/workflows/sync-labels.yml +++ b/.github/workflows/sync-labels.yml @@ -19,6 +19,6 @@ jobs: with: sparse-checkout: .github/labels.yml - - uses: EndBug/label-sync@v2 + - uses: EndBug/label-sync@52074158190acb45f3077f9099fea818aa43f97a # v2 with: config-file: .github/labels.yml From 581b7fb0faa1eb3b591501b251cb733b4d12c6c0 Mon Sep 17 00:00:00 2001 From: AB Date: Wed, 26 Mar 2025 16:22:13 +0100 Subject: [PATCH 37/58] Pin unofficial actions versions https://github.com/xdev-software/base-template/issues/1 --- .github/workflows/release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 655f788..8bd0f3c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -89,7 +89,7 @@ jobs: - name: Create Release id: create_release - uses: shogo82148/actions-create-release@v1 + uses: shogo82148/actions-create-release@e5f206451d4ace2da9916d01f1aef279997f8659 # v1 with: tag_name: v${{ steps.version.outputs.release }} release_name: v${{ steps.version.outputs.release }} @@ -165,7 +165,7 @@ jobs: working-directory: ${{ env.PRIMARY_MAVEN_MODULE }} - name: Deploy to Github pages - uses: peaceiris/actions-gh-pages@v4 + uses: peaceiris/actions-gh-pages@4f9cc6602d3f66b9c108549d475ec49e8ef4d45e # v4 with: github_token: ${{ secrets.GITHUB_TOKEN }} publish_dir: ./${{ env.PRIMARY_MAVEN_MODULE }}/target/site From 092c81c3d43e1829e94cdbd534d1c7d91330eecb Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Fri, 28 Mar 2025 04:12:26 +0000 Subject: [PATCH 38/58] Update vaadin.version to v24.7.1 --- template-placeholder-demo/pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/template-placeholder-demo/pom.xml b/template-placeholder-demo/pom.xml index ec69355..17c5c7e 100644 --- a/template-placeholder-demo/pom.xml +++ b/template-placeholder-demo/pom.xml @@ -29,7 +29,7 @@ software.xdev.vaadin.Application - 24.7.0 + 24.7.1 3.4.4 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index c136635..22accc4 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -49,7 +49,7 @@ UTF-8 - 24.7.0 + 24.7.1 From 5ced1cc41f894e26af310f1722dcd94e68af5b9e Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Sat, 29 Mar 2025 04:13:09 +0000 Subject: [PATCH 39/58] Update net.sourceforge.pmd to v7.12.0 --- pom.xml | 4 ++-- template-placeholder/pom.xml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pom.xml b/pom.xml index f41e09d..07c70ba 100644 --- a/pom.xml +++ b/pom.xml @@ -82,12 +82,12 @@ net.sourceforge.pmd pmd-core - 7.11.0 + 7.12.0 net.sourceforge.pmd pmd-java - 7.11.0 + 7.12.0 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index db20004..47dd4d8 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -284,12 +284,12 @@ net.sourceforge.pmd pmd-core - 7.11.0 + 7.12.0 net.sourceforge.pmd pmd-java - 7.11.0 + 7.12.0 From 49db248d25fd4a3106ddaaf092c86a205d357c4c Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Mon, 31 Mar 2025 04:15:29 +0000 Subject: [PATCH 40/58] Update dependency com.puppycrawl.tools:checkstyle to v10.22.0 --- pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index f41e09d..eb66486 100644 --- a/pom.xml +++ b/pom.xml @@ -45,7 +45,7 @@ com.puppycrawl.tools checkstyle - 10.21.4 + 10.22.0 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index db20004..014b608 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -247,7 +247,7 @@ com.puppycrawl.tools checkstyle - 10.21.4 + 10.22.0 From 4eef9ec75c98fcddb0845dfe527b5ae6615db1c3 Mon Sep 17 00:00:00 2001 From: AB Date: Mon, 31 Mar 2025 08:37:19 +0200 Subject: [PATCH 41/58] Improve Code Analysis See https://github.com/xdev-software/java-template/issues/13 --- .config/checkstyle/checkstyle.xml | 13 +++++++++- .config/pmd/ruleset.xml | 43 ++++++++++++++++++++++++++++--- 2 files changed, 51 insertions(+), 5 deletions(-) diff --git a/.config/checkstyle/checkstyle.xml b/.config/checkstyle/checkstyle.xml index a0d7f17..43b5290 100644 --- a/.config/checkstyle/checkstyle.xml +++ b/.config/checkstyle/checkstyle.xml @@ -52,6 +52,7 @@ + @@ -68,6 +69,11 @@ + + + + + @@ -93,7 +99,6 @@ - @@ -122,7 +127,13 @@ + + + + + + diff --git a/.config/pmd/ruleset.xml b/.config/pmd/ruleset.xml index 7a03f17..88a7b5a 100644 --- a/.config/pmd/ruleset.xml +++ b/.config/pmd/ruleset.xml @@ -10,16 +10,38 @@ + + + + + + + + + + + + + + + + + + + + + + @@ -76,9 +98,6 @@ - - - @@ -114,17 +133,33 @@ + + + + + + + + + + + + + + + + - + From 68cca2be8fb75982634cca45edd03e54a96a84d9 Mon Sep 17 00:00:00 2001 From: AB Date: Mon, 31 Mar 2025 08:40:11 +0200 Subject: [PATCH 42/58] Check for usage of native Vaadin HTML Fixes https://github.com/xdev-software/vaadin-addon-template/issues/284 --- .config/pmd/ruleset.xml | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/.config/pmd/ruleset.xml b/.config/pmd/ruleset.xml index 88a7b5a..d51fbb5 100644 --- a/.config/pmd/ruleset.xml +++ b/.config/pmd/ruleset.xml @@ -194,4 +194,25 @@ + + + + Do not used native HTML! Use Vaadin layouts and components to create required structure. + If you are 100% sure that you escaped the value properly and you have no better options you can suppress this. + + 2 + + + + + + + + From 4112981e55f3c4ca0837bc0bcac0db7ee5bd961c Mon Sep 17 00:00:00 2001 From: AB Date: Mon, 31 Mar 2025 10:45:23 +0200 Subject: [PATCH 43/58] Update Application.java --- .../src/main/java/software/xdev/vaadin/Application.java | 1 + 1 file changed, 1 insertion(+) diff --git a/template-placeholder-demo/src/main/java/software/xdev/vaadin/Application.java b/template-placeholder-demo/src/main/java/software/xdev/vaadin/Application.java index f5a4d96..32833af 100644 --- a/template-placeholder-demo/src/main/java/software/xdev/vaadin/Application.java +++ b/template-placeholder-demo/src/main/java/software/xdev/vaadin/Application.java @@ -9,6 +9,7 @@ import com.vaadin.flow.spring.annotation.EnableVaadin; +@SuppressWarnings({"checkstyle:HideUtilityClassConstructor", "PMD.UseUtilityClass"}) @SpringBootApplication @EnableVaadin @Push From e5152dc2243ec5b88ef9d45e6a836ebf10c9aece Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Tue, 1 Apr 2025 04:11:14 +0000 Subject: [PATCH 44/58] Update lycheeverse/lychee-action digest to 1d97d84 --- .github/workflows/broken-links.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/broken-links.yml b/.github/workflows/broken-links.yml index 2b1188e..ade0346 100644 --- a/.github/workflows/broken-links.yml +++ b/.github/workflows/broken-links.yml @@ -18,7 +18,7 @@ jobs: - name: Link Checker id: lychee - uses: lycheeverse/lychee-action@f613c4a64e50d792e0b31ec34bbcbba12263c6a6 # v2 + uses: lycheeverse/lychee-action@1d97d84f0bc547f7b25f4c2170d87d810dc2fb2c # v2 with: fail: false # Don't fail on broken links, create an issue instead From 4ff7c848a6a29ba54bb1982f5237e16ac325d298 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Thu, 3 Apr 2025 04:13:57 +0000 Subject: [PATCH 45/58] Update dependency com.puppycrawl.tools:checkstyle to v10.23.0 --- pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index c46fefe0..6d58c9d 100644 --- a/pom.xml +++ b/pom.xml @@ -45,7 +45,7 @@ com.puppycrawl.tools checkstyle - 10.22.0 + 10.23.0 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 5dcf34d..71700cc 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -247,7 +247,7 @@ com.puppycrawl.tools checkstyle - 10.22.0 + 10.23.0 From acc4965b79e18120abc09d018bf503da4b8b781c Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Wed, 16 Apr 2025 04:12:32 +0000 Subject: [PATCH 46/58] Update vaadin.version to v24.7.2 --- template-placeholder-demo/pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/template-placeholder-demo/pom.xml b/template-placeholder-demo/pom.xml index 17c5c7e..b8ec8ab 100644 --- a/template-placeholder-demo/pom.xml +++ b/template-placeholder-demo/pom.xml @@ -29,7 +29,7 @@ software.xdev.vaadin.Application - 24.7.1 + 24.7.2 3.4.4 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 7c8d56e..7f8fac3 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -49,7 +49,7 @@ UTF-8 - 24.7.1 + 24.7.2 From 9f5cab50cee12ff7b938c164170d8d064f07be5a Mon Sep 17 00:00:00 2001 From: AB Date: Tue, 22 Apr 2025 08:39:58 +0200 Subject: [PATCH 47/58] Enforce IDEA plugins --- .idea/externalDependencies.xml | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .idea/externalDependencies.xml diff --git a/.idea/externalDependencies.xml b/.idea/externalDependencies.xml new file mode 100644 index 0000000..78be5b8 --- /dev/null +++ b/.idea/externalDependencies.xml @@ -0,0 +1,7 @@ + + + + + + + \ No newline at end of file From 855c40a960bb2b60cd0e58a5d4339ab0bf4d6fbd Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Sat, 26 Apr 2025 04:15:56 +0000 Subject: [PATCH 48/58] Update net.sourceforge.pmd to v7.13.0 --- pom.xml | 4 ++-- template-placeholder/pom.xml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pom.xml b/pom.xml index 6d58c9d..6e8b462 100644 --- a/pom.xml +++ b/pom.xml @@ -82,12 +82,12 @@ net.sourceforge.pmd pmd-core - 7.12.0 + 7.13.0 net.sourceforge.pmd pmd-java - 7.12.0 + 7.13.0 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 71700cc..e1b29d2 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -284,12 +284,12 @@ net.sourceforge.pmd pmd-core - 7.12.0 + 7.13.0 net.sourceforge.pmd pmd-java - 7.12.0 + 7.13.0 From 7c3c850c225fdac6dadff0b541e6f32944f0b9fd Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Mon, 28 Apr 2025 04:16:13 +0000 Subject: [PATCH 49/58] Update dependency com.puppycrawl.tools:checkstyle to v10.23.1 --- pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 6d58c9d..79539b2 100644 --- a/pom.xml +++ b/pom.xml @@ -45,7 +45,7 @@ com.puppycrawl.tools checkstyle - 10.23.0 + 10.23.1 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 71700cc..350e711 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -247,7 +247,7 @@ com.puppycrawl.tools checkstyle - 10.23.0 + 10.23.1 From 25dd0edc236a5305346fd2f2e64c8f058e114b6f Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Sat, 10 May 2025 04:10:09 +0000 Subject: [PATCH 50/58] Update lycheeverse/lychee-action digest to 82202e5 --- .github/workflows/broken-links.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/broken-links.yml b/.github/workflows/broken-links.yml index ade0346..0d8c960 100644 --- a/.github/workflows/broken-links.yml +++ b/.github/workflows/broken-links.yml @@ -18,7 +18,7 @@ jobs: - name: Link Checker id: lychee - uses: lycheeverse/lychee-action@1d97d84f0bc547f7b25f4c2170d87d810dc2fb2c # v2 + uses: lycheeverse/lychee-action@82202e5e9c2f4ef1a55a3d02563e1cb6041e5332 # v2 with: fail: false # Don't fail on broken links, create an issue instead From 22946ad08ebadf5f4196a9512ab7055d6f95431c Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Sat, 10 May 2025 04:12:33 +0000 Subject: [PATCH 51/58] Update lycheeverse/lychee-action digest to 82202e5 --- .github/workflows/broken-links.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/broken-links.yml b/.github/workflows/broken-links.yml index 32f412f..16a3f37 100644 --- a/.github/workflows/broken-links.yml +++ b/.github/workflows/broken-links.yml @@ -19,7 +19,7 @@ jobs: - name: Link Checker id: lychee - uses: lycheeverse/lychee-action@1d97d84f0bc547f7b25f4c2170d87d810dc2fb2c # v2 + uses: lycheeverse/lychee-action@82202e5e9c2f4ef1a55a3d02563e1cb6041e5332 # v2 with: fail: false # Don't fail on broken links, create an issue instead From f202ea5f7abe0681cfddb840972f79d9a43efe53 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Tue, 13 May 2025 04:13:44 +0000 Subject: [PATCH 52/58] Update org.springframework.boot.version to v3.4.5 --- template-placeholder-demo/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/template-placeholder-demo/pom.xml b/template-placeholder-demo/pom.xml index b8ec8ab..8e37d6e 100644 --- a/template-placeholder-demo/pom.xml +++ b/template-placeholder-demo/pom.xml @@ -31,7 +31,7 @@ 24.7.2 - 3.4.4 + 3.4.5 From 25b17b69802caea8cf3da286c36ce96d0dd11356 Mon Sep 17 00:00:00 2001 From: XDEV Renovate Bot Date: Thu, 15 May 2025 04:13:54 +0000 Subject: [PATCH 53/58] Update vaadin.version to v24.7.4 --- template-placeholder-demo/pom.xml | 2 +- template-placeholder/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/template-placeholder-demo/pom.xml b/template-placeholder-demo/pom.xml index b8ec8ab..71c72c4 100644 --- a/template-placeholder-demo/pom.xml +++ b/template-placeholder-demo/pom.xml @@ -29,7 +29,7 @@ software.xdev.vaadin.Application - 24.7.2 + 24.7.4 3.4.4 diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index f9a1def..ec53158 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -49,7 +49,7 @@ UTF-8 - 24.7.2 + 24.7.4 From a84f45cdfd3b748288f3d54d4a6af576231d875d Mon Sep 17 00:00:00 2001 From: AB Date: Thu, 15 May 2025 13:23:06 +0200 Subject: [PATCH 54/58] Fix codestyle --- .../software/xdev/vaadin/FilterComponent.java | 26 ++++++++++++------- .../vaadin/comparators/utl/TypeHelper.java | 6 +++-- .../xdev/vaadin/utl/QueryParameterUtil.java | 19 ++++++++------ 3 files changed, 31 insertions(+), 20 deletions(-) diff --git a/vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/FilterComponent.java b/vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/FilterComponent.java index 04a30b9..7581aa8 100644 --- a/vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/FilterComponent.java +++ b/vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/FilterComponent.java @@ -260,9 +260,9 @@ private void onOperatorChanged() // Change to a text field if the field is of type enum with condition 'contains' if(isSelSearchQueryVisible - && this.selOperations.getValue() - .getDescription() - .equals(ContainsComparator.CONTAINS_COMPARATOR_DESCRIPTION)) + && ContainsComparator.CONTAINS_COMPARATOR_DESCRIPTION.equals( + this.selOperations.getValue() + .getDescription())) { this.selSearchQuery.setVisible(false); this.txtSearchQuery.setVisible(true); @@ -405,7 +405,7 @@ private void onAcceptFilter() if(!this.identifier.isBlank()) { - if(this.editingBadgeId != null && !this.editingBadgeId.equals(NO_BADGE_ID_STRING)) + if(this.editingBadgeId != null && !NO_BADGE_ID_STRING.equals(this.editingBadgeId)) { badge.setBadgeId(this.editingBadgeId); this.editingBadgeId = null; @@ -447,7 +447,7 @@ private void onAcceptFilter() badge.setBtnEditEnabled(true); badge.addBtnEditClickListener(event -> { - if((this.hlFilter.getChildren().findAny().isEmpty())) + if(this.hlFilter.getChildren().findAny().isEmpty()) { // Add all components to the hlFilter layout this.onShowFilterInput(); @@ -514,7 +514,7 @@ private void deactivateDeleteButtonFromChipComponents( if(!this.identifier.isBlank() && badge.getBadgeId() != null - && !badge.getBadgeId().equals(NO_BADGE_ID_STRING)) + && !NO_BADGE_ID_STRING.equals(badge.getBadgeId())) { badge.setBadgeId(DELETED_INITIAL_CONDITION_STRING); this.addQueryParameter(badge); @@ -550,7 +550,7 @@ private void formatLocalDateChipBadgeText(final ChipBadge> final FilterCondition filterField = chipBadge.getItem(); if(this.dateRangePickerQuery.isVisible() - && filterField.getSelectedCondition().getDescription().equals(IS_BETWEEN_COMPARATOR_DESCRIPTION)) + && IS_BETWEEN_COMPARATOR_DESCRIPTION.equals(filterField.getSelectedCondition().getDescription())) { chipBadge.setItemLabelGenerator((ItemLabelGenerator>)tFilterCondition -> { @@ -896,7 +896,7 @@ private void createConditionsFromQueryParameters() && i < this.queryBadgeDeletableList.size() && i < this.queryBadgeEditableList.size()) { - if(!this.queryBadgeIdList.get(i).equals(DELETED_INITIAL_CONDITION_STRING)) + if(!DELETED_INITIAL_CONDITION_STRING.equals(this.queryBadgeIdList.get(i))) { final String badgeId = this.queryBadgeIdList.get(i); CustomizationDegree customizationDegree = CustomizationDegree.EVERYTHING; @@ -933,7 +933,7 @@ private void createConditionsFromQueryParameters() { // Check for same condition final FilterCondition item = chipBadge.getItem(); - if(!chipBadge.getBadgeId().equals(NO_BADGE_ID_STRING) + if(!NO_BADGE_ID_STRING.equals(chipBadge.getBadgeId()) && this.queryInputFieldList.get(i).equals(item.getInputValue()) && this.queryConditionFieldList.get(i) .equals(item.getSelectedCondition().getDescription()) @@ -1216,7 +1216,13 @@ public void beforeEnter(final BeforeEnterEvent beforeEnterEvent) .filter(i -> this.identifier.equals(idList.get(i))) .toArray(); - String componentId, field, condition, input, badgeId, editable, deletable; + String componentId; + String field; + String condition; + String input; + String badgeId; + String editable; + String deletable; for(final int i : matchingIndices) { diff --git a/vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/comparators/utl/TypeHelper.java b/vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/comparators/utl/TypeHelper.java index 29d8729..2e8ad54 100644 --- a/vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/comparators/utl/TypeHelper.java +++ b/vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/comparators/utl/TypeHelper.java @@ -46,7 +46,8 @@ public static boolean isDouble(final String str) return false; } } - + + @SuppressWarnings("PMD.UselessOperationOnImmutable") public static boolean isLocalDate(final String str) { Objects.requireNonNull(str); @@ -61,7 +62,8 @@ public static boolean isLocalDate(final String str) return false; } } - + + @SuppressWarnings("PMD.UselessOperationOnImmutable") public static boolean isLocalDateTime(final String str) { Objects.requireNonNull(str); diff --git a/vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/utl/QueryParameterUtil.java b/vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/utl/QueryParameterUtil.java index fe8298f..47a2602 100644 --- a/vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/utl/QueryParameterUtil.java +++ b/vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/utl/QueryParameterUtil.java @@ -20,6 +20,7 @@ import java.util.HashMap; import java.util.List; import java.util.Map; +import java.util.Set; import com.vaadin.flow.router.QueryParameters; @@ -67,17 +68,19 @@ && isNotNullOrEmpty(inputList) && idList.size() == conditionList.size() && idList.size() == inputList.size()) { + final Set parametersToCheck = Set.of( + QUERY_INPUT_STRING, + QUERY_COMPONENT_ID_STRING, + QUERY_FIELD_STRING, + QUERY_CONDITION_STRING, + QUERY_BADGE_ID_STRING, + QUERY_BADGE_EDITABLE_STRING, + QUERY_BADGE_DELETABLE_STRING); for(final Map.Entry> entry : parametersMap.entrySet()) { // Conditions and fields cannot be null or empty - if(entry.getKey().equals(QUERY_INPUT_STRING) - || ((entry.getKey().equals(QUERY_COMPONENT_ID_STRING) - || entry.getKey().equals(QUERY_FIELD_STRING) - || entry.getKey().equals(QUERY_CONDITION_STRING) - || entry.getKey().equals(QUERY_BADGE_ID_STRING) - || entry.getKey().equals(QUERY_BADGE_EDITABLE_STRING) - || entry.getKey().equals(QUERY_BADGE_DELETABLE_STRING)) - && entry.getValue().stream().noneMatch(String::isBlank))) + if(parametersToCheck.contains(entry.getKey()) + && entry.getValue().stream().noneMatch(String::isBlank)) { rightParameters = true; } From 6b8bdec7766422e80fed7eb74878ccf69614933c Mon Sep 17 00:00:00 2001 From: AB Date: Mon, 19 May 2025 16:14:14 +0200 Subject: [PATCH 55/58] Update .gitignore --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 116a656..5c85054 100644 --- a/.gitignore +++ b/.gitignore @@ -71,6 +71,7 @@ hs_err_pid* .idea/* !.idea/saveactions_settings.xml !.idea/checkstyle-idea.xml +!.idea/externalDependencies.xml !.idea/inspectionProfiles/ .idea/inspectionProfiles/* From a0c76bcc1a1ab0c7f48a879f5c969885687536f3 Mon Sep 17 00:00:00 2001 From: AB Date: Tue, 20 May 2025 09:05:07 +0200 Subject: [PATCH 56/58] =?UTF-8?q?OSSRH=20=E2=86=92=20Sonatype=20Maven=20Ce?= =?UTF-8?q?ntral=20Portal?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/xdev-software/standard-maven-template/issues/155 --- .github/workflows/release.yml | 12 ++++---- .github/workflows/test-deploy.yml | 12 ++++---- template-placeholder/pom.xml | 51 +++++-------------------------- 3 files changed, 19 insertions(+), 56 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 8bd0f3c..2cb3393 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -121,22 +121,22 @@ jobs: git config --global user.name "GitHub Actions" git pull - - name: Set up JDK OSSRH + - name: Set up JDK uses: actions/setup-java@v4 with: # running setup-java again overwrites the settings.xml java-version: '17' distribution: 'temurin' - server-id: ossrh + server-id: sonatype-central-portal server-username: MAVEN_CENTRAL_USERNAME server-password: MAVEN_CENTRAL_TOKEN gpg-passphrase: MAVEN_GPG_PASSPHRASE gpg-private-key: ${{ secrets.MAVEN_GPG_PRIVATE_KEY }} - - name: Publish to OSSRH - run: ../mvnw -B deploy -Possrh -DskipTests + - name: Publish to Central Portal + run: ../mvnw -B deploy -P publish-sonatype-central-portal -DskipTests env: - MAVEN_CENTRAL_USERNAME: ${{ secrets.S01_OSS_SONATYPE_MAVEN_USERNAME }} - MAVEN_CENTRAL_TOKEN: ${{ secrets.S01_OSS_SONATYPE_MAVEN_TOKEN }} + MAVEN_CENTRAL_USERNAME: ${{ secrets.SONATYPE_MAVEN_CENTRAL_PORTAL_USERNAME }} + MAVEN_CENTRAL_TOKEN: ${{ secrets.SONATYPE_MAVEN_CENTRAL_PORTAL_TOKEN }} MAVEN_GPG_PASSPHRASE: ${{ secrets.MAVEN_GPG_PASSPHRASE }} working-directory: ${{ env.PRIMARY_MAVEN_MODULE }} diff --git a/.github/workflows/test-deploy.yml b/.github/workflows/test-deploy.yml index 03f5339..8a85891 100644 --- a/.github/workflows/test-deploy.yml +++ b/.github/workflows/test-deploy.yml @@ -13,21 +13,21 @@ jobs: steps: - uses: actions/checkout@v4 - - name: Set up JDK OSSRH + - name: Set up JDK uses: actions/setup-java@v4 with: # running setup-java again overwrites the settings.xml distribution: 'temurin' java-version: '17' - server-id: ossrh + server-id: sonatype-central-portal server-username: MAVEN_CENTRAL_USERNAME server-password: MAVEN_CENTRAL_TOKEN gpg-passphrase: MAVEN_GPG_PASSPHRASE gpg-private-key: ${{ secrets.MAVEN_GPG_PRIVATE_KEY }} - - name: Publish to OSSRH - run: ../mvnw -B deploy -Possrh -DskipTests + - name: Publish to Central Portal + run: ../mvnw -B deploy -P publish-sonatype-central-portal -DskipTests working-directory: ${{ env.PRIMARY_MAVEN_MODULE }} env: - MAVEN_CENTRAL_USERNAME: ${{ secrets.S01_OSS_SONATYPE_MAVEN_USERNAME }} - MAVEN_CENTRAL_TOKEN: ${{ secrets.S01_OSS_SONATYPE_MAVEN_TOKEN }} + MAVEN_CENTRAL_USERNAME: ${{ secrets.SONATYPE_MAVEN_CENTRAL_PORTAL_USERNAME }} + MAVEN_CENTRAL_TOKEN: ${{ secrets.SONATYPE_MAVEN_CENTRAL_PORTAL_TOKEN }} MAVEN_GPG_PASSPHRASE: ${{ secrets.MAVEN_GPG_PASSPHRASE }} diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 19b3fce..55fb55a 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -49,41 +49,6 @@ UTF-8 - - - - central - https://repo.maven.apache.org/maven2 - - false - - - - - - - - central - https://repo.maven.apache.org/maven2 - - false - - - - - - - ossrh - https://s01.oss.sonatype.org/content/repositories/snapshots - - - ossrh - https://s01.oss.sonatype.org/service/local/staging/deploy/maven2/ - - - @@ -176,7 +141,7 @@ - ossrh + publish-sonatype-central-portal @@ -220,16 +185,14 @@ - org.sonatype.plugins - nexus-staging-maven-plugin - 1.7.0 + org.sonatype.central + central-publishing-maven-plugin + 0.7.0 true - ossrh - https://s01.oss.sonatype.org/ - - 30 - true + sonatype-central-portal + true + published From 1a4d9748107c3be028e90e1f42003c2c2cebfc54 Mon Sep 17 00:00:00 2001 From: AB Date: Tue, 20 May 2025 09:38:39 +0200 Subject: [PATCH 57/58] Wait until ``validated`` as deployment otherwise takes too long See https://github.com/xdev-software/standard-maven-template/issues/155 --- template-placeholder/pom.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/template-placeholder/pom.xml b/template-placeholder/pom.xml index 55fb55a..5a67e47 100644 --- a/template-placeholder/pom.xml +++ b/template-placeholder/pom.xml @@ -192,7 +192,6 @@ sonatype-central-portal true - published From b55781e313bb5ddbc6148ebe767cbd6cd81901d2 Mon Sep 17 00:00:00 2001 From: AB Date: Tue, 20 May 2025 13:43:22 +0200 Subject: [PATCH 58/58] =?UTF-8?q?OSSRH=20=E2=86=92=20Sonatype=20Maven=20Ce?= =?UTF-8?q?ntral=20Portal?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/xdev-software/standard-maven-template/issues/155 --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 01785a7..2e237fc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +# 1.0.2 +* Migrated deployment to _Sonatype Maven Central Portal_ [#155](https://github.com/xdev-software/standard-maven-template/issues/155) +* Updated dependencies + # 1.0.1 * Added customization degree * Makes it possible that certain filters or parts of them are read-only