refactor: remove useless code statement

Author: xdevor

composer.json

@@ -26,10 +26,7 @@
     "autoload-dev": {
         "psr-4": {
             "Xdevor\\ComposerParser\\Tests\\": "tests/"
-        },
-        "files": [
-            "./src/helpers.php"
-        ]
+        }
     },
     "scripts": {
         "test": "./vendor/bin/pest"

src/Concerns/ParseArray.php

@@ -2,74 +2,26 @@
 
 namespace Xdevor\ComposerParser\Concerns;
 
-use ArrayAccess;
-
-/**
- * The code here is based on/reference to Illuminate\Support/Arr.
- */
 trait ParseArray
 {
-    /**
-     * Get an item from an array using "dot" notation.
-     *
-     * @param  \ArrayAccess|array  $array
-     * @param  string|int|null  $key
-     * @param  mixed  $default
-     * @return mixed
-     */
-    private static function parseArray($array, $key, $default = null)
+    private static function parseArray(array $array, string $key, $default = null)
     {
-        if (! static::isValueAccessible($array)) {
-            return value($default);
-        }
-
-        if (is_null($key)) {
-            return $array;
-        }
-
-        if (static::isKeyExists($array, $key)) {
+        if (array_key_exists($key, $array)) {
             return $array[$key];
         }
 
         if (strpos($key, '.') === false) {
-            return $array[$key] ?? value($default);
+            return $array[$key] ?? $default;
         }
 
         foreach (explode('.', $key) as $segment) {
-            if (static::isValueAccessible($array) && static::isKeyExists($array, $segment)) {
+            if (array_key_exists($segment, $array)) {
                 $array = $array[$segment];
             } else {
-                return value($default);
+                return $default;
             }
         }
 
         return $array;
     }
-
-    /**
-     * Determine whether the given value is array accessible.
-     *
-     * @param  mixed  $value
-     * @return bool
-     */
-    private static function isValueAccessible($value)
-    {
-        return is_array($value) || $value instanceof ArrayAccess;
-    }
-
-    /**
-     * Determine if the given key exists in the provided array.
-     *
-     * @param  \ArrayAccess|array  $array
-     * @param  string|int  $key
-     * @return bool
-     */
-    private static function isKeyExists($array, $key)
-    {
-        if ($array instanceof ArrayAccess) {
-            return $array->offsetExists($key);
-        }
-
-        return array_key_exists($key, $array);
-    }
 }

src/helpers.php

@@ -14,11 +14,14 @@
     expect($actual)->toBe(null);
 });
 
-test('It return default value if key not exist', function () {
+test('It return default value if key not exist', function ($key) {
     $packageName = 'ooo/xxx';
-    $actual = (new Parser())->parse($packageName, 'name', 'this_is_default');
+    $actual = (new Parser())->parse($packageName, $key, 'this_is_default');
     expect($actual)->toBe('this_is_default');
-});
+})->with([
+    'name',
+    'author.name'
+]);
 
 test('It can return correct value if array key exist', function () {
     $packageName = 'doctrine/instantiator';