Update example (#210)

* Update analytics exapmle script

- explicitly convert map object to list (Python 3 compatible)
- remove misuse of "count" parameter (it's just a page size adjuster and Cursor class will read all cursor until it's exhausted anyway.)

* consistent use of map() with join() method

Author: smaeda-ks

examples/analytics.py

@@ -7,6 +7,7 @@
 # https://dev.twitter.com/ads/analytics/metrics-and-segmentation
 # https://dev.twitter.com/ads/analytics/metrics-derived
 
+import sys
 import time
 
 from twitter_ads.client import Client
@@ -25,8 +26,8 @@
 # load the advertiser account instance
 account = client.accounts(ACCOUNT_ID)
 
-# limit request count and grab the first 10 line items from Cursor
-line_items = list(account.line_items(None, count=10))[:10]
+# grab the first 10 line items from Cursor
+line_items = list(account.line_items(None))[:10]
 
 # the list of metrics we want to fetch, for a full list of possible metrics
 # see: https://dev.twitter.com/ads/analytics/metrics-and-segmentation
@@ -36,7 +37,11 @@
 line_items[0].stats(metric_groups)
 
 # fetching stats for multiple line items
-ids = map(lambda x: x.id, line_items)
+ids = list(map(lambda x: x.id, line_items))
+if not ids:
+    print('Error: A minimum of 1 items must be provided for entity_ids')
+    sys.exit()
+
 LineItem.all_stats(account, ids, metric_groups)
 
 # fetching async stats on the instance
@@ -52,3 +57,5 @@
 async_stats_job_result = LineItem.async_stats_job_result(account, [job_id]).first
 
 async_data = LineItem.async_stats_job_data(account, async_stats_job_result.url)
+
+print(async_data)

twitter_ads/campaign.py

@@ -22,7 +22,7 @@ class TargetingCriteria(Resource, Persistence, Batch):
     @classmethod
     def all(klass, account, line_item_ids, **kwargs):
         """Returns a Cursor instance for a given resource."""
-        params = {'line_item_ids': ','.join(line_item_ids)}
+        params = {'line_item_ids': ','.join(map(str, line_item_ids))}
         params.update(kwargs)
 
         resource = klass.RESOURCE_COLLECTION.format(account_id=account.id)

twitter_ads/creative.py

@@ -513,7 +513,7 @@ def load(klass, account, card_uris=None, card_id=None, with_deleted=None):
             params['with_deleted'] = 'true'
 
         if card_uris:
-            params['card_uris'] = ','.join(card_uris)
+            params['card_uris'] = ','.join(map(str, card_uris))
             resource = klass.FETCH_URI.format(account_id=account.id)
             request = Request(account.client, 'get', resource, params=params)
             return Cursor(klass, request, init_with=[account])

twitter_ads/resource.py

@@ -254,15 +254,15 @@ def _standard_params(klass, ids, metric_groups, **kwargs):
         placement = kwargs.get('placement', PLACEMENT.ALL_ON_TWITTER)
 
         params = {
-            'metric_groups': ','.join(metric_groups),
+            'metric_groups': ','.join(map(str, metric_groups)),
             'start_time': to_time(start_time, granularity),
             'end_time': to_time(end_time, granularity),
             'granularity': granularity.upper(),
             'entity': klass.ANALYTICS_MAP[klass.__name__],
             'placement': placement
         }
 
-        params['entity_ids'] = ','.join(ids)
+        params['entity_ids'] = ','.join(map(str, ids))
 
         return params