Adjust params inconsistency between response and request (#119)

* Adjust params inconsistency between response and request

* to_params() should skip empty list

Author: hachibeeDI

twitter_ads/campaign.py

@@ -266,6 +266,16 @@ def targeting_criteria(self, id=None, **kwargs):
         else:
             return TargetingCriteria.load(self.account, id, **kwargs)
 
+    def save(self):
+        # automatically_select_bid and bid_type are exclusive parameters
+        if self.automatically_select_bid and self.bid_type:
+            if self.bid_type == 'AUTO':
+                self.bid_type = None
+                self.automatically_select_bid = True
+            else:
+                self.automatically_select_bid = None
+        super(LineItem, self).save()
+
 
 # line item properties
 # read-only

twitter_ads/resource.py

@@ -79,6 +79,8 @@ def to_params(self):
             if isinstance(value, datetime):
                 params[name] = format_time(value)
             elif isinstance(value, list):
+                if not value:
+                    continue
                 params[name] = ','.join(map(str, value))
             elif isinstance(value, bool):
                 params[name] = str(value).lower()