Skip to content

Commit dd9adf2

Browse files
authored
Remove deprecated sentiment targeting (#247)
* Remove deprecated sentiment targeting * update fixtures
1 parent 1350f9b commit dd9adf2

File tree

3 files changed

+0
-12
lines changed

3 files changed

+0
-12
lines changed

tests/fixtures/line_items_all.json

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
"currency": "USD",
3030
"created_at": "2011-07-11T20:36:11Z",
3131
"updated_at": "2011-09-04T19:39:51Z",
32-
"include_sentiment": null,
3332
"campaign_id": "2wap7",
3433
"deleted": false
3534
},
@@ -57,7 +56,6 @@
5756
"currency": "USD",
5857
"created_at": "2011-07-13T20:56:39Z",
5958
"updated_at": "2011-09-04T19:39:04Z",
60-
"include_sentiment": null,
6159
"campaign_id": "2wamv",
6260
"deleted": false
6361
},
@@ -85,7 +83,6 @@
8583
"currency": "USD",
8684
"created_at": "2011-07-14T00:04:47Z",
8785
"updated_at": "2011-09-04T19:39:39Z",
88-
"include_sentiment": null,
8986
"campaign_id": "2wai9",
9087
"deleted": false
9188
},
@@ -113,7 +110,6 @@
113110
"currency": "USD",
114111
"created_at": "2011-08-22T22:42:18Z",
115112
"updated_at": "2011-09-04T19:40:02Z",
116-
"include_sentiment": null,
117113
"campaign_id": "2of1n",
118114
"deleted": false
119115
},
@@ -141,7 +137,6 @@
141137
"currency": "JPY",
142138
"created_at": "2011-08-26T20:51:14Z",
143139
"updated_at": "2011-08-26T21:30:25Z",
144-
"include_sentiment": "POSITIVE_ONLY",
145140
"campaign_id": "2w9n1",
146141
"deleted": true
147142
},
@@ -169,7 +164,6 @@
169164
"currency": "USD",
170165
"created_at": "2011-08-26T21:38:51Z",
171166
"updated_at": "2011-08-26T22:24:37Z",
172-
"include_sentiment": "POSITIVE_ONLY",
173167
"campaign_id": "2vuug",
174168
"deleted": true
175169
},
@@ -197,7 +191,6 @@
197191
"currency": "JPY",
198192
"created_at": "2011-08-26T22:28:55Z",
199193
"updated_at": "2011-09-04T19:38:46Z",
200-
"include_sentiment": null,
201194
"campaign_id": "2vuj3",
202195
"deleted": false
203196
},
@@ -225,7 +218,6 @@
225218
"currency": "USD",
226219
"created_at": "2011-09-01T17:25:04Z",
227220
"updated_at": "2011-09-16T02:56:55Z",
228-
"include_sentiment": null,
229221
"campaign_id": "2v3c4",
230222
"deleted": true
231223
},
@@ -253,7 +245,6 @@
253245
"currency": "JPY",
254246
"created_at": "2011-09-06T17:42:52Z",
255247
"updated_at": "2011-09-30T18:54:18Z",
256-
"include_sentiment": null,
257248
"campaign_id": "2ttv3",
258249
"deleted": false
259250
},
@@ -281,7 +272,6 @@
281272
"currency": "USD",
282273
"created_at": "2011-09-06T22:44:13Z",
283274
"updated_at": "2011-09-20T01:32:27Z",
284-
"include_sentiment": null,
285275
"campaign_id": "2ttv3",
286276
"deleted": true
287277
}

tests/fixtures/line_items_load.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
"currency": "USD",
2525
"created_at": "2011-07-11T20:36:11Z",
2626
"updated_at": "2011-09-04T19:39:51Z",
27-
"include_sentiment": null,
2827
"campaign_id": "2wap7",
2928
"deleted": false
3029
},

twitter_ads/campaign.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,6 @@ def save(self):
298298
resource_property(LineItem, 'charge_by')
299299
resource_property(LineItem, 'end_time', transform=TRANSFORM.TIME)
300300
resource_property(LineItem, 'entity_status')
301-
resource_property(LineItem, 'include_sentiment')
302301
resource_property(LineItem, 'audience_expansion')
303302
resource_property(LineItem, 'name')
304303
resource_property(LineItem, 'objective')

0 commit comments

Comments
 (0)