Skip to content

Commit d45e929

Browse files
charleskeepaxgregkh
authored andcommitted
Revert "gpio: swnode: don't use the swnode's name as the key for GPIO lookup"
This reverts commit 25decf0. This software node change doesn't actually fix any current issues with the kernel, it is an improvement to the lookup process rather than fixing a live bug. It also causes a couple of regressions with shipping laptops, which relied on the label based lookup. There is a fix for the regressions in mainline, the first 5 patches of [1]. However, those patches are fairly substantial changes and given the patch causing the regression doesn't actually fix a bug it seems better to just revert it in stable. CC: [email protected] # 6.12, 6.17 Link: https://lore.kernel.org/linux-sound/[email protected]/ [1] Closes: thesofproject/linux#5599 Closes: thesofproject/linux#5603 Acked-by: Bartosz Golaszewski <[email protected]> Signed-off-by: Charles Keepax <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 4a4abb0 commit d45e929

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpio/gpiolib-swnode.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ static struct gpio_device *swnode_get_gpio_device(struct fwnode_handle *fwnode)
4141
!strcmp(gdev_node->name, GPIOLIB_SWNODE_UNDEFINED_NAME))
4242
return ERR_PTR(-ENOENT);
4343

44-
gdev = gpio_device_find_by_fwnode(fwnode);
44+
gdev = gpio_device_find_by_label(gdev_node->name);
4545
return gdev ?: ERR_PTR(-EPROBE_DEFER);
4646
}
4747

0 commit comments

Comments
 (0)