improve caching

Author: xdustinface

.github/scripts/ci_config.py

@@ -160,12 +160,7 @@ def run_group_tests(args):
 
         github_group_start(f"Testing {crate}")
 
-        # On Windows, skip --all-features to avoid x11 feature
-        if args.os == "windows-latest":
-            cmd = ["cargo", "test", "-p", crate]
-        else:
-            cmd = ["cargo", "test", "-p", crate, "--all-features"]
-
+        cmd = ["cargo", "test", "-p", crate, "--all-features"]
         result = subprocess.run(cmd)
 
         github_group_end()

.github/workflows/build-and-test.yml

@@ -0,0 +1,50 @@
+name: Build and Test
+
+on:
+  workflow_call:
+    inputs:
+      os:
+        required: true
+        type: string
+      exclude-crates:
+        required: false
+        type: string
+        default: ""
+
+jobs:
+  build:
+    name: "build (${{ inputs.os }})"
+    runs-on: ${{ inputs.os }}
+    steps:
+      - uses: actions/checkout@v6
+      - uses: dtolnay/rust-toolchain@stable
+      - uses: Swatinem/rust-cache@v2
+        with:
+          shared-key: "rust-cache-${{ inputs.os }}"
+          cache-on-failure: true
+      - name: Build workspace
+        run: cargo build --workspace --all-targets --all-features ${{ inputs.exclude-crates && format('--exclude {0}', inputs.exclude-crates) || '' }}
+
+  test:
+    name: "test: ${{ matrix.group }} (${{ inputs.os }})"
+    needs: build
+    runs-on: ${{ inputs.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        group: [core, spv, wallet, rpc, tools]
+    steps:
+      - uses: actions/checkout@v6
+      - uses: dtolnay/rust-toolchain@stable
+      - uses: Swatinem/rust-cache@v2
+        with:
+          shared-key: "rust-cache-${{ inputs.os }}"
+          save-if: false
+      - uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+          cache: "pip"
+          cache-dependency-path: .github/scripts/requirements.txt
+      - run: pip install -r .github/scripts/requirements.txt
+      - name: Run tests
+        run: python .github/scripts/ci_config.py run-group ${{ matrix.group }} --os ${{ inputs.os }}

.github/workflows/rust.yml

@@ -40,6 +40,8 @@ jobs:
       - uses: actions/checkout@v6
       - uses: dtolnay/rust-toolchain@stable
       - uses: Swatinem/rust-cache@v2
+        with:
+          shared-key: "rust-cache-docs"
       - name: Build documentation
         env:
           RUSTDOCFLAGS: -D warnings
@@ -59,29 +61,31 @@ jobs:
       - name: Check all crates are assigned to test groups
         run: python .github/scripts/ci_config.py verify-groups
 
-  test:
-    name: "test: ${{ matrix.group }} (${{ matrix.os }})"
+  # Per-OS build and test (reusable workflow handles build -> test dependency)
+  ubuntu:
     needs: verify-execution
-    runs-on: ${{ matrix.os }}
-    strategy:
-      fail-fast: false
-      matrix:
-        os: [ubuntu-latest, ubuntu-22.04-arm, macos-latest, windows-latest]
-        group: [core, spv, wallet, rpc, tools]
-    steps:
-      - uses: actions/checkout@v6
-      - uses: dtolnay/rust-toolchain@stable
-      - uses: Swatinem/rust-cache@v2
-        with:
-          shared-key: "rust-cache-${{ matrix.os }}-${{ matrix.group }}"
-      - uses: actions/setup-python@v5
-        with:
-          python-version: "3.12"
-          cache: "pip"
-          cache-dependency-path: .github/scripts/requirements.txt
-      - run: pip install -r .github/scripts/requirements.txt
-      - name: Run tests
-        run: python .github/scripts/ci_config.py run-group ${{ matrix.group }} --os ${{ matrix.os }}
+    uses: ./.github/workflows/build-and-test.yml
+    with:
+      os: ubuntu-latest
+
+  ubuntu-arm:
+    needs: verify-execution
+    uses: ./.github/workflows/build-and-test.yml
+    with:
+      os: ubuntu-22.04-arm
+
+  macos:
+    needs: verify-execution
+    uses: ./.github/workflows/build-and-test.yml
+    with:
+      os: macos-latest
+
+  windows:
+    needs: verify-execution
+    uses: ./.github/workflows/build-and-test.yml
+    with:
+      os: windows-latest
+      exclude-crates: dash-fuzz
 
   no-std:
     name: No-std Checks
@@ -90,6 +94,8 @@ jobs:
       - uses: actions/checkout@v6
       - uses: dtolnay/rust-toolchain@stable
       - uses: Swatinem/rust-cache@v2
+        with:
+          shared-key: "rust-cache-no-std"
       - uses: actions/setup-python@v5
         with:
           python-version: "3.12"

.github/workflows/sanitizer.yml

@@ -34,6 +34,9 @@ jobs:
         with:
           components: rust-src
       - uses: Swatinem/rust-cache@v2
+        with:
+          shared-key: "rust-cache-asan"
+          cache-on-failure: true
 
       - name: Run tests with ASAN
         env:
@@ -59,6 +62,9 @@ jobs:
         with:
           components: rust-src
       - uses: Swatinem/rust-cache@v2
+        with:
+          shared-key: "rust-cache-tsan"
+          cache-on-failure: true
 
       - name: Run tests with TSAN
         env: