rework

Author: xdustinface

dash-spv-ffi/include/dash_spv_ffi.h

@@ -609,9 +609,14 @@ int32_t dash_spv_ffi_config_set_max_peers(struct FFIClientConfig *config,
 /**
  * Adds a peer address to the configuration
  *
- * Accepts either a full socket address (e.g., `192.168.1.1:9999` or `[::1]:19999`)
- * or an IP-only string (e.g., "127.0.0.1" or "2001:db8::1"). When an IP-only
- * string is given, the default P2P port for the configured network is used.
+ * Accepts socket addresses with or without port. When no port is specified,
+ * the default P2P port for the configured network is used.
+ *
+ * Supported formats:
+ * - IP with port: `192.168.1.1:9999`, `[::1]:19999`
+ * - IP without port: `127.0.0.1`, `2001:db8::1`
+ * - Hostname with port: `node.example.com:9999`
+ * - Hostname without port: `node.example.com`
  *
  * # Safety
  * - `config` must be a valid pointer to an FFIClientConfig created by dash_spv_ffi_config_new/mainnet/testnet

dash-spv-ffi/src/config.rs

@@ -125,9 +125,14 @@ pub unsafe extern "C" fn dash_spv_ffi_config_set_max_peers(
 
 /// Adds a peer address to the configuration
 ///
-/// Accepts either a full socket address (e.g., `192.168.1.1:9999` or `[::1]:19999`)
-/// or an IP-only string (e.g., "127.0.0.1" or "2001:db8::1"). When an IP-only
-/// string is given, the default P2P port for the configured network is used.
+/// Accepts socket addresses with or without port. When no port is specified,
+/// the default P2P port for the configured network is used.
+///
+/// Supported formats:
+/// - IP with port: `192.168.1.1:9999`, `[::1]:19999`
+/// - IP without port: `127.0.0.1`, `2001:db8::1`
+/// - Hostname with port: `node.example.com:9999`
+/// - Hostname without port: `node.example.com`
 ///
 /// # Safety
 /// - `config` must be a valid pointer to an FFIClientConfig created by dash_spv_ffi_config_new/mainnet/testnet
@@ -171,24 +176,14 @@ pub unsafe extern "C" fn dash_spv_ffi_config_add_peer(
         return FFIErrorCode::Success as i32;
     }
 
-    // 3) Attempt DNS resolution for hostnames with explicit port
-    match addr_str.split_once(':') {
-        None => {
-            set_last_error("Invalid hostname. Use 'host:port' or IP address");
-            return FFIErrorCode::InvalidArgument as i32;
-        }
-        Some(("", _)) => {
-            set_last_error("Missing hostname. Use 'host:port' or IP address");
-            return FFIErrorCode::InvalidArgument as i32;
-        }
-        Some((_, "")) => {
-            set_last_error("Missing port. Use 'host:port' or IP address");
-            return FFIErrorCode::InvalidArgument as i32;
-        }
-        Some(_) => {}
-    }
+    // 3) Must be a hostname - reject empty, append default port if not specified
+    let addr_with_port = if addr_str.contains(':') {
+        addr_str.to_string()
+    } else {
+        format!("{}:{}", addr_str, default_port)
+    };
 
-    match addr_str.to_socket_addrs() {
+    match addr_with_port.to_socket_addrs() {
         Ok(mut iter) => match iter.next() {
             Some(sock) => {
                 cfg.peers.push(sock);

dash-spv-ffi/tests/unit/test_configuration.rs

@@ -54,13 +54,14 @@ mod tests {
 
             // Test various invalid addresses
             let invalid_addrs = [
-                "256.256.256.256:9999",  // invalid IP octets
-                "127.0.0.1:99999",       // port too high
-                "127.0.0.1:-1",          // negative port
-                "hostname-without-port", // hostname without port should be rejected
-                ":9999",                 // missing IP
-                ":::",                   // invalid IPv6
-                "localhost:abc",         // non-numeric port
+                "",                     // empty string
+                "256.256.256.256:9999", // invalid IP octets
+                "127.0.0.1:99999",      // port too high
+                "127.0.0.1:-1",         // negative port
+                ":9999",                // missing hostname
+                ":::",                  // invalid IPv6
+                "localhost:abc",        // non-numeric port
+                "localhost:",           // empty port
             ];
 
             for addr in &invalid_addrs {
@@ -87,6 +88,7 @@ mod tests {
                 "127.0.0.1",      // IP-only v4
                 "2001:db8::1",    // IP-only v6
                 "localhost:9999", // Hostname with port
+                "localhost",      // Hostname without port (uses default)
             ];
 
             for addr in &valid_addrs {