Fixing some code quality issues

Author: jdewinne

.travis.yml

@@ -7,7 +7,7 @@ deploy:
   provider: releases
   api_key:
     secure: HaLgQjTqegx0wexEexbBKB+D1DGwbiW7zQgLMpbA/d1PUQRLHMIZLNE8u1V5/4/qLSRqmp/VdLHwvSWbcc7dPrzNN09rwEb7HPLORkCvSHq6/pOgnJ1xIWU4CMjNewjxYS94AnQN+0+PFdFw7mqTuf6cz/IVCZxypCEzckziI220DLYBXBS9vNSko55979yhQv7U31vd/CJ63cp21qvemAcFncQr98FKq6JsbpMtOOjAqjvN/VPpnphhoV7DxbiKEMZ9ZePClg69HpZ+Q/o2qUm/BKd32ZmpZosTE27Gaj81TVnLeLfveeBRt0jTK4gisS5++t6AfK01DHGexT4hVgG34jkjQQX76imCMa+sd61Ixs2P4rVRl9zqJKFBlxoeOkdXhenLqDZL0c/jKYXXtIln6f24rnQ26t1L7zbdI2I0G+gS0aZfXAMSXoFioZCplydRkuuHrr/HOVmlBk7LF36cvXSbv2UVwATrNjOZs0Sd0fBxrOtnQ7l9g3vSufV59kHE/ic80Lrbn8Pphh3gRDsOrVGF/vHvz5Aho0kCxLwqoz6hajQ0kIVvfIz3kC2xITeFWYwYgUUupLUopj2GiIpOdcPhZJ/9Lr0+zr3cxW/l7orWwmuVT/Eo9JdyhX+GaYvRvNkU9x1A1VFF/R3AOc2eSDi+zmCASbqdA9vE/Zs=
-  file: build/libs/xlr-ucd-plugin-1.4.0.jar
+  file: build/libs/xlr-ucd-plugin-1.4.1.jar
   skip_cleanup: true
   on:
     tags: true

build.gradle

@@ -3,7 +3,7 @@ plugins {
     id "com.xebialabs.xl.docker" version "1.1.0"
 }
 
-version='1.4.0'
+version='1.4.1'
 
 apply plugin: 'java'
 apply plugin: 'idea'

src/main/resources/ucd/ApplicationProcessRequest.py

@@ -11,8 +11,8 @@
 from ucd.UCDClientUtil import UCD_Client_Util
 
 
-verifySsl = not server['disableSslVerification']
-ucd_client = UCD_Client_Util.create_ucd_client(server, username, password, verifySsl)
+verify_ssl = not server['disableSslVerification']
+ucd_client = UCD_Client_Util.create_ucd_client(server, username, password, verify_ssl)
 
 requestId = ucd_client.application_process_request(application, applicationProcess, environment, versions, properties)
 

src/main/resources/ucd/ApplicationProcessRequestStatus.py

@@ -8,23 +8,23 @@
 # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #
 
-import time, sys
+import time
+
 from ucd.UCDClientUtil import UCD_Client_Util
 
-verifySsl = not server['disableSslVerification']
-ucd_client = UCD_Client_Util.create_ucd_client(server, username, password, verifySsl)
+verify_ssl = not server['disableSslVerification']
+ucd_client = UCD_Client_Util.create_ucd_client(server, username, password, verify_ssl)
 trial = 0
-request_status = None
 request_response = None
 while not numberOfPollingTrials or trial < numberOfPollingTrials:
     trial += 1
     time.sleep(pollingInterval)
     request_response = ucd_client.application_process_request_status(requestId)
     requestStatus = request_response["status"]
     requestResult = request_response["result"]
-    print "requestStatus: %s requestResult: %s" % (requestStatus, requestResult)
+    print "Received Request Status: [%s] with Request Result: [%s]\n" % (requestStatus, requestResult)
     if requestStatus in ("CLOSED", "FAULTED"):
         if requestResult not in "SUCCEEDED":
-            raise Exception("Failed to execute application process request. Status [%s], Result [%s]" % (requestStatus, requestResult))
-        else:
-            break
+            raise Exception("Failed to execute application process request. Status [%s], Result [%s]" % (
+            requestStatus, requestResult))
+        break

src/main/resources/ucd/ListSystemConfiguration.py

@@ -10,8 +10,8 @@
 
 from ucd.UCDClientUtil import UCD_Client_Util
 
-verifySsl = not server['disableSslVerification']
-ucd_client = UCD_Client_Util.create_ucd_client(server, username, password, verifySsl)
+verify_ssl = not server['disableSslVerification']
+ucd_client = UCD_Client_Util.create_ucd_client(server, username, password, verify_ssl)
 
 systemConfiguration = ucd_client.list_system_configuration()