dumper: fix the last chunksize >0 and rows=0 #15

bohutang · bohutang · commit e66876cac330 · 2019-03-11T22:31:00.000+08:00
diff --git a/src/common/dumper.go b/src/common/dumper.go
@@ -110,8 +110,10 @@ func dumpTable(log *xlog.Log, conn *Connection, args *Args, table string) {
 		}
 	}
 	if chunkbytes > 0 {
-		insertone := fmt.Sprintf("INSERT INTO `%s`(%s) VALUES\n%s", table, strings.Join(fields, ","), strings.Join(rows, ",\n"))
-		inserts = append(inserts, insertone)
+		if len(rows) > 0 {
+			insertone := fmt.Sprintf("INSERT INTO `%s`(%s) VALUES\n%s", table, strings.Join(fields, ","), strings.Join(rows, ",\n"))
+			inserts = append(inserts, insertone)
+		}
 
 		query := strings.Join(inserts, ";\n") + ";\n"
 		file := fmt.Sprintf("%s/%s.%s.%05d.sql", args.Outdir, args.Database, table, fileNo)

Original file line number	Diff line number	Diff line change
`@@ -110,8 +110,10 @@ func dumpTable(log xlog.Log, conn Connection, args *Args, table string) {`
`110`	`110`	`}`
`111`	`111`	`}`
`112`	`112`	`if chunkbytes > 0 {`
`113`		- insertone := fmt.Sprintf("INSERT INTO `%s`(%s) VALUES\n%s", table, strings.Join(fields, ","), strings.Join(rows, ",\n"))
`114`		`- inserts = append(inserts, insertone)`
	`113`	`+ if len(rows) > 0 {`
	`114`	+ insertone := fmt.Sprintf("INSERT INTO `%s`(%s) VALUES\n%s", table, strings.Join(fields, ","), strings.Join(rows, ",\n"))
	`115`	`+ inserts = append(inserts, insertone)`
	`116`	`+ }`
`115`	`117`
`116`	`118`	`query := strings.Join(inserts, ";\n") + ";\n"`
`117`	`119`	`file := fmt.Sprintf("%s/%s.%s.%05d.sql", args.Outdir, args.Database, table, fileNo)`