Merge pull request #9 from TeachersPayTeachers/fallback-to-default-auth-plugin

fix: fallback to default auth plugin if not set

Author: BohuTANG

proto/auth.go

@@ -113,9 +113,12 @@ func (a *Auth) UnPack(payload []byte) error {
 		if a.pluginName, err = buf.ReadStringNUL(); err != nil {
 			return fmt.Errorf("auth.unpack: can't read pluginName")
 		}
-	}
-	if a.pluginName != DefaultAuthPluginName {
-		return fmt.Errorf("invalid authPluginName, got %v but only support %v", a.pluginName, DefaultAuthPluginName)
+		if a.pluginName != DefaultAuthPluginName {
+			return fmt.Errorf("invalid authPluginName, got '%s' but only support %s", a.pluginName, DefaultAuthPluginName)
+		}
+	} else {
+		// Allow fallback to default auth plugin
+		a.pluginName = DefaultAuthPluginName
 	}
 	return nil
 }

proto/auth_test.go

@@ -198,6 +198,28 @@ func TestAuthWithoutSecure(t *testing.T) {
 	assert.Equal(t, want, got)
 }
 
+func TestAuthWithoutPluginAuth(t *testing.T) {
+	want := NewAuth()
+	want.charset = 0x02
+	want.authResponseLen = 20
+	want.clientFlags = DefaultClientCapability ^ sqldb.CLIENT_PLUGIN_AUTH
+	want.authResponse = nativePassword("sbtest", DefaultSalt)
+	want.user = "sbtest"
+	want.database = "test_db"
+
+	got := NewAuth()
+	err := got.UnPack(want.Pack(
+		DefaultClientCapability,
+		0x02,
+		"sbtest",
+		"sbtest",
+		DefaultSalt,
+		"",
+	))
+	assert.Nil(t, err)
+	assert.Equal(t, got.pluginName, DefaultAuthPluginName)
+}
+
 func TestAuthUnPackError(t *testing.T) {
 	capabilityFlags := DefaultClientCapability
 	capabilityFlags |= sqldb.CLIENT_PROTOCOL_41