Skip to content

Commit 021f79a

Browse files
committed
Fix PHPUnit version constraints
Also pin max tested version of HTMLPurifier to 4.17.0, because 4.18.0 removed support for conditional comments (ezyang/htmlpurifier@4828fdf).
1 parent 0105fef commit 021f79a

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ jobs:
4343
- name: Install dependencies
4444
run: |
4545
echo PHP_VERSION: ${{ env.PHP_VERSION }}
46+
composer require --no-update ezyang/htmlpurifier:\<=4.17.0
4647
composer install
4748
4849
- name: Run tests
@@ -57,3 +58,4 @@ jobs:
5758
if [ -f "build/logs/clover.xml" ] && [ -f "vendor/bin/php-coveralls" ]; then
5859
php vendor/bin/php-coveralls -v;
5960
fi
61+
continue-on-error: true

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"ezyang/htmlpurifier": "^4.8"
2626
},
2727
"require-dev": {
28-
"phpunit/phpunit": ">=4.7",
28+
"phpunit/phpunit": ">=4.7 <10.0",
2929
"php-coveralls/php-coveralls": "^1.1|^2.1",
3030
"masterminds/html5": "^2.7"
3131
},

0 commit comments

Comments
 (0)