debug: Add VK_CHECK_FRIENDLY user-friendly assertion macro

This extends the VK_CHECK macro to print additional information intended to
allow users to self-diagnose very common problems (like lack of VRAM, the
usecase included here).

Author: abaire

hw/xbox/nv2a/pgraph/vk/debug.h

@@ -61,6 +61,22 @@ extern int nv2a_vk_dgroup_indent;
         }                                                                    \
     } while (0)
 
+#define VK_CHECK_FRIENDLY(x, msg)                                            \
+    do {                                                                     \
+        VkResult vk_result = (x);                                            \
+        if (vk_result != VK_SUCCESS) {                                       \
+            fprintf(stderr, "vk_result = %d\n", vk_result);                  \
+            nv2a_log_fatal_error(                                            \
+                "%s\nvk check failed: vk_result = %d\nat %s:%d\n", msg,      \
+                vk_result, __FILE__, __LINE__);                              \
+            assert((x) && msg &&                                             \
+                   "A fatal error occurred. Check the xemu fatal error log " \
+                   "in your home directory for details.");                   \
+            exit(127);                                                       \
+        }                                                                    \
+    } while (0)
+
+
 void pgraph_vk_debug_frame_terminator(void);
 
 #endif

hw/xbox/nv2a/pgraph/vk/surface.c

@@ -786,13 +786,16 @@ static void create_surface_image(PGRAPHState *pg, SurfaceBinding *surface)
         .usage = VMA_MEMORY_USAGE_AUTO_PREFER_DEVICE,
     };
 
-    VK_CHECK(vmaCreateImage(r->allocator, &image_create_info,
-                            &alloc_create_info, &surface->image,
-                            &surface->allocation, NULL));
-
-    VK_CHECK(vmaCreateImage(r->allocator, &image_create_info,
-                            &alloc_create_info, &surface->image_scratch,
-                            &surface->allocation_scratch, NULL));
+    VK_CHECK_FRIENDLY(vmaCreateImage(r->allocator, &image_create_info,
+                                     &alloc_create_info, &surface->image,
+                                     &surface->allocation, NULL),
+                      "Likely out of video memory");
+
+    VK_CHECK_FRIENDLY(vmaCreateImage(r->allocator, &image_create_info,
+                                     &alloc_create_info,
+                                     &surface->image_scratch,
+                                     &surface->allocation_scratch, NULL),
+                      "Likely out of video memory");
     surface->image_scratch_current_layout = VK_IMAGE_LAYOUT_UNDEFINED;
 
     VkImageViewCreateInfo image_view_create_info = {