debug: Log framebuffer details when not complete

Author: abaire

hw/xbox/nv2a/debug.c

@@ -0,0 +1,82 @@
+/*
+ * Geforce NV2A PGRAPH OpenGL Renderer debug routines
+ *
+ * Copyright (c) 2025 Matt Borgerson
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "hw/xbox/nv2a/debug_gl.h"
+
+#include <stdio.h>
+
+#include "qemu/osdep.h"
+
+#ifdef XEMU_DEBUG_BUILD
+
+static GLenum framebuffer_attachments[] = { GL_COLOR_ATTACHMENT0,
+                                            GL_DEPTH_ATTACHMENT,
+                                            GL_STENCIL_ATTACHMENT,
+                                            GL_DEPTH_STENCIL_ATTACHMENT };
+
+void gl_debug_assert_framebuffer_complete(const char *source_file, int line)
+{
+    GLenum status = glCheckFramebufferStatus(GL_FRAMEBUFFER);
+    if (status == GL_FRAMEBUFFER_COMPLETE) {
+        return;
+    }
+
+    fprintf(stderr,
+            "OpenGL framebuffer status: 0x%X (%d) != "
+            "GL_FRAMEBUFFER_COMPLETE at %s:%d\n",
+            status, status, source_file, line);
+
+    GLint objectType, objectName;
+    for (int i = 0; i < ARRAY_SIZE(framebuffer_attachments); ++i) {
+        GLenum attachment = framebuffer_attachments[i];
+
+        glGetFramebufferAttachmentParameteriv(
+            GL_FRAMEBUFFER, attachment, GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE,
+            &objectType);
+
+        if (objectType == GL_NONE) {
+            fprintf(stderr, "\t0x%X: GL_NONE\n", attachment);
+        } else {
+            glGetFramebufferAttachmentParameteriv(
+                GL_FRAMEBUFFER, attachment,
+                GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME, &objectName);
+
+            fprintf(stderr, "\t0x%X: type=%d, name=%d\n", attachment,
+                    objectType, objectName);
+
+            if (objectType == GL_TEXTURE) {
+                GLint width, height, internalFormat;
+                glBindTexture(GL_TEXTURE_2D, objectName);
+                glGetTexLevelParameteriv(GL_TEXTURE_2D, 0, GL_TEXTURE_WIDTH,
+                                         &width);
+                glGetTexLevelParameteriv(GL_TEXTURE_2D, 0, GL_TEXTURE_HEIGHT,
+                                         &height);
+                glGetTexLevelParameteriv(GL_TEXTURE_2D, 0,
+                                         GL_TEXTURE_INTERNAL_FORMAT,
+                                         &internalFormat);
+                fprintf(stderr, "\t\tTexture: %dx%d, format=0x%X\n", width,
+                        height, internalFormat);
+            }
+        }
+    }
+
+    assert(!"OpenGL GL_FRAMEBUFFER status != GL_FRAMEBUFFER_COMPLETE");
+}
+
+#endif // ifdef XEMU_DEBUG_BUILD

hw/xbox/nv2a/debug_gl.h

@@ -1,9 +1,30 @@
+/*
+ * Geforce NV2A PGRAPH OpenGL Renderer debug routines
+ *
+ * Copyright (c) 2025 Matt Borgerson
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, see <http://www.gnu.org/licenses/>.
+ */
+
 #ifndef XEMU_HW_XBOX_NV2A_DEBUG_GL_H_
 #define XEMU_HW_XBOX_NV2A_DEBUG_GL_H_
 
 #ifdef XEMU_DEBUG_BUILD
 
-#define ASSERT_NO_GL_ERROR()                                                 \
+#include <epoxy/gl.h>
+
+#define ASSERT_NO_GL_ERROR()                                             \
     do {                                                                 \
         GLenum error = glGetError();                                     \
         if (error != GL_NO_ERROR) {                                      \
@@ -13,18 +34,15 @@
         }                                                                \
     } while (0)
 
-#define ASSERT_FRAMEBUFFER_COMPLETE()                                         \
-    do {                                                                     \
-        GLenum status = glCheckFramebufferStatus(GL_FRAMEBUFFER);            \
-        if (status != GL_FRAMEBUFFER_COMPLETE) {                             \
-            fprintf(stderr,                                                  \
-                    "OpenGL framebuffer status: 0x%X (%d) != "               \
-                    "GL_FRAMEBUFFER_COMPLETE at %s:%d\n",                    \
-                    status, status, __FILE__, __LINE__);                     \
-            assert(                                                          \
-                !"OpenGL GL_FRAMEBUFFER status != GL_FRAMEBUFFER_COMPLETE"); \
-        }                                                                    \
-    } while (0)
+#if defined(__clang__) && defined(__FILE_NAME__)
+#define ASSERT_FRAMEBUFFER_COMPLETE() \
+    gl_debug_assert_framebuffer_complete(__FILE_NAME__, __LINE__)
+#else
+#define ASSERT_FRAMEBUFFER_COMPLETE() \
+    gl_debug_assert_framebuffer_complete(__FILE__, __LINE__)
+#endif
+
+void gl_debug_assert_framebuffer_complete(const char *source_file, int line);
 
 #else
 

hw/xbox/nv2a/meson.build

@@ -1,4 +1,5 @@
 specific_ss.add(files(
+	'debug.c',
 	'nv2a.c',
 	'pbus.c',
 	'pcrtc.c',