Skip to content

Commit 4c67b99

Browse files
committed
Update pylint and test settings
1 parent 620f334 commit 4c67b99

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

.pylintrc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,9 @@ disable=print-statement,
145145
no-member,
146146
arguments-differ,
147147
ungrouped-imports,
148-
bad-continuation
148+
bad-continuation,
149+
redefined-builtin,
150+
raise-missing-from
149151

150152
# Enable the message, report, category or checker with the given id(s). You can
151153
# either give multiple identifier separated by comma (,) or put this option
@@ -536,7 +538,7 @@ max-attributes=10
536538
max-bool-expr=5
537539

538540
# Maximum number of branch for function / method body.
539-
max-branches=12
541+
max-branches=15
540542

541543
# Maximum number of locals for function / method body.
542544
max-locals=20

tests/run.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
#!/usr/bin/env python
22

33
import argparse
4-
import multiprocessing
54
import os
65
import sys
76

@@ -42,14 +41,14 @@
4241
"--flake8",
4342
"--black",
4443
"--pylint",
45-
"--pylint-jobs={}".format(multiprocessing.cpu_count()),
4644
"--pylint-rcfile={}".format(os.path.join(root_dir, ".pylintrc")),
4745
]
4846
cmd.extend(lint_args)
4947

5048
if args.coverage:
5149
coverage_args = [
5250
"--cov=aws_gate",
51+
"--cov-fail-under=100",
5352
"--cov-report=term-missing",
5453
"--cov-report=xml:reports/coverage.xml",
5554
"--cov-report=html:reports/coverage/aws-gate",

tests/unit/test_utils.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,14 @@
11
import errno
22
import os
3-
import pytest
43
import subprocess
4+
from subprocess import PIPE
5+
6+
import pytest
7+
from botocore import credentials
8+
from botocore.exceptions import ClientError
9+
from hypothesis import given
10+
from hypothesis.strategies import lists, text
11+
512
from aws_gate import __version__
613
from aws_gate.constants import DEFAULT_GATE_BIN_PATH
714
from aws_gate.exceptions import AWSConnectionError
@@ -17,11 +24,6 @@
1724
fetch_instance_details_from_config,
1825
get_instance_details,
1926
)
20-
from botocore import credentials
21-
from botocore.exceptions import ClientError
22-
from hypothesis import given
23-
from hypothesis.strategies import lists, text
24-
from subprocess import PIPE
2527

2628

2729
# pylint: disable=too-few-public-methods

0 commit comments

Comments
 (0)