ACC-2100 Return 501 Not implemented when following unidirectional *-to-many relation

Author: NielsCW

contentgrid-appserver-rest/src/main/java/com/contentgrid/appserver/rest/property/handler/XToManyRelationRequestHandler.java

@@ -72,10 +72,17 @@ protected ResponseEntity<Object> getProperty(
         var targetPathSegment = property.getTargetEndPoint().getEntity().getPathSegment();
         datamodelApi.findById(application, property.getSourceEndPoint().getEntity(), instanceId)
                 .orElseThrow(() -> new ResponseStatusException(HttpStatus.NOT_FOUND, "Entity with id %s not found".formatted(instanceId)));
-        var redirectUrl = linkTo(methodOn(EntityRestController.class).listEntity(application, targetPathSegment, 0,
-                Map.of(property.getTargetEndPoint().getName().getValue(), instanceId.toString()))).toUri(); // TODO: use RelationSearchFilter
-
-        return ResponseEntity.status(HttpStatus.FOUND).location(redirectUrl).build();
+        // TODO: use FilterName of relation
+        var filterName = property.getTargetEndPoint().getName();
+        if (filterName != null) {
+            var redirectUrl = linkTo(methodOn(EntityRestController.class)
+                    .listEntity(application, targetPathSegment, 0, Map.of(filterName.getValue(), instanceId.toString())))
+                    .toUri();
+
+            return ResponseEntity.status(HttpStatus.FOUND).location(redirectUrl).build();
+        } else {
+            throw new ResponseStatusException(HttpStatus.NOT_IMPLEMENTED, "Following an unidirectional *-to-many relation not implemented.");
+        }
     }
 
     @Override

contentgrid-appserver-rest/src/test/java/com/contentgrid/appserver/rest/property/handler/RelationRequestHandlerTest.java

@@ -29,6 +29,7 @@
 import java.util.UUID;
 import java.util.stream.Stream;
 import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
@@ -134,7 +135,7 @@ void followManyToOneRelation() throws Exception {
         @Test
         void followOneToManyRelation() throws Exception {
             Mockito.doReturn(Optional.of(EntityData.builder()
-                            .name(EntityName.of("person"))
+                            .name(TestApplication.PERSON.getName())
                             .id(PERSON_ID)
                             .build()))
                     .when(datamodelApi)
@@ -152,7 +153,7 @@ void followOneToManyRelation() throws Exception {
         @Test
         void followManyToManyRelation() throws Exception {
             Mockito.doReturn(Optional.of(EntityData.builder()
-                            .name(EntityName.of("product"))
+                            .name(TestApplication.PRODUCT.getName())
                             .id(PRODUCT_ID)
                             .build()))
                     .when(datamodelApi)
@@ -167,6 +168,25 @@ void followManyToManyRelation() throws Exception {
                     .findById(TestApplication.APPLICATION, TestApplication.PRODUCT, PRODUCT_ID);
         }
 
+        @Test
+        @Disabled("Following unidirectional *-to-many relations not implemented")
+        void followUnidirectionalToManyRelation() throws Exception {
+            Mockito.doReturn(Optional.of(EntityData.builder()
+                    .name(TestApplication.PERSON.getName())
+                    .id(PERSON_ID)
+                    .build()))
+                    .when(datamodelApi)
+                    .findById(TestApplication.APPLICATION, TestApplication.PERSON, PERSON_ID);
+
+            mockMvc.perform(get("/persons/{sourceId}/friends", PERSON_ID))
+                    .andExpect(status().isFound())
+                    .andExpect(header().string(HttpHeaders.LOCATION,
+                            "http://localhost/persons?page=0&_internal_person__friends=%s".formatted(PERSON_ID))); // TODO: change url
+
+            Mockito.verify(datamodelApi)
+                    .findById(TestApplication.APPLICATION, TestApplication.PERSON, PERSON_ID);
+        }
+
         @Test
         void followOneToManyRelationItem() throws Exception {
             var targetId = EntityId.of(UUID.randomUUID());