Remove on flags on remove_residuals

Author: xvw

lib/core/action.ml

@@ -230,7 +230,8 @@ let store_cache ?(on = `Target) path cache =
   let* () = Eff.write_file ~on path sexp_str in
   Eff.log ~src:Eff.yocaml_log_src ~level:`Debug @@ Lexicon.cache_stored path
 
-let remove_residuals ?(on = `Target) ~target cache =
+let remove_residuals ~target cache =
+  let on = `Target in
   let open Eff.Syntax in
   let trace = Cache.trace cache in
   let* () =

lib/core/action.mli

@@ -32,9 +32,9 @@ type t = Cache.t -> Cache.t Eff.t
     production phases, an action is a function that takes a cache and returns
     the modified cache, wrapped in an effect. *)
 
-val remove_residuals : ?on:Eff.filesystem -> target:Path.t -> t
-(** [remove_residuals ?on ~target] deletes files that were not created by any of
-    the actions performed. *)
+val remove_residuals : target:Path.t -> t
+(** [remove_residuals ~target] deletes files that were not created by any of the
+    actions performed. *)
 
 val restore_cache : ?on:Eff.filesystem -> Path.t -> Cache.t Eff.t
 (** [restore_cache ?on path] Reads or initiates the cache in a given [path]. *)

test/e2e/bin/gen_residuals.ml

@@ -9,7 +9,7 @@ let program () =
     (Yocaml.Batch.iter_files
        (Yocaml.Path.rel [ "residuals" ])
        (Yocaml.Action.copy_file ~into:target)
-    >=> Yocaml.Action.remove_residuals ~on ~target)
+    >=> Yocaml.Action.remove_residuals ~target)
 
 let () =
   let () = Array.iter print_endline Sys.argv in