Merge pull request #11 from ckyoung/main

Fix: make sure to use hyphen on lang attribute

Author: xiCO2k

src/index.ts

@@ -88,7 +88,8 @@ export function getActiveLanguage(): string {
  */
 function setLanguage({ lang, messages }: LanguageInterface): string {
   if (! isServer) {
-    document.querySelector('html').setAttribute('lang', lang)
+    // When setting the HTML lang attribute, hyphen must be use instead of underscore.
+    document.documentElement.setAttribute("lang", lang.replace('_', '-'));
   }
 
   options.lang = lang;

src/utils/get-plural-index.ts

@@ -6,7 +6,7 @@
  * Copyright (c) 2005-2010 - Zend Technologies USA Inc. (http://www.zend.com)
  */
 export function getPluralIndex(lang: string, number: number): number {
-  switch (lang) {
+  switch (lang.replace('_', '-')) {
     case 'az':
     case 'az-AZ':
     case 'bo':

test/fixtures/lang/zh_TW.json

@@ -0,0 +1,3 @@
+{
+    "Welcome!": "歡迎"
+}

test/translate.test.ts

@@ -72,3 +72,16 @@ it('returns the active lang', async () => {
   await loadLanguageAsync('en');
   expect(getActiveLanguage()).toBe('en');
 })
+
+it('translates to a underscore/dash language', async () => {
+  await global.mountPlugin();
+
+  await loadLanguageAsync('zh_TW');
+  expect(getActiveLanguage()).toBe('zh_TW');
+
+  await loadLanguageAsync('en');
+
+  await loadLanguageAsync('zh-TW');
+
+  expect(getActiveLanguage()).toBe('zh_TW');
+})