Fix: make sure to use hyphen on lang attribute

ckyoung · ckyoung · commit e1a531409478 · 2022-01-26T22:43:09.000+08:00
diff --git a/src/index.ts b/src/index.ts
@@ -88,7 +88,8 @@ export function getActiveLanguage(): string {
  */
 function setLanguage({ lang, messages }: LanguageInterface): string {
   if (! isServer) {
-    document.querySelector('html').setAttribute('lang', lang)
+    // When setting the HTML lang attribute, hyphen must be use instead of underscore.
+    document.documentElement.setAttribute("lang", lang.replace('_', '-'));
   }
 
   options.lang = lang;

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,8 @@ export function getActiveLanguage(): string {`
`88`	`88`	`*/`
`89`	`89`	`function setLanguage({ lang, messages }: LanguageInterface): string {`
`90`	`90`	`if (! isServer) {`
`91`		`- document.querySelector('html').setAttribute('lang', lang)`
	`91`	`+ // When setting the HTML lang attribute, hyphen must be use instead of underscore.`
	`92`	`+ document.documentElement.setAttribute("lang", lang.replace('_', '-'));`
`92`	`93`	`}`
`93`	`94`
`94`	`95`	`options.lang = lang;`