Skip to content

Commit 42552a0

Browse files
authored
added missing ContextType on interface/union resolvers (dotansimha#4412)
1 parent 31fe631 commit 42552a0

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

packages/plugins/flow/resolvers/tests/__snapshots__/flow-resolvers.spec.ts.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,9 +143,9 @@ export type Resolvers<ContextType = any> = {
143143
MyOtherType?: MyOtherTypeResolvers<ContextType>,
144144
Query?: QueryResolvers<ContextType>,
145145
Subscription?: SubscriptionResolvers<ContextType>,
146-
Node?: NodeResolvers<>,
146+
Node?: NodeResolvers<ContextType>,
147147
SomeNode?: SomeNodeResolvers<ContextType>,
148-
MyUnion?: MyUnionResolvers<>,
148+
MyUnion?: MyUnionResolvers<ContextType>,
149149
MyScalar?: GraphQLScalarType<>,
150150
};
151151

packages/plugins/other/visitor-plugin-common/src/base-resolvers-visitor.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1027,7 +1027,7 @@ export type IDirectiveResolvers${contextType} = ${name}<ContextType>;`
10271027
.map(f => `'${f}'`)
10281028
.join(' | ');
10291029

1030-
this._collectedResolvers[node.name as any] = name;
1030+
this._collectedResolvers[node.name as any] = name + '<ContextType>';
10311031
const parentType = this.getParentTypeToUse((node.name as any) as string);
10321032

10331033
return new DeclarationBlock(this._declarationBlockConfig)
@@ -1164,7 +1164,7 @@ export type IDirectiveResolvers${contextType} = ${name}<ContextType>;`
11641164
const allTypesMap = this._schema.getTypeMap();
11651165
const implementingTypes: string[] = [];
11661166

1167-
this._collectedResolvers[node.name as any] = name;
1167+
this._collectedResolvers[node.name as any] = name + '<ContextType>';
11681168

11691169
for (const graphqlType of Object.values(allTypesMap)) {
11701170
if (graphqlType instanceof GraphQLObjectType) {

packages/plugins/typescript/resolvers/tests/__snapshots__/ts-resolvers.spec.ts.snap

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -200,9 +200,9 @@ export type Resolvers<ContextType = any> = ResolversObject<{
200200
MyOtherType?: MyOtherTypeResolvers<ContextType>;
201201
Query?: QueryResolvers<ContextType>;
202202
Subscription?: SubscriptionResolvers<ContextType>;
203-
Node?: NodeResolvers;
203+
Node?: NodeResolvers<ContextType>;
204204
SomeNode?: SomeNodeResolvers<ContextType>;
205-
MyUnion?: MyUnionResolvers;
205+
MyUnion?: MyUnionResolvers<ContextType>;
206206
MyScalar?: GraphQLScalarType;
207207
}>;
208208
@@ -380,9 +380,9 @@ export type Resolvers<ContextType = any> = ResolversObject<{
380380
MyOtherType?: MyOtherTypeResolvers<ContextType>;
381381
Query?: QueryResolvers<ContextType>;
382382
Subscription?: SubscriptionResolvers<ContextType>;
383-
Node?: NodeResolvers;
383+
Node?: NodeResolvers<ContextType>;
384384
SomeNode?: SomeNodeResolvers<ContextType>;
385-
MyUnion?: MyUnionResolvers;
385+
MyUnion?: MyUnionResolvers<ContextType>;
386386
MyScalar?: GraphQLScalarType;
387387
}>;
388388
@@ -604,9 +604,9 @@ export type Resolvers<ContextType = any> = ResolversObject<{
604604
MyOtherType?: MyOtherTypeResolvers<ContextType>;
605605
Query?: QueryResolvers<ContextType>;
606606
Subscription?: SubscriptionResolvers<ContextType>;
607-
Node?: NodeResolvers;
607+
Node?: NodeResolvers<ContextType>;
608608
SomeNode?: SomeNodeResolvers<ContextType>;
609-
MyUnion?: MyUnionResolvers;
609+
MyUnion?: MyUnionResolvers<ContextType>;
610610
MyScalar?: GraphQLScalarType;
611611
}>;
612612

packages/plugins/typescript/resolvers/tests/ts-resolvers.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1211,8 +1211,8 @@ export type ResolverFn<TResult, TParent, TContext, TArgs> = (
12111211
export type Resolvers<ContextType = any> = {
12121212
Date?: GraphQLScalarType;
12131213
Query?: QueryResolvers<ContextType>;
1214-
Node?: NodeResolvers;
1215-
PostOrUser?: PostOrUserResolvers;
1214+
Node?: NodeResolvers<ContextType>;
1215+
PostOrUser?: PostOrUserResolvers<ContextType>;
12161216
Post?: PostResolvers<ContextType>;
12171217
User?: UserResolvers<ContextType>;
12181218
};

0 commit comments

Comments
 (0)