cobalt/test: Ensure pref directories exist and skip clean shutdown steps (youtube#9293)

This fixes a DCHECK failure in CleanExitBeacon during browser tests.

- Ensure parent directories for experiment and metrics configs exist
before creating JsonPrefStore, allowing it to initialize synchronously.
- Call CleanExitBeacon::SkipCleanShutdownStepsForTesting() in
ContentBrowserTest::SetUp() to prevent unnecessary clean shutdown checks
and updates during tests.

Test: `$out_dir/bin/run_cobalt_browsertests
--gtest_filter=FontMetricsBrowserTest.*`
Bug: 431884442

Author: Awallky

cobalt/browser/global_features.cc

@@ -15,6 +15,7 @@
 #include "cobalt/browser/global_features.h"
 
 #include "base/feature_list.h"
+#include "base/files/file_util.h"
 #include "base/no_destructor.h"
 #include "base/path_service.h"
 #include "base/time/time.h"
@@ -93,9 +94,8 @@ void GlobalFeatures::CreateExperimentConfig() {
 
   RegisterPrefs(pref_registry.get());
 
-  base::FilePath path;
-  CHECK(base::PathService::Get(base::DIR_CACHE, &path));
-  path = path.Append(kExperimentConfigFilename);
+  base::FilePath path =
+      GetPrefFilePath(kExperimentConfigFilename, "experiment config");
 
   PrefServiceFactory pref_service_factory;
   pref_service_factory.set_user_prefs(
@@ -127,9 +127,8 @@ void GlobalFeatures::CreateMetricsLocalState() {
   // call, etc., this is the setting that's overridden).
   pref_registry->RegisterBooleanPref(metrics::prefs::kMetricsReportingEnabled,
                                      false);
-  base::FilePath path;
-  CHECK(base::PathService::Get(base::DIR_CACHE, &path));
-  path = path.Append(kMetricsConfigFilename);
+  base::FilePath path =
+      GetPrefFilePath(kMetricsConfigFilename, "metrics config");
 
   PrefServiceFactory pref_service_factory;
   // TODO(b/397929564): Investigate using a Chrome's memory-mapped file store
@@ -155,6 +154,19 @@ void GlobalFeatures::InitializeActiveConfigData() {
           : kExperimentConfigActiveConfigData);
 }
 
+base::FilePath GlobalFeatures::GetPrefFilePath(
+    const base::FilePath::CharType filename[],
+    const char* label) {
+  base::FilePath path;
+  CHECK(base::PathService::Get(base::DIR_CACHE, &path));
+  path = path.Append(filename);
+
+  CHECK(base::CreateDirectory(path.DirName()))
+      << "Failed to create directory for " << label << ": "
+      << path.DirName().value();
+  return path;
+}
+
 void GlobalFeatures::Shutdown() {
   metrics::MetricsService* metrics = metrics_service();
   if (metrics) {

cobalt/browser/global_features.h

@@ -93,6 +93,11 @@ class GlobalFeatures {
   // Modified config data should only apply to the next app life cycle.
   void InitializeActiveConfigData();
 
+  // Construct a FilePath for a pref file and ensure its parent directory
+  // exists.
+  base::FilePath GetPrefFilePath(const base::FilePath::CharType filename[],
+                                 const char* label);
+
   std::unique_ptr<base::FeatureList::Accessor> accessor_;
 
   // Finch config/state.

cobalt/testing/browser_tests/content_browser_test.cc

@@ -29,6 +29,7 @@
 #include "cobalt/shell/common/shell_switches.h"
 #include "cobalt/testing/browser_tests/browser/test_shell.h"
 #include "cobalt/testing/browser_tests/content_browser_test_content_browser_client.h"
+#include "components/metrics/clean_exit_beacon.h"
 #include "content/browser/renderer_host/render_frame_host_impl.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/common/content_paths.h"
@@ -99,6 +100,7 @@ void ContentBrowserTest::SetUpCommandLine(base::CommandLine* command_line) {
 }
 
 void ContentBrowserTest::SetUp() {
+  metrics::CleanExitBeacon::SkipCleanShutdownStepsForTesting();
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   SetUpCommandLine(command_line);