Skip to content

Commit cf877b5

Browse files
xiaoxmengfacebook-github-bot
authored andcommitted
refactor: Trivial code cleanup in Field reader (facebookincubator#497)
Summary: This change updates `FieldReader` and `FieldReaderFactory` classes to store `velox::memory::MemoryPool` as a pointer (`pool_`) rather than a reference. This provides more flexibility in how the pool is managed and passed around, particularly when used with various Velox APIs that expect pool pointers. The change also includes several code quality improvements: - Removed `FOLLY_NULLABLE` annotations from function signatures - Changed `VELOX_CHECK_NOT_NULL` to `NIMBLE_CHECK_NOT_NULL` for consistency with the nimble codebase - Converted comments to use `///` doc-comment style in the header - Added `const` qualifiers to local variables where appropriate - Changed struct member initialization from `= 0` to `{0}` for consistency Reviewed By: srsuryadev Differential Revision: D93515000
1 parent fec5de5 commit cf877b5

File tree

4 files changed

+118
-124
lines changed

4 files changed

+118
-124
lines changed

0 commit comments

Comments
 (0)