fix(ui): set maximum size policy for translate box (#2694)

* fix(ui): set maximum size policy for translate box

Author: xiaoyifang

src/article_maker.cc

@@ -857,7 +857,7 @@ void ArticleRequest::compoundSearchNextStep( bool lastSearchSucceeded )
         // Append the beginning
         footer += R"(<div class="gdstemmedsuggestion"><span class="gdstemmedsuggestion_head">)"
           + Html::escape( tr( "Compound expressions: " ).toUtf8().data() )
-          + "</span><span class=\"gdstemmedsuggestion_body\">";
+          + "</span><div class=\"gdstemmedsuggestion_body\">";
 
         firstCompoundWasFound = true;
       }
@@ -877,14 +877,13 @@ void ArticleRequest::compoundSearchNextStep( bool lastSearchSucceeded )
       // The last word was the last possible to start from
 
       if ( firstCompoundWasFound ) {
-        footer += "</span>";
+        footer += "</div>";
       }
 
       // Now add links to all the individual words. They conclude the result.
 
       footer += R"(<div class="gdstemmedsuggestion"><span class="gdstemmedsuggestion_head">)"
-        + Html::escape( tr( "Individual words: " ).toUtf8().data() )
-        + "</span><span class=\"gdstemmedsuggestion_body\"";
+        + Html::escape( tr( "Individual words: " ).toUtf8().data() ) + "</span><div class=\"gdstemmedsuggestion_body\"";
       if ( splittedWords.first[ 0 ].isRightToLeft() ) {
         footer += " dir=\"rtl\"";
       }
@@ -897,7 +896,7 @@ void ArticleRequest::compoundSearchNextStep( bool lastSearchSucceeded )
         footer += escapeSpacing( splittedWords.second[ x + 1 ] );
       }
 
-      footer += "</span>";
+      footer += "</div>";
 
       footer += "</body></html>";
 

src/stylesheets/article-style.css

@@ -586,11 +586,18 @@ div.xdxf {
 }
 
 .gdstemmedsuggestion_head {
-  margin-left: 11px;
+  margin-left: 12px;
   font-style: italic;
 }
 
 .gdstemmedsuggestion_body {
+  display: block;
+  width: 100%;
+  margin: 12px;
+
+  box-sizing: border-box;
+  word-break: break-word;
+  line-height: 1.5;
 }
 
 /************* Dictd articles *****************/

src/ui/scanpopup.cc

@@ -84,7 +84,7 @@ ScanPopup::ScanPopup( QWidget * parent,
   foundBar->setAllowedAreas( Qt::LeftToolBarArea | Qt::RightToolBarArea );
 
   // UI style
-  searchBar->setSizePolicy( QSizePolicy::MinimumExpanding, QSizePolicy::Maximum );
+  searchBar->setSizePolicy( QSizePolicy::Preferred, QSizePolicy::Maximum );
   searchBar->setMovable( false );
   toolBar->setFloatable( false );
   dictionaryBar.setFloatable( false );
@@ -111,6 +111,7 @@ ScanPopup::ScanPopup( QWidget * parent,
   tabWidget = new MainTabWidget( this );
   tabWidget->setTabsClosable( true );
   tabWidget->setHideSingleTab( true );
+  tabWidget->setSizePolicy( QSizePolicy::Preferred, QSizePolicy::Expanding );
   connect( tabWidget, &QTabWidget::tabCloseRequested, this, [ this ]( int index ) {
     if ( index > 0 ) {
       auto widget = tabWidget->widget( index );
@@ -133,6 +134,16 @@ ScanPopup::ScanPopup( QWidget * parent,
 
   resize( 247, 400 );
 
+  // Set maximum width based on screen size
+  QScreen * screen = QGuiApplication::primaryScreen();
+  if ( screen ) {
+    int maxWidth = screen->availableGeometry().width() * 0.8; // 80% of screen width
+    setMaximumWidth( maxWidth );
+  }
+
+  translateBox->setMaximumWidth( 200 );
+  groupList->setMaximumWidth( 200 );
+
   connect( definition, &ArticleView::inspectSignal, this, &ScanPopup::inspectElementWhenPinned );
   connect( definition, &ArticleView::forceAddWordToHistory, this, &ScanPopup::forceAddWordToHistory );
   connect( this, &ScanPopup::closeMenu, definition, &ArticleView::closePopupMenu );
@@ -647,7 +658,7 @@ void ScanPopup::engagePopup( bool forcePopup, bool giveFocus )
   showTranslationFor( pendingWord );
 }
 
-QString ScanPopup::elideInputWord()
+QString ScanPopup::elideInputWord() const
 {
   return pendingWord.size() > 32 ? pendingWord.mid( 0, 32 ) + "..." : pendingWord;
 }
@@ -729,7 +740,7 @@ void ScanPopup::showTranslationFor( const QString & word ) const
   definition->showDefinition( word, groupId );
   definition->focus();
   // definition is the first tab
-  tabWidget->setTabText( 0, word );
+  tabWidget->setTabText( 0, elideInputWord() );
 }
 
 const vector< sptr< Dictionary::Class > > & ScanPopup::getActiveDicts()

src/ui/scanpopup.hh

@@ -185,7 +185,7 @@ private:
   virtual void moveEvent( QMoveEvent * );
 
   /// Returns inputWord, chopped with appended ... if it's too long/
-  QString elideInputWord();
+  QString elideInputWord() const;
 
   void updateBackForwardButtons() const;
 

src/ui/translatebox.cc

@@ -19,7 +19,7 @@ TranslateBox::TranslateBox( QWidget * parent ):
 {
   completer = new QCompleter( words, this );
   resize( 200, 90 );
-  QSizePolicy sizePolicy( QSizePolicy::Expanding, QSizePolicy::Preferred );
+  QSizePolicy sizePolicy( QSizePolicy::Maximum, QSizePolicy::Preferred );
   setSizePolicy( sizePolicy );
 
   setFocusProxy( translate_line );