fix #4, properly close unused resp body

xinsnake · xinsnake · commit 366760120fe0 · 2017-07-28T22:50:46.000+10:00
diff --git a/digest_auth_client.go b/digest_auth_client.go
@@ -89,6 +89,7 @@ func (dr *DigestRequest) Execute() (resp *http.Response, err error) {
 		return dr.executeNewDigest(resp)
 	}
 
+	// return the resp to user to handle resp.body.Close()
 	return resp, nil
 }
 
@@ -99,6 +100,9 @@ func (dr *DigestRequest) executeNewDigest(resp *http.Response) (resp2 *http.Resp
 		waString string
 	)
 
+	// body not required for authentication, closing
+	resp.Body.Close()
+
 	if waString = resp.Header.Get("WWW-Authenticate"); waString == "" {
 		return nil, fmt.Errorf("failed to get WWW-Authenticate header, please check your server configuration")
 	}

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,7 @@ func (dr DigestRequest) Execute() (resp http.Response, err error) {`
`89`	`89`	`return dr.executeNewDigest(resp)`
`90`	`90`	`}`
`91`	`91`
	`92`	`+ // return the resp to user to handle resp.body.Close()`
`92`	`93`	`return resp, nil`
`93`	`94`	`}`
`94`	`95`
`@@ -99,6 +100,9 @@ func (dr DigestRequest) executeNewDigest(resp http.Response) (resp2 *http.Resp`
`99`	`100`	`waString string`
`100`	`101`	`)`
`101`	`102`
	`103`	`+ // body not required for authentication, closing`
	`104`	`+ resp.Body.Close()`
	`105`	`+`
`102`	`106`	`if waString = resp.Header.Get("WWW-Authenticate"); waString == "" {`
`103`	`107`	`return nil, fmt.Errorf("failed to get WWW-Authenticate header, please check your server configuration")`
`104`	`108`	`}`