Skip to content

Commit 31a751e

Browse files
Hardcode84xintin
authored andcommitted
Update IREE deps (iree-org#880)
IREE deps were previously pinned to `3.5.0rc20250516` as `3.5.0rc20250517` introduced regressions. There were 2 issues: * Shared memory handling changes in IREE were causing the crash as we are were trying to allocate too much shared mem. IREE doesn't use dynamic shared mem anymore so we need to pass 0 now in wave runtime (test iree-org#855). * 40% perf regression in extend attention caused by some changes in llvm AMDGPU backend. These seems to went away after the recent IREE llvm intergrate. I didn't dig too deep on them but I suspect llvm/llvm-project#137807 was the issue (fixed by llvm/llvm-project#140921). --------- Signed-off-by: Ivan Butygin <[email protected]> Signed-off-by: xintin <[email protected]>
1 parent 672b569 commit 31a751e

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

iree/turbine/kernel/wave/runtime/runtime.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ static int launch(const KernelLaunchInfo &info, const Int64Vector &tensors,
8888
HIP_LAUNCH_PARAM_END};
8989

9090
HIP_CHECK_RETURN(hipModuleLaunchKernel(function, info.gridX, info.gridY, info.gridZ,
91-
info.blockX, info.blockY, info.blockZ, info.sharedMemoryBytes,
91+
info.blockX, info.blockY, info.blockZ, 0,
9292
stream, nullptr, (void **)&hipLaunchParams));
9393

9494
return hipSuccess;

lit_tests/kernel/wave/casting.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def test(
7676
a_reg = tkw.cast(a_reg, tkl.f16)
7777
tkw.write(a_reg, b, elements_per_thread=16)
7878

79-
options = get_wave_compile_options(canonicalize=True)
79+
options = get_wave_compile_options(canonicalize=False)
8080
test = wave_compile(options, test)
8181
print(test.asm)
8282

requirements-iree-pinned.txt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,5 @@
77
# Uncomment to skip versions from PyPI (so _only_ nightly versions).
88
# --no-index
99

10-
# TODO: We have a pretty bad regression in Wave between 3.5.0rc20250516 and
11-
# 3.5.0rc20250517. I'm locking to 3.5.0rc20250516 until further investigation.
12-
iree-base-compiler==3.5.0rc20250516
13-
iree-base-runtime==3.5.0rc20250516
10+
iree-base-compiler==3.5.0rc20250530
11+
iree-base-runtime==3.5.0rc20250530

0 commit comments

Comments
 (0)