Update: Updated default values for Access-Control-Expose-Headers:, and Access-Control-Allow-Headers:

ph3-der-loewe · ph3-der-loewe · commit b82ea89a2ef9 · 2022-03-12T13:39:44.000Z
diff --git a/src/util.c b/src/util.c
@@ -644,12 +644,13 @@ static inline void   _build_headers_loop(char **ret, size_t *len, const ice_conf
                                     value = allow;
                                 }
                             } else if (strcasecmp(name, "Access-Control-Expose-Headers") == 0) {
-                                value = "icy-br, icy-description, icy-genre, icy-name, icy-pub, icy-url";
+                                value = "content-range, icy-br, icy-description, icy-genre, icy-name, icy-pub, icy-url";
                             } else if (strcasecmp(name, "Access-Control-Max-Age") == 0) {
                                 value = "300"; /* 300s = 5 minutes */
+                            } else if (strcasecmp(name, "Access-Control-Allow-Headers") == 0) {
+                                value = "range, if-range";
                             /* No default (yet)
                              * } else if (strcasecmp(name, "Access-Control-Allow-Credentials") == 0) {
-                             * } else if (strcasecmp(name, "Access-Control-Allow-Headers") == 0) {
                              */
                             }
                         }

Original file line number	Diff line number	Diff line change
`@@ -644,12 +644,13 @@ static inline void _build_headers_loop(char *ret, size_t len, const ice_conf`
`644`	`644`	`value = allow;`
`645`	`645`	`}`
`646`	`646`	`} else if (strcasecmp(name, "Access-Control-Expose-Headers") == 0) {`
`647`		`- value = "icy-br, icy-description, icy-genre, icy-name, icy-pub, icy-url";`
	`647`	`+ value = "content-range, icy-br, icy-description, icy-genre, icy-name, icy-pub, icy-url";`
`648`	`648`	`} else if (strcasecmp(name, "Access-Control-Max-Age") == 0) {`
`649`	`649`	`value = "300"; /* 300s = 5 minutes */`
	`650`	`+ } else if (strcasecmp(name, "Access-Control-Allow-Headers") == 0) {`
	`651`	`+ value = "range, if-range";`
`650`	`652`	`/* No default (yet)`
`651`	`653`	`* } else if (strcasecmp(name, "Access-Control-Allow-Credentials") == 0) {`
`652`		`- * } else if (strcasecmp(name, "Access-Control-Allow-Headers") == 0) {`
`653`	`654`	`*/`
`654`	`655`	`}`
`655`	`656`	`}`