Skip to content

Commit b3ed2bb

Browse files
committed
github actions: Update to Android NDK 27c
Github actions continuous integration builds were failing for Android targets because the specified `android.toolchain.cmake` file was not available on the specified runner. Github documents the runner images has having the lastest stable NDK as well as the previous two LTS releases. We were specifying 25.2.9519653, first released in 2022. https://github.com/actions/runner-images/blob/releases/ubuntu24/20250629/README.md#software-and-image-support Instead specify r27c, released in 2024 and still the current LTS release. https://developer.android.com/ndk/downloads/revision_history Also move the version to a shared ENV variable for easier updating. Signed-off-by: Jean-Marc Valin <[email protected]>
1 parent 3252cdd commit b3ed2bb

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

.github/workflows/cmake.yml

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ name: CMake
22

33
on: [push, pull_request]
44

5+
env:
6+
NDK_VERSION: 27.2.12479018
7+
58
jobs:
69
CMakeVersionTest:
710
name: Test build with CMake 3.16.0
@@ -62,26 +65,26 @@ jobs:
6265
name: "Android/So/ARMv8/Release",
6366
os: ubuntu-latest,
6467
config: Release,
65-
args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/25.2.9519653/build/cmake/android.toolchain.cmake -DANDROID_ABI=arm64-v8a -DBUILD_SHARED_LIBS=ON"
68+
args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/${NDK_VERSION}/build/cmake/android.toolchain.cmake -DANDROID_ABI=arm64-v8a -DBUILD_SHARED_LIBS=ON"
6669
}
6770
# TODO: Android ARMv7
6871
# - {
6972
# name: "Android/So/ARMv7/Release",
7073
# os: ubuntu-latest,
7174
# config: Release,
72-
# args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/25.2.9519653/build/cmake/android.toolchain.cmake -DANDROID_ABI=armeabi-v7a -DBUILD_SHARED_LIBS=ON"
75+
# args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/${NDK_VERSION}/build/cmake/android.toolchain.cmake -DANDROID_ABI=armeabi-v7a -DBUILD_SHARED_LIBS=ON"
7376
# }
7477
- {
7578
name: "Android/So/X86/Release",
7679
os: ubuntu-latest,
7780
config: Release,
78-
args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/25.2.9519653/build/cmake/android.toolchain.cmake -DANDROID_ABI=x86 -DBUILD_SHARED_LIBS=ON"
81+
args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/${NDK_VERSION}/build/cmake/android.toolchain.cmake -DANDROID_ABI=x86 -DBUILD_SHARED_LIBS=ON"
7982
}
8083
- {
8184
name: "Android/So/X64/Release",
8285
os: ubuntu-latest,
8386
config: Release,
84-
args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/25.2.9519653/build/cmake/android.toolchain.cmake -DANDROID_ABI=x86_64 -DBUILD_SHARED_LIBS=ON"
87+
args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/${NDK_VERSION}/build/cmake/android.toolchain.cmake -DANDROID_ABI=x86_64 -DBUILD_SHARED_LIBS=ON"
8588
}
8689
- {
8790
name: "Windows/Dll/X86/Release",
@@ -174,26 +177,26 @@ jobs:
174177
name: "Android/Lib/ARMv8/Release",
175178
os: ubuntu-latest,
176179
config: Release,
177-
args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/25.2.9519653/build/cmake/android.toolchain.cmake -DANDROID_ABI=arm64-v8a"
180+
args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/${NDK_VERSION}/build/cmake/android.toolchain.cmake -DANDROID_ABI=arm64-v8a"
178181
}
179182
# TODO: Android ARMv7
180183
# - {
181184
# name: "Android/Lib/ARMv7/Release",
182185
# os: ubuntu-latest,
183186
# config: Release,
184-
# args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/25.2.9519653/build/cmake/android.toolchain.cmake -DANDROID_ABI=armeabi-v7a"
187+
# args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/${NDK_VERSION}/build/cmake/android.toolchain.cmake -DANDROID_ABI=armeabi-v7a"
185188
# }
186189
- {
187190
name: "Android/Lib/X86/Release",
188191
os: ubuntu-latest,
189192
config: Release,
190-
args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/25.2.9519653/build/cmake/android.toolchain.cmake -DANDROID_ABI=x86"
193+
args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/${NDK_VERSION}/build/cmake/android.toolchain.cmake -DANDROID_ABI=x86"
191194
}
192195
- {
193196
name: "Android/Lib/X64/Release",
194197
os: ubuntu-latest,
195198
config: Release,
196-
args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/25.2.9519653/build/cmake/android.toolchain.cmake -DANDROID_ABI=x86_64"
199+
args: "-DCMAKE_TOOLCHAIN_FILE=${ANDROID_HOME}/ndk/${NDK_VERSION}/build/cmake/android.toolchain.cmake -DANDROID_ABI=x86_64"
197200
}
198201
- {
199202
name: "CustomModes/Linux/Lib/X64/Release",

0 commit comments

Comments
 (0)