Skip to content

Commit 54380fd

Browse files
committed
fix all the issues
1 parent 8f9fdc1 commit 54380fd

File tree

5 files changed

+22
-24
lines changed

5 files changed

+22
-24
lines changed

.github/workflows/cd.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ jobs:
3939
env:
4040
BASE_PATH: "/QuickIME/"
4141

42+
- name: Create .nojekyll
43+
run: touch .output/public/.nojekyll
44+
4245
- name: upload artifact
4346
uses: actions/upload-pages-artifact@v3
4447
with:

app.config.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,6 @@ export default defineConfig({
88
server: {
99
baseURL: process.env.BASE_PATH,
1010
static: true,
11-
publicAssets: [
12-
{
13-
dir: "/QuickIME/public",
14-
},
15-
],
1611
prerender: {
1712
failOnError: true,
1813
routes: ["/"],

src/app.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
@font-face {
77
font-family: "Inter";
88
font-style: normal;
9-
src: url("/Inter-Regular.woff2") format("woff2");
9+
src: url("../Inter-Regular.woff2") format("woff2");
1010
}
1111

1212
:root {

src/entry-server.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export default createHandler(() => (
88
<head>
99
<meta charset="utf-8" />
1010
<meta name="viewport" content="width=device-width, initial-scale=1" />
11-
<link rel="icon" href="/favicon.ico" />
11+
<link rel="icon" href="favicon.ico" />
1212
{assets}
1313
</head>
1414
<body>

src/storage.ts

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
11
import type { Accessor, Setter } from "solid-js";
2-
import { createSignal, createEffect } from "solid-js";
2+
import { createSignal, createEffect, onMount, on } from "solid-js";
33

4-
export function createStorageSignal<T>(
5-
key: string,
6-
defaultValue: T,
7-
): [Accessor<T>, Setter<T>] {
8-
const initial = ((): T => {
4+
export function createStorageSignal<T>(key: string, defaultValue: T): [Accessor<T>, Setter<T>] {
5+
const [value, setValue] = createSignal<T>(defaultValue);
6+
7+
onMount(() => {
98
const item = localStorage.getItem(key);
10-
if (!item) return defaultValue;
11-
try {
12-
return JSON.parse(item) as T;
13-
} catch {
14-
return defaultValue;
9+
if (item != null) {
10+
try {
11+
setValue(JSON.parse(item));
12+
} catch {
13+
/* ignore malformed */
14+
}
1515
}
16-
})();
17-
18-
const [value, setValue] = createSignal<T>(initial);
19-
20-
createEffect(() => {
21-
localStorage.setItem(key, JSON.stringify(value()));
2216
});
2317

18+
createEffect(
19+
on(value, (v) => {
20+
localStorage.setItem(key, JSON.stringify(v));
21+
})
22+
);
23+
2424
return [value, setValue];
2525
}

0 commit comments

Comments
 (0)