improve xmake.sh

Author: waruqi

core/xmake.lua

@@ -101,7 +101,7 @@ option("curses")
             option:add("links", "ncursesw")
         elseif is_plat("macosx") then
             option:add("cincludes", "curses.h")
-            option:add("links", "ncurses")
+            option:add("links", "curses")
         else
             option:add("cincludes", "curses.h")
             option:add("links", "curses")

core/xmake.sh

@@ -65,14 +65,23 @@ option_find_curses() {
     if is_plat "mingw"; then
         ncurses="ncursesw"
     fi
-    local ncurses_ldflags=""
-    ncurses_ldflags=$(pkg-config --libs ${ncurses} 2>/dev/null)
+    # on macOS, homebrew ncurses is keg-only, add its pkgconfig path
+    local pkg_config_path="${PKG_CONFIG_PATH}"
+    if is_host "macosx"; then
+        local brew_prefix=$(brew --prefix ncurses 2>/dev/null)
+        if test_nz "${brew_prefix}"; then
+            pkg_config_path="${brew_prefix}/lib/pkgconfig:${pkg_config_path}"
+        fi
+    fi
+    local ncurses_cflags=$(PKG_CONFIG_PATH="${pkg_config_path}" pkg-config --cflags ${ncurses} 2>/dev/null)
+    local ncurses_ldflags=$(PKG_CONFIG_PATH="${pkg_config_path}" pkg-config --libs ${ncurses} 2>/dev/null)
     option "curses"
         if test_nz "${ncurses_ldflags}"; then
-            add_cflags `pkg-config --cflags ${ncurses} 2>/dev/null`
+            add_cflags "${ncurses_cflags}"
             add_ldflags "${ncurses_ldflags}"
-        elif is_plat "macosx"; then
-            add_links "ncurses"
+        elif is_host "macosx"; then
+            # disable curses to avoid header/library mismatch with homebrew
+            set_default "false"
         else
             add_links "curses"
         fi