Is it possible to add arguments to command with package.tools.gn build?

[poirierlouis]

I'm trying to build V8 when using:

https://github.com/xmake-io/xmake-repo/blob/b5e2178691cd035b1b7794b59186bd1b2f61fc9c/packages/v/v8/xmake.lua#L75

Thing is, this tool don't allow extra arguments. It only process config keys to be put in "--args=" as an argument for ninja:

ninja -C out.gn/ --args="..."

I need to add an argument to be able to run this instead:

ninja -C out.gn/ --args="..." v8_monolith

After a quick look at the code, it is not possible as-is. A change would be required to accept more arguments:

xmake/xmake/modules/package/tools/gn.lua

Line 101 in b509bae

table.insert(argv, _get_buildir(opt))

Is it possible to change it?

Usage could look like this in a package:

local configs = {} -- for "--args="
local argv = {"v8_monolith"}

import("package.tools.gn").build(package, configs, {buildir = "out.gn"}, argv)

-- OR
import("package.tools.gn").build(package, configs, {buildir = "out.gn", argv = argv})

[poirierlouis]

Done in #6149 and should be released in v2.9.9
target is used instead of argv.