(C++ modules support) fix clang cl module support #6477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthapz
force-pushed
the
fix-clang-cl-modules
branch
12 times, most recently
from
bec2d84 to
d9db1db
Compare
waruqi
reviewed
May 21, 2025
Arthapz
force-pushed
the
fix-clang-cl-modules
branch
2 times, most recently
from
bd22935 to
d5665df
Compare
Arthapz
force-pushed
the
fix-clang-cl-modules
branch
from
d5665df to
e70591f
Compare
Arthapz
force-pushed
the
fix-clang-cl-modules
branch
3 times, most recently
from
0132587 to
628e6c7
Compare
|
ok found a better way to fix it llvm/llvm-project#140825 (comment) |
Arthapz
force-pushed
the
fix-clang-cl-modules
branch
from
628e6c7 to
481ada9
Compare
|
this patch works at least with our tests cases (pch excluded) but i think we shouldn't advertise that XMake support clang-cl + modules as it's not well tested and it seems to cause some issues to the CMake guys that are not resolved yet, see llvm/llvm-project#121046 (comment) |
|
Thanks, maybe we can add some warnings to prompt users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6472
to fix clang-cl this patch disable the two phase compilation supportsee llvm/llvm-project#140825