Skip to content

Commit e1bb4d6

Browse files
Fix building for Mac Catalyst on Xcode 12 (#2078)
1 parent 9fe153d commit e1bb4d6

File tree

6 files changed

+31
-28
lines changed

6 files changed

+31
-28
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ All notable changes to this project will be documented in this file.
99
* Update SelectorViewController.swift (#2062)
1010
* Fix subtitle field row constraints (#2069)
1111
* Create a workaround for Swift crash (#2057, #2061)
12-
* Fix date row style/rendering issues for iOS14 (#2067)
12+
* Fix date row style/rendering issues for iOS 14 (#2067)
1313

1414
### [5.2.1](https://github.com/xmartlabs/Eureka/releases/tag/5.2.1)
1515

Eureka.xcodeproj/project.pbxproj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@
439439
isa = PBXProject;
440440
attributes = {
441441
LastSwiftUpdateCheck = 0700;
442-
LastUpgradeCheck = 1020;
442+
LastUpgradeCheck = 1200;
443443
ORGANIZATIONNAME = Xmartlabs;
444444
TargetAttributes = {
445445
51729DEA1B9A4F5E004A00EB = {
@@ -622,6 +622,7 @@
622622
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
623623
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
624624
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
625+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
625626
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
626627
CLANG_WARN_STRICT_PROTOTYPES = YES;
627628
CLANG_WARN_SUSPICIOUS_MOVE = YES;
@@ -682,6 +683,7 @@
682683
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
683684
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
684685
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
686+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
685687
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
686688
CLANG_WARN_STRICT_PROTOTYPES = YES;
687689
CLANG_WARN_SUSPICIOUS_MOVE = YES;

Eureka.xcodeproj/xcshareddata/xcschemes/Eureka.xcscheme

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "1020"
3+
LastUpgradeVersion = "1200"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"
@@ -27,6 +27,15 @@
2727
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
2828
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
2929
shouldUseLaunchSchemeArgsEnv = "YES">
30+
<MacroExpansion>
31+
<BuildableReference
32+
BuildableIdentifier = "primary"
33+
BlueprintIdentifier = "51729DEA1B9A4F5E004A00EB"
34+
BuildableName = "Eureka.framework"
35+
BlueprintName = "Eureka"
36+
ReferencedContainer = "container:Eureka.xcodeproj">
37+
</BuildableReference>
38+
</MacroExpansion>
3039
<Testables>
3140
<TestableReference
3241
skipped = "NO">
@@ -39,17 +48,6 @@
3948
</BuildableReference>
4049
</TestableReference>
4150
</Testables>
42-
<MacroExpansion>
43-
<BuildableReference
44-
BuildableIdentifier = "primary"
45-
BlueprintIdentifier = "51729DEA1B9A4F5E004A00EB"
46-
BuildableName = "Eureka.framework"
47-
BlueprintName = "Eureka"
48-
ReferencedContainer = "container:Eureka.xcodeproj">
49-
</BuildableReference>
50-
</MacroExpansion>
51-
<AdditionalOptions>
52-
</AdditionalOptions>
5351
</TestAction>
5452
<LaunchAction
5553
buildConfiguration = "Debug"
@@ -70,8 +68,6 @@
7068
ReferencedContainer = "container:Eureka.xcodeproj">
7169
</BuildableReference>
7270
</MacroExpansion>
73-
<AdditionalOptions>
74-
</AdditionalOptions>
7571
</LaunchAction>
7672
<ProfileAction
7773
buildConfiguration = "Release"

Example.xcodeproj/project.pbxproj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@
337337
51729E121B9A54F1004A00EB /* Project object */ = {
338338
isa = PBXProject;
339339
attributes = {
340-
LastUpgradeCheck = 1020;
340+
LastUpgradeCheck = 1200;
341341
ORGANIZATIONNAME = Xmartlabs;
342342
TargetAttributes = {
343343
51729E191B9A54F1004A00EB = {
@@ -538,6 +538,7 @@
538538
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
539539
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
540540
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
541+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
541542
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
542543
CLANG_WARN_STRICT_PROTOTYPES = YES;
543544
CLANG_WARN_SUSPICIOUS_MOVE = YES;
@@ -593,6 +594,7 @@
593594
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
594595
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
595596
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
597+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
596598
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
597599
CLANG_WARN_STRICT_PROTOTYPES = YES;
598600
CLANG_WARN_SUSPICIOUS_MOVE = YES;

Example.xcodeproj/xcshareddata/xcschemes/Example.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "1020"
3+
LastUpgradeVersion = "1200"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

Source/Rows/DateInlineRow.swift

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,19 @@ extension DatePickerRowProtocol {
3535

3636
func configurePickerStyle(_ cell: DatePickerCell, _ mode: UIDatePicker.Mode = .dateAndTime) {
3737
cell.datePicker.datePickerMode = mode
38-
if #available(iOS 14.0, *) {
39-
#if swift(>=5.3)
40-
cell.datePicker.preferredDatePickerStyle = .inline
41-
#else
42-
cell.datePicker.preferredDatePickerStyle = .wheels
43-
#endif
44-
}
45-
else if #available(iOS 13.4, *) {
46-
cell.datePicker.preferredDatePickerStyle = .wheels
47-
}
38+
// For Xcode 11.4 and above
39+
#if swift(>=5.2)
40+
if #available(iOS 14.0, *) {
41+
#if swift(>=5.3) && !(os(OSX) || (os(iOS) && targetEnvironment(macCatalyst)))
42+
cell.datePicker.preferredDatePickerStyle = .inline
43+
#else
44+
cell.datePicker.preferredDatePickerStyle = .wheels
45+
#endif
46+
}
47+
else if #available(iOS 13.4, *) {
48+
cell.datePicker.preferredDatePickerStyle = .wheels
49+
}
50+
#endif
4851
}
4952

5053
}

0 commit comments

Comments
 (0)