Skip to content

Commit 5bd32a1

Browse files
committed
Temporarily disable the @typescript-eslint/naming-convention rule
1 parent 56a8ca1 commit 5bd32a1

File tree

1 file changed

+54
-51
lines changed

1 file changed

+54
-51
lines changed

index.js

Lines changed: 54 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -157,58 +157,61 @@ module.exports = {
157157
'@typescript-eslint/member-ordering': 'error',
158158
// We use `@typescript-eslint/naming-convention` in favor of `camelcase`.
159159
camelcase: 'off',
160-
// DON't push this until typescript-eslint 2.17 is out. And test it on Got and RG.
160+
// TODO: Enable this again when the following is fixed:
161+
// - https://github.com/typescript-eslint/typescript-eslint/issues/1483
162+
// - https://github.com/typescript-eslint/typescript-eslint/issues/1485
163+
// - https://github.com/typescript-eslint/typescript-eslint/issues/1484
161164
// TODO: Prevent `_` prefix on private fields when TypeScript 3.8 is out.
162-
'@typescript-eslint/naming-convention': [
163-
'error',
164-
{
165-
selector: 'default',
166-
format: [
167-
'strictCamelCase'
168-
],
169-
leadingUnderscore: 'allow',
170-
trailingUnderscore: 'allow'
171-
},
172-
{
173-
selector: 'typeLike',
174-
format: [
175-
'StrictPascalCase'
176-
]
177-
},
178-
{
179-
selector: 'variable',
180-
types: [
181-
'boolean'
182-
],
183-
format: [
184-
'StrictPascalCase'
185-
],
186-
prefix: [
187-
'is',
188-
'has',
189-
'can',
190-
'should',
191-
'will',
192-
'did'
193-
]
194-
},
195-
{
196-
// Interface name should not be prefixed with `I`.
197-
selector: 'interface',
198-
filter: /^(?!I)[A-Z]/.source,
199-
format: [
200-
'StrictPascalCase'
201-
]
202-
},
203-
{
204-
// Type parameter name should either be `T` or a descriptive name.
205-
selector: 'typeParameter',
206-
filter: /^T$|^[A-Z][a-zA-Z]+$/.source,
207-
format: [
208-
'StrictPascalCase'
209-
]
210-
}
211-
],
165+
// '@typescript-eslint/naming-convention': [
166+
// 'error',
167+
// {
168+
// selector: 'default',
169+
// format: [
170+
// 'strictCamelCase'
171+
// ],
172+
// leadingUnderscore: 'allow',
173+
// trailingUnderscore: 'allow'
174+
// },
175+
// {
176+
// selector: 'typeLike',
177+
// format: [
178+
// 'StrictPascalCase'
179+
// ]
180+
// },
181+
// {
182+
// selector: 'variable',
183+
// types: [
184+
// 'boolean'
185+
// ],
186+
// format: [
187+
// 'StrictPascalCase'
188+
// ],
189+
// prefix: [
190+
// 'is',
191+
// 'has',
192+
// 'can',
193+
// 'should',
194+
// 'will',
195+
// 'did'
196+
// ]
197+
// },
198+
// {
199+
// // Interface name should not be prefixed with `I`.
200+
// selector: 'interface',
201+
// filter: /^(?!I)[A-Z]/.source,
202+
// format: [
203+
// 'StrictPascalCase'
204+
// ]
205+
// },
206+
// {
207+
// // Type parameter name should either be `T` or a descriptive name.
208+
// selector: 'typeParameter',
209+
// filter: /^T$|^[A-Z][a-zA-Z]+$/.source,
210+
// format: [
211+
// 'StrictPascalCase'
212+
// ]
213+
// }
214+
// ],
212215
'no-array-constructor': 'off',
213216
'@typescript-eslint/no-array-constructor': 'error',
214217
'no-dupe-class-members': 'off',

0 commit comments

Comments
 (0)