File tree Expand file tree Collapse file tree 1 file changed +10
-1
lines changed Expand file tree Collapse file tree 1 file changed +10
-1
lines changed Original file line number Diff line number Diff line change @@ -337,7 +337,16 @@ module.exports = {
337337 '@typescript-eslint/no-throw-literal' : 'error' ,
338338 '@typescript-eslint/no-unnecessary-boolean-literal-compare' : 'error' ,
339339 'no-constant-condition' : 'off' , // `no-unnecessary-condition` is essentially a stricter version of `no-constant-condition`.
340- '@typescript-eslint/no-unnecessary-condition' : 'error' ,
340+
341+ // TODO: Try to enable this again in 2023 *if* the following are resolved:
342+ // - https://github.com/microsoft/TypeScript/issues/13778 (otherwise, it will report on if checks for elements extracted from array)
343+ // - https://github.com/microsoft/TypeScript/issues/36393
344+ // - The rule needs a way to ignore runtime type-checks: https://github.com/sindresorhus/refined-github/pull/3168
345+ // - Run the rule on https://github.com/sindresorhus/refined-github and ensure there are no false-positives
346+ //
347+ // Also related: https://github.com/typescript-eslint/typescript-eslint/issues/1798
348+ // '@typescript-eslint/no-unnecessary-condition': 'error',
349+
341350 '@typescript-eslint/no-unnecessary-qualifier' : 'error' ,
342351 '@typescript-eslint/no-unnecessary-type-arguments' : 'error' ,
343352 '@typescript-eslint/no-unnecessary-type-assertion' : 'error' ,
You can’t perform that action at this time.
0 commit comments