Fix FormatExceptions due to Enum.ToString not supporting precision (#15)

tmds · web-flow · commit 7549238d41b0 · 2020-12-08T07:47:22.000+01:00
diff --git a/src/LibObjectFile/Elf/ElfPrinter.cs b/src/LibObjectFile/Elf/ElfPrinter.cs
@@ -365,7 +365,7 @@ private static string GetElfNoteDescription(ElfNote note)
 
             if (builder.Length == 0)
             {
-                builder.Append($"Unknown note type: (0x{note.GetNoteType().Value:x8})");
+                builder.Append($"Unknown note type: (0x{(uint)note.GetNoteType().Value:x8})");
             }
 
             builder.Append("\t\t");
diff --git a/src/LibObjectFile/Elf/Sections/ElfNoteType.cs b/src/LibObjectFile/Elf/Sections/ElfNoteType.cs
@@ -28,7 +28,7 @@ public ElfNoteTypeEx(ElfNoteType value)
 
         public override string ToString()
         {
-            return ToStringInternal() ?? $"Unknown {nameof(ElfNoteTypeEx)} (0x{Value:X4})";
+            return ToStringInternal() ?? $"Unknown {nameof(ElfNoteTypeEx)} (0x{(uint)Value:X4})";
         }
 
         public bool Equals(ElfNoteTypeEx other)

Original file line number	Diff line number	Diff line change
`@@ -365,7 +365,7 @@ private static string GetElfNoteDescription(ElfNote note)`
`365`	`365`
`366`	`366`	`if (builder.Length == 0)`
`367`	`367`	`{`
`368`		`- builder.Append($"Unknown note type: (0x{note.GetNoteType().Value:x8})");`
	`368`	`+ builder.Append($"Unknown note type: (0x{(uint)note.GetNoteType().Value:x8})");`
`369`	`369`	`}`
`370`	`370`
`371`	`371`	`builder.Append("\t\t");`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public ElfNoteTypeEx(ElfNoteType value)`
`28`	`28`
`29`	`29`	`public override string ToString()`
`30`	`30`	`{`
`31`		`- return ToStringInternal() ?? $"Unknown {nameof(ElfNoteTypeEx)} (0x{Value:X4})";`
	`31`	`+ return ToStringInternal() ?? $"Unknown {nameof(ElfNoteTypeEx)} (0x{(uint)Value:X4})";`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`public bool Equals(ElfNoteTypeEx other)`