Merge pull request #866 from MihaZupan/alert-perf

Improve Alert parsing perf

Author: xoofx

src/Markdig/Extensions/Alerts/AlertBlock.cs

@@ -22,7 +22,7 @@ public AlertBlock(StringSlice kind) : base(null)
     }
 
     /// <summary>
-    /// Gets or sets the kind of the alert block (e.g `NOTE`, `TIP`, `IMPORTANT`, `WARNING`, `CAUTION`)
+    /// Gets or sets the kind of the alert block (e.g `NOTE`, `TIP`, `IMPORTANT`, `WARNING`, `CAUTION`).
     /// </summary>
     public StringSlice Kind { get; set; }
 

src/Markdig/Extensions/Alerts/AlertInlineParser.cs

@@ -15,6 +15,9 @@ namespace Markdig.Extensions.Alerts;
 /// <seealso cref="InlineParser" />
 public class AlertInlineParser : InlineParser
 {
+    private static readonly TransformedStringCache s_alertTypeClassCache = new(
+        type => $"markdown-alert-{type.ToLowerInvariant()}");
+
     /// <summary>
     /// Initializes a new instance of the <see cref="AlertInlineParser"/> class.
     /// </summary>
@@ -25,27 +28,30 @@ public AlertInlineParser()
 
     public override bool Match(InlineProcessor processor, ref StringSlice slice)
     {
-        // We expect the alert to be the first child of a quote block. Example:
-        // > [!NOTE]
-        // > This is a note
-        if (processor.Block is not ParagraphBlock paragraphBlock || paragraphBlock.Parent is not QuoteBlock quoteBlock || paragraphBlock.Inline?.FirstChild != null
-            || quoteBlock is AlertBlock || quoteBlock.Parent is not MarkdownDocument)
+        if (slice.PeekChar() != '!')
         {
             return false;
         }
 
-        var saved = slice;
-        var c = slice.NextChar();
-        if (c != '!')
+        // We expect the alert to be the first child of a quote block. Example:
+        // > [!NOTE]
+        // > This is a note
+        if (processor.Block is not ParagraphBlock paragraphBlock ||
+            paragraphBlock.Parent is not QuoteBlock quoteBlock ||
+            paragraphBlock.Inline?.FirstChild != null ||
+            quoteBlock is AlertBlock ||
+            quoteBlock.Parent is not MarkdownDocument)
         {
-            slice = saved;
             return false;
         }
 
-        c = slice.NextChar(); // Skip !
+        StringSlice saved = slice;
+
+        slice.SkipChar(); // Skip [
+        char c = slice.NextChar(); // Skip !
 
-        var start = slice.Start;
-        var end = start;
+        int start = slice.Start;
+        int end = start;
         while (c.IsAlpha())
         {
             end = slice.Start;
@@ -76,13 +82,13 @@ public override bool Match(InlineProcessor processor, ref StringSlice slice)
                         end = slice.Start;
                         if (c == '\n')
                         {
-                            slice.NextChar(); // Skip \n
+                            slice.SkipChar(); // Skip \n
                         }
                     }
                 }
                 else if (c == '\n')
                 {
-                    slice.NextChar(); // Skip \n
+                    slice.SkipChar(); // Skip \n
                 }
                 break;
             }
@@ -103,8 +109,9 @@ public override bool Match(InlineProcessor processor, ref StringSlice slice)
             Column = quoteBlock.Column,
         };
 
-        alertBlock.GetAttributes().AddClass("markdown-alert");
-        alertBlock.GetAttributes().AddClass($"markdown-alert-{alertType.ToString().ToLowerInvariant()}");
+        HtmlAttributes attributes = alertBlock.GetAttributes();
+        attributes.AddClass("markdown-alert");
+        attributes.AddClass(s_alertTypeClassCache.Get(alertType.AsSpan()));
 
         // Replace the quote block with the alert block
         var parentQuoteBlock = quoteBlock.Parent!;

src/Markdig/MarkdownPipeline.cs

@@ -127,7 +127,7 @@ protected override void Reset(HtmlRenderer instance)
         }
     }
 
-    internal readonly struct RentedHtmlRenderer : IDisposable
+    internal readonly ref struct RentedHtmlRenderer : IDisposable
     {
         private readonly HtmlRendererCache _cache;
         public readonly HtmlRenderer Instance;

src/Markdig/Syntax/MarkdownObject.cs

@@ -153,7 +153,7 @@ public string ToPositionText()
         return Unsafe.As<T>(storage.Trivia);
     }
 
-    private class DataEntriesAndTrivia
+    private sealed class DataEntriesAndTrivia
     {
         private struct DataEntry(object key, object value)
         {

src/Markdig/Syntax/QuoteBlock.cs

@@ -25,7 +25,7 @@ public QuoteBlock(BlockParser? parser) : base(parser)
 
     /// <summary>
     /// Gets or sets the trivia per line of this QuoteBlock.
-    /// Trivia: only parsed when <see cref="MarkdownPipeline.TrackTrivia"/> is enabled, otherwise null.
+    /// Trivia: only parsed when <see cref="MarkdownPipeline.TrackTrivia"/> is enabled.
     /// </summary>
     public List<QuoteBlockLine> QuoteLines => Trivia;