Skip to content

Commit 1d0037a

Browse files
committed
Refactor TestRuntime trait to abstract base class
1 parent 60d66cc commit 1d0037a

File tree

5 files changed

+8
-11
lines changed

5 files changed

+8
-11
lines changed

src/test/php/com/amazon/aws/lambda/unittest/BufferedTest.class.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
use lang\IllegalStateException;
55
use test\{Assert, Test};
66

7-
class BufferedTest {
8-
use TestContext, TestRuntime;
7+
class BufferedTest extends RuntimeTest {
8+
use TestContext;
99

1010
/**
1111
* Invokes a lambda and returns the response

src/test/php/com/amazon/aws/lambda/unittest/ExceptionTest.class.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
use lang\{IllegalArgumentException, IllegalStateException};
44
use test\{Assert, Test};
55

6-
class ExceptionTest {
7-
use TestRuntime;
6+
class ExceptionTest extends RuntimeTest {
87

98
#[Test]
109
public function includes_errorMessage() {

src/test/php/com/amazon/aws/lambda/unittest/HandlerTest.class.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@
44
use lang\IllegalArgumentException;
55
use test\{Assert, Expect, Test};
66

7-
class HandlerTest {
8-
use TestRuntime;
9-
7+
class HandlerTest extends RuntimeTest {
108
private $headers= [
119
'Lambda-Runtime-Aws-Request-Id' => ['3e1afeb0-cde4-1d0e-c3c0-66b15046bb88'],
1210
'Lambda-Runtime-Invoked-Function-Arn' => ['arn:aws:lambda:us-east-1:1185465369:function:test'],

src/test/php/com/amazon/aws/lambda/unittest/TestRuntime.class.php renamed to src/test/php/com/amazon/aws/lambda/unittest/RuntimeTest.class.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
use com\amazon\aws\lambda\RuntimeApi;
44
use test\Before;
55

6-
trait TestRuntime {
7-
private $runtime;
6+
abstract class RuntimeTest {
7+
protected $runtime;
88

99
#[Before]
1010
public function runtime() {

src/test/php/com/amazon/aws/lambda/unittest/StreamingTest.class.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
use lang\IllegalStateException;
66
use test\{Assert, Expect, Test};
77

8-
class StreamingTest {
9-
use TestContext, TestRuntime;
8+
class StreamingTest extends RuntimeTest {
9+
use TestContext;
1010

1111
/**
1212
* Invokes a lambda and returns the response

0 commit comments

Comments
 (0)