Skip to content

Commit 6fa9fd6

Browse files
committed
Fix tests not running on HHVM
Fixes #22
1 parent dd90f8e commit 6fa9fd6

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

.travis.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@ php:
88
- 5.6
99
- hhvm
1010

11-
matrix:
12-
allow_failures:
13-
- php: hhvm
14-
1511
before_script:
1612
- wget 'https://github.com/xp-framework/xp-runners/releases/download/v5.3.1/setup' -O - | php
1713
- composer install --prefer-dist

ChangeLog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ Data sequences change log
33

44
## ?.?.? / ????-??-??
55

6+
* Fixed issue #22: tests not running on HHVM - @thekid
7+
68
## 2.2.0 / 2015-05-30
79

810
* Made Optional's constructor public and allow `new Optional(null)` to

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Data sequences
55
[![XP Framework Module](https://raw.githubusercontent.com/xp-framework/web/master/static/xp-framework-badge.png)](https://github.com/xp-framework/core)
66
[![BSD Licence](https://raw.githubusercontent.com/xp-framework/web/master/static/licence-bsd.png)](https://github.com/xp-framework/core/blob/master/LICENCE.md)
77
[![Required PHP 5.4+](https://raw.githubusercontent.com/xp-framework/web/master/static/php-5_4plus.png)](http://php.net/)
8+
[![Required HHVM 3.4+](https://raw.githubusercontent.com/xp-framework/web/master/static/hhvm-3_4plus.png)](http://hhvm.com/)
89
[![Latest Stable Version](https://poser.pugx.org/xp-forge/sequence/version.png)](https://packagist.org/packages/xp-forge/sequence)
910

1011
This API allows working with data sequences of different kinds in a functional style, e.g. map/reduce.

src/test/php/util/data/unittest/Enumerables.class.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,12 @@ public static function streamedArrays() {
7979
[
8080
[newinstance('util.XPIterator', [], '{
8181
protected $numbers= [1, 2, 3];
82-
public function hasNext() { return $this->numbers; }
82+
public function hasNext() { return !empty($this->numbers); }
8383
public function next() { return array_shift($this->numbers); }
8484
}'), 'xp-iterator'],
8585
[Sequence::of(newinstance('util.XPIterator', [], '{
8686
protected $numbers= [1, 2, 3];
87-
public function hasNext() { return $this->numbers; }
87+
public function hasNext() { return !empty($this->numbers); }
8888
public function next() { return array_shift($this->numbers); }
8989
}')), 'self-of-xp-iterator']
9090
]

0 commit comments

Comments
 (0)