Allow named placeholder

Author: thekid

src/main/php/lang/ast/syntax/PHP.class.php

@@ -1737,28 +1737,32 @@ public function arguments($parse) {
         $parse->forward();
         if (':' === $parse->token->value) {
           $parse->forward();
-          $arguments[$token->value]= $this->expression($parse, 0);
+          $offset= $token->value;
         } else {
           array_unshift($parse->queue, $parse->token);
           $parse->token= $token;
-          $arguments[]= $this->expression($parse, 0);
+          $offset= sizeof($arguments);
         }
-      } else if ('?' === $parse->token->value) {
+      } else {
+        $offset= sizeof($arguments);
+      }
+
+      if ('?' === $parse->token->value) {
         $callable= true;
-        $arguments[]= Placeholder::$ARGUMENT;
+        $arguments[$offset]= Placeholder::$ARGUMENT;
         $parse->forward();
       } else if ('...' === $parse->token->value) {
         $parse->forward();
 
         // Resolve ambiguity between unpack and variadic placeholder at the end of arguments
         if (')' === $parse->token->value) {
           $callable= true;
-          $arguments[]= Placeholder::$VARIADIC;
+          $arguments[$offset]= Placeholder::$VARIADIC;
         } else {
-          $arguments[]= new UnpackExpression($this->expression($parse, 0), $parse->token->line);
+          $arguments[$offset]= new UnpackExpression($this->expression($parse, 0), $parse->token->line);
         }
       } else {
-        $arguments[]= $this->expression($parse, 0);
+        $arguments[$offset]= $this->expression($parse, 0);
       }
 
       if (',' === $parse->token->value) {

src/test/php/lang/ast/unittest/parse/InvokeTest.class.php

@@ -132,6 +132,18 @@ public function partial_function_application() {
     );
   }
 
+  #[Test]
+  public function partial_function_application_named() {
+    $this->assertParsed(
+      [new CallableExpression(
+        new Literal('str_replace', self::LINE),
+        [new Literal('"test"', self::LINE), new Literal('"ok"', self::LINE), 'subject' => Placeholder::$ARGUMENT],
+        self::LINE
+      )],
+      'str_replace("test", "ok", subject: ?);'
+    );
+  }
+
   #[Test]
   public function chained_invocation_spanning_multiple_lines() {
     $expr= new InvokeExpression(