Fix callable new syntax when using a variable or expression

See also php/php-src#12336

Author: thekid

ChangeLog.md

@@ -3,6 +3,12 @@ XP Compiler ChangeLog
 
 ## ?.?.? / ????-??-??
 
+## 9.3.3 / 2025-03-02
+
+* Fixed callable new syntax when using a variable or expression, e.g.
+  `new $class(...)`. See also https://github.com/php/php-src/issues/12336
+  (@thekid)
+
 ## 9.3.2 / 2024-11-02
 
 * Fixed empty match expressions and match expressions with default

src/main/php/lang/ast/emit/PHP.class.php

@@ -1096,13 +1096,11 @@ protected function emitCallable($result, $callable) {
 
   protected function emitCallableNew($result, $callable) {
     $t= $result->temp();
-    $result->out->write("function(...{$t}) { return ");
+    $result->out->write("fn(...{$t}) => ");
 
     $callable->type->arguments= [new UnpackExpression(new Variable(substr($t, 1)), $callable->line)];
     $this->emitOne($result, $callable->type);
     $callable->type->arguments= null;
-
-    $result->out->write("; }");
   }
 
   protected function emitInvoke($result, $invoke) {

src/test/php/lang/ast/unittest/emit/CallableSyntaxTest.class.php

@@ -171,6 +171,28 @@ public function run() {
     Assert::equals([new Handle(0), new Handle(1), new Handle(2)], $r);
   }
 
+  #[Test]
+  public function variable_instantiation() {
+    $r= $this->run('use lang\ast\unittest\emit\Handle; class %T {
+      public function run() {
+        $class= Handle::class;
+        return array_map(new $class(...), [0, 1, 2]);
+      }
+    }');
+    Assert::equals([new Handle(0), new Handle(1), new Handle(2)], $r);
+  }
+
+  #[Test]
+  public function expression_instantiation() {
+    $r= $this->run('use lang\ast\unittest\emit\Handle; class %T {
+      public function run() {
+        $version= "";
+        return array_map(new (Handle::class.$version)(...), [0, 1, 2]);
+      }
+    }');
+    Assert::equals([new Handle(0), new Handle(1), new Handle(2)], $r);
+  }
+
   #[Test]
   public function anonymous_instantiation() {
     $f= $this->run('class %T {