Optimize xp::$meta

thekid · thekid · commit 82299e29de67 · 2025-04-05T15:20:48.000+02:00
diff --git a/src/main/php/lang/ast/emit/FinalProperties.class.php b/src/main/php/lang/ast/emit/FinalProperties.class.php
@@ -18,8 +18,9 @@ protected function emitProperty($result, $property) {
       $modifiers|= $lookup[$name];
     }
 
+    // Emit without final modifier, store `final` in xp::$meta
     $property->modifiers= array_diff($property->modifiers, ['final']);
     parent::emitProperty($result, $property);
-    $result->codegen->scope[0]->meta[self::PROPERTY][$property->name][DETAIL_ARGUMENTS]= [$modifiers];
+    $result->codegen->scope[0]->meta[self::PROPERTY][$property->name][DETAIL_ARGUMENTS]= [MODIFIER_FINAL];
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,9 @@ protected function emitProperty($result, $property) {`
`18`	`18`	`$modifiers\|= $lookup[$name];`
`19`	`19`	`}`
`20`	`20`
	`21`	+ // Emit without final modifier, store `final` in xp::$meta
`21`	`22`	`$property->modifiers= array_diff($property->modifiers, ['final']);`
`22`	`23`	`parent::emitProperty($result, $property);`
`23`		`- $result->codegen->scope[0]->meta[self::PROPERTY][$property->name][DETAIL_ARGUMENTS]= [$modifiers];`
	`24`	`+ $result->codegen->scope[0]->meta[self::PROPERTY][$property->name][DETAIL_ARGUMENTS]= [MODIFIER_FINAL];`
`24`	`25`	`}`
`25`	`26`	`}`