Use nullable types

Author: thekid

src/main/php/peer/ftp/DefaultFtpListParser.class.php

@@ -14,12 +14,12 @@ class DefaultFtpListParser implements FtpListParser {
    * Parse raw listing entry.
    *
    * @param   string $raw a single line
-   * @param   peer.ftp.FtpConnection $connection
+   * @param   peer.ftp.FtpConnection $conn
    * @param   string $base default "/"
-   * @param   util.Date $ref default NULL
+   * @param   ?util.Date $ref default NULL
    * @return  peer.ftp.FtpEntry
    */
-  public function entryFrom($raw, FtpConnection $conn= null, $base= '/', Date $ref= null) {
+  public function entryFrom($raw, FtpConnection $conn, $base= '/', ?Date $ref= null) {
     sscanf(
       $raw, 
       '%s %d %s %s %d %s %d %[^ ] %[^$]',

src/main/php/peer/ftp/FtpFile.class.php

@@ -65,11 +65,11 @@ public function refresh($state) {
    *
    * @param   io.streams.InputStream|io.Channel in
    * @param   int mode default FtpTransfer::BINARY
-   * @param   peer.ftp.FtpTransferListener listener default NULL
-   * @return  peer.ftp.FtpFile this file
+   * @param   ?peer.ftp.FtpTransferListener listener default NULL
+   * @return  self
    * @throws  peer.SocketException in case of an I/O error
    */
-  public function uploadFrom($in, $mode= FtpTransfer::BINARY, FtpTransferListener $listener= null) {
+  public function uploadFrom($in, $mode= FtpTransfer::BINARY, ?FtpTransferListener $listener= null) {
     $transfer= (new FtpUpload($this, $in))->withListener($listener)->start($mode);
     while (!$transfer->complete()) $transfer->perform();
 
@@ -87,8 +87,8 @@ public function uploadFrom($in, $mode= FtpTransfer::BINARY, FtpTransferListener
   /**
    * Starts a transfer
    *
-   * @see     xp://peer.ftp.FtpDownload#to
-   * @see     xp://peer.ftp.FtpUpload#from
+   * @see     peer.ftp.FtpDownload::to
+   * @see     peer.ftp.FtpUpload::from
    * @param   peer.ftp.FtpTransfer transfer
    * @param   int mode default FtpTransfer::BINARY
    * @return  peer.ftp.FtpTransfer 
@@ -104,11 +104,11 @@ public function start(FtpTransfer $transfer, $mode= FtpTransfer::BINARY) {
    *
    * @param   io.streams.OutputStream|io.Channel out
    * @param   int mode default FtpTransfer::BINARY
-   * @param   peer.ftp.FtpTransferListener listener default NULL
+   * @param   ?peer.ftp.FtpTransferListener listener default NULL
    * @return  io.streams.OutputStream the output stream passed
    * @throws  peer.SocketException in case of an I/O error
    */
-  public function downloadTo($out, $mode= FtpTransfer::BINARY, FtpTransferListener $listener= null) {
+  public function downloadTo($out, $mode= FtpTransfer::BINARY, ?FtpTransferListener $listener= null) {
     $transfer= (new FtpDownload($this, $out))->withListener($listener)->start($mode);
     while (!$transfer->complete()) $transfer->perform();
 

src/main/php/peer/ftp/FtpListParser.class.php

@@ -27,11 +27,11 @@ interface FtpListParser {
    * Parse raw listing entry.
    *
    * @param   string $raw a single line
-   * @param   peer.ftp.FtpConnection $connection
+   * @param   peer.ftp.FtpConnection $conn
    * @param   string $base default "/"
-   * @param   util.Date $ref default NULL
+   * @param   ?util.Date $ref default NULL
    * @return  peer.ftp.FtpEntry
    */
-  public function entryFrom($raw, FtpConnection $conn= null, $base= '/', Date $ref= null);
+  public function entryFrom($raw, FtpConnection $conn, $base= '/', ?Date $ref= null);
 
 }

src/main/php/peer/ftp/WindowsFtpListParser.class.php

@@ -14,12 +14,12 @@ class WindowsFtpListParser implements FtpListParser {
    * Parse raw listing entry
    *
    * @param   string $raw a single line
-   * @param   peer.ftp.FtpConnection $connection
+   * @param   peer.ftp.FtpConnection $conn
    * @param   string $base default "/"
-   * @param   util.Date $ref default NULL
+   * @param   ?util.Date $ref default NULL
    * @return  peer.ftp.FtpEntry
    */
-  public function entryFrom($raw, FtpConnection $conn= null, $base= '/', Date $ref= null) {
+  public function entryFrom($raw, FtpConnection $conn, $base= '/', ?Date $ref= null) {
     preg_match(
       '/([0-9]{2})-([0-9]{2})-([0-9]{2}) +([0-9]{2}):([0-9]{2})(AM|PM) +(<DIR>)?([0-9]+)? +(.+)/',
       $raw,