Rewrite isset(X) ? X : default to X ?? default

Author: thekid

src/main/php/rdbms/DefaultDrivers.class.php

@@ -57,6 +57,6 @@ public function drivers() { return array_keys(self::$impl); }
    * @return  string[] implementations
    */
   public function implementationsFor($driver) {
-    return isset(self::$impl[$driver]) ? self::$impl[$driver] : parent::implementationsFor($driver);
+    return self::$impl[$driver] ?? parent::implementationsFor($driver);
   }
 }

src/main/php/rdbms/mysql/MySQLDBAdapter.class.php

@@ -103,7 +103,7 @@ public static function tableAttributeFrom($record) {
       self::$map[$regs[1]],                                     // type
       false !== strpos($record['Extra'], 'auto_increment'),     // identity
       !(empty($record['Null']) || ('NO' == $record['Null'])),   // nullable
-      (int)(isset($regs[3]) ? $regs[3] : 0),                    // length
+      (int)($regs[3] ?? 0),                                     // length
       0,                                                        // precision
       0                                                         // scale
     );

src/main/php/rdbms/mysqli/MySQLiDBAdapter.class.php

@@ -102,7 +102,7 @@ public static function tableAttributeFrom($record) {
       self::$map[$regs[1]],                                     // type
       false !== strpos($record['Extra'], 'auto_increment'),     // identity
       !(empty($record['Null']) || ('NO' == $record['Null'])),   // nullable
-      (int)(isset($regs[3]) ? $regs[3] : 0),                    // length
+      (int)($regs[3] ?? 0),                                     // length
       0,                                                        // precision
       0                                                         // scale
     );

src/main/php/rdbms/mysqlx/NamedPipe.class.php

@@ -40,8 +40,7 @@ protected function locate() {
       return null;
     } while (0);
 
-    $options= $this->parse($ini);
-    return isset($options['client']['socket']) ? $pipes.$options['client']['socket'] : null;
+    return $this->parse($ini)['client']['socket'] ?? null;
   }
 
   /**

src/main/php/rdbms/tds/TdsProtocol.class.php

@@ -128,7 +128,7 @@ public function unmarshal($stream, $field, $records) {
     self::$recordsFor[0][self::XT_NVARCHAR]= self::$recordsFor[0][self::XT_VARCHAR];
     self::$recordsFor[0][self::T_INTN]= newinstance('rdbms.tds.TdsRecord', [], '{
       public function unmarshal($stream, $field, $records) {
-        $len= isset($field["len"]) ? $field["len"] : $stream->getByte();
+        $len= $field["len"] ?? $stream->getByte();
         switch ($len) {
           case 1: return $stream->getByte();
           case 2: return $stream->getShort();
@@ -180,7 +180,7 @@ public function unmarshal($stream, $field, $records) {
     }');
     self::$recordsFor[0][self::T_UINTN]= newinstance('rdbms.tds.TdsRecord', [], '{
       public function unmarshal($stream, $field, $records) {
-        $len= isset($field["len"]) ? $field["len"] : $stream->getByte();
+        $len= $field["len"] ?? $stream->getByte();
         switch ($len) {
           case 2: return $stream->getShort();
           case 4: return $stream->getLong();
@@ -191,7 +191,7 @@ public function unmarshal($stream, $field, $records) {
     }');
     self::$recordsFor[0][self::T_FLTN]= newinstance('rdbms.tds.TdsRecord', [], '{
       public function unmarshal($stream, $field, $records) {
-        $len= isset($field["len"]) ? $field["len"] : $stream->getByte();
+        $len= $field["len"] ?? $stream->getByte();
         switch ($len) {
           case 4: return $this->toFloat($stream->read(4)); break;
           case 8: return $this->toDouble($stream->read(8)); break;
@@ -226,7 +226,7 @@ public function unmarshal($stream, $field, $records) {
     }');
     self::$recordsFor[0][self::T_MONEYN]= newinstance('rdbms.tds.TdsRecord', [], '{
       public function unmarshal($stream, $field, $records) {
-        $len= isset($field["len"]) ? $field["len"] : $stream->getByte();
+        $len= $field["len"] ?? $stream->getByte();
         switch ($len) {
           case 4: return $this->toMoney($stream->getInt32()); break;
           case 8: return $this->toMoney($stream->getInt32(), $stream->getInt32()); break;

src/main/php/rdbms/tds/TdsV5Protocol.class.php

@@ -93,7 +93,7 @@ public function unmarshal($stream, $field, $records) {
     }');
     self::$recordsFor[0][self::T_DATETIMN]= newinstance('rdbms.tds.TdsRecord', [], '{
       public function unmarshal($stream, $field, $records) {
-        $len= isset($field["len"]) ? $field["len"] : $stream->getByte();
+        $len= $field["len"] ?? $stream->getByte();
         switch ($len) {
           case 4: return $this->toDate($stream->getShort(), $stream->getShort() * 60); break;
           case 8: return $this->toDate($stream->getLong(), $stream->getLong()); break;

src/main/php/rdbms/tds/TdsV7Protocol.class.php

@@ -18,7 +18,7 @@ static function __static() { }
   protected function setupRecords() {
     $records[self::T_NUMERIC]= newinstance('rdbms.tds.TdsRecord', [], '{
       public function unmarshal($stream, $field, $records) {
-        $len= isset($field["len"]) ? $field["len"]- 1 : $stream->getByte()- 1;
+        $len= ($field["len"] ?? $stream->getByte()) - 1;
         if (-1 === $len) return null;
         $pos= $stream->getByte();
         for ($j= 0, $n= 0, $m= $pos ? 1 : -1; $j < $len; $j+= 4, $m= bcmul($m, "4294967296", 0)) {
@@ -55,7 +55,7 @@ public function unmarshal($stream, $field, $records) {
     }');
     $records[self::T_UNIQUE]= newinstance('rdbms.tds.TdsRecord', [], '{
       public function unmarshal($stream, $field, $records) {
-        $len= isset($field["len"]) ? $field["len"] : $stream->getByte();
+        $len= $field["len"] ?? $stream->getByte();
         if (0 === $len) return null;
 
         $bytes= $stream->read($len);
@@ -116,7 +116,7 @@ public function unmarshal($stream, $field, $records) {
     }');
     self::$recordsFor[0][self::T_DATETIMN]= newinstance('rdbms.tds.TdsRecord', [], '{
       public function unmarshal($stream, $field, $records) {
-        $len= isset($field["len"]) ? $field["len"] : $stream->getByte();
+        $len= $field["len"] ?? $stream->getByte();
         switch ($len) {
           case 4: return $this->toDate($stream->getShort(), $stream->getShort() * 60); break;
           case 8: return $this->toDate($stream->getLong(), $stream->getLong() / 300); break;